From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 538BDEE49A0 for ; Wed, 23 Aug 2023 10:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232575AbjHWKlu (ORCPT ); Wed, 23 Aug 2023 06:41:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233938AbjHWKlt (ORCPT ); Wed, 23 Aug 2023 06:41:49 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66D9110C2 for ; Wed, 23 Aug 2023 03:41:27 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-51a52a7d859so13336868a12.0 for ; Wed, 23 Aug 2023 03:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692787286; x=1693392086; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=luKSEkNHiJRZAB6CryJlC1Oxi9BGNpClACXQ8Byw5Ic=; b=WHVr3HZgyTJ7JTawR9mmUrc1TBY0MrtURZADRnta4gzWZO7eB/iKdw/160bcKpvl9i ePJ/+1R77StPY720Ub/DLd8J2s4ExkC+t+F6cAZ88n8WQUZLGzGd3YuERdpFrb0swovf gYGnlWMnZH0kdywLOqv98SjUIeCeh3vDZk87dI3wGnXqeHwq9Po3dOrE8w6T0lSeCFyV bhc/qB36yhxxB8EOt9onU+ppY5F4xD/RiTjbbk3Uax+/+16BcmaH47xTpIApiD/x6RDl GCKouXspBDwi38Az3oGZ3usxD+wBli+9/0o2gekVGDpAUgbgEIe1jtOeSAhHqU3ClGjW lHRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692787286; x=1693392086; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=luKSEkNHiJRZAB6CryJlC1Oxi9BGNpClACXQ8Byw5Ic=; b=BGikQcy2Rm1V7h0jJwwrI8OL7CZETzz4aLrHjJ+cQONmvm7Aogbtsy/WH0FJyK16Gh 5sD3sBOCc0RQUS/QNhZxjYgQ8z/5MFcGkYyPerCLCgmKkbDK7ztkfMbPYbsDd55CaZpz LMfzeJKdLjupLthFS7XVrtHL+YLvfSpQr2bzQ/I16zG1phkt+cxT7H8yvMMT94/oyXzk 2kFbpDEg2x3QtyQwqrbuJbYq4XULlJfNqoW5v+DnSd7kbOBgjowntNs9+3kE0OaFXpF4 Ho7O6SnCL8VgmXr3XG3gDz7amVc5pKGRhepZBY1wmi89/BmIPyn/+5FxfE98EoXZhvdW 8zRA== X-Gm-Message-State: AOJu0Yz8LJmrG3KlDbKTPuCc/HzL25YouV3pcNSz9KWrPgOIItHb6VNi qpTBadw9zArAQF//8+H++RXtrA== X-Google-Smtp-Source: AGHT+IHk9k1hH/H67+GxhAgsuEhHp0Vfnm4zlNLJH/6uPQbuzNozS/abWV6JKzOj29LYEWBxLKGysA== X-Received: by 2002:aa7:de12:0:b0:522:3149:159b with SMTP id h18-20020aa7de12000000b005223149159bmr14808420edv.2.1692787285921; Wed, 23 Aug 2023 03:41:25 -0700 (PDT) Received: from linaro.org ([84.232.191.92]) by smtp.gmail.com with ESMTPSA id s10-20020a056402164a00b0052a3c7c9e8bsm453069edx.56.2023.08.23.03.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 03:41:25 -0700 (PDT) Date: Wed, 23 Aug 2023 13:41:23 +0300 From: Abel Vesa To: Konrad Dybcio Cc: "Rafael J . Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Greg Kroah-Hartman , Bjorn Andersson , Andy Gross , Mike Turquette , Stephen Boyd , Taniya Das , linux-pm@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, Jagadeesh Kona Subject: Re: [PATCH v2 4/6] clk: qcom: Use HW_CTRL_TRIGGER flag to switch video GDSC to HW mode Message-ID: References: <20230816145741.1472721-1-abel.vesa@linaro.org> <20230816145741.1472721-5-abel.vesa@linaro.org> <2fc0d771-cee2-4826-a62a-56ed4bfad3a2@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2fc0d771-cee2-4826-a62a-56ed4bfad3a2@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 23-08-16 19:56:46, Konrad Dybcio wrote: > On 16.08.2023 16:57, Abel Vesa wrote: > > From: Jagadeesh Kona > > > > The current HW_CTRL flag switches the video GDSC to HW control mode as > > part of GDSC enable itself, instead of that use HW_CTRL_TRIGGER flag to > > give consumer drivers more control and switch the GDSC mode as and when > > required. > > > > HW_CTRL_TRIGGER flag allows consumer drivers to switch the video GDSC to > > HW/SW control modes at runtime using dev_pm_genpd_set_hwmode API. > > > > Signed-off-by: Jagadeesh Kona > > Signed-off-by: Abel Vesa > > --- > Do we have any use for the HW_CTRL flag? > > Perhaps it should be renamed to HW_CTRL_ALWAYS? > > Or even better, *if and only if* that is necessary, add a common > property like "always_hw_managed" to the genpd code? The HW_CTRL flag is still needed for the consumers that expect the GDSC to be have the HW control bit set right after it gets enabled. AFAIU, for the HW_CTRL_TRIGGER, the switch to HW control will only be done by the consumer (not on enable). > > Konrad