From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89154CA0EC0 for ; Mon, 11 Sep 2023 21:16:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241139AbjIKVG6 (ORCPT ); Mon, 11 Sep 2023 17:06:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236317AbjIKKPS (ORCPT ); Mon, 11 Sep 2023 06:15:18 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4256E5F; Mon, 11 Sep 2023 03:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694427314; x=1725963314; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MVY1RCA+Y6jHOKSik1rPFvNz857POHLvrx8p+7Ur7ao=; b=AVlReW0MCpg9k0qw3TN/c+YAABjy4ysXKq1plWxaK6VfjZM34rW4vfiJ VG9I6qAr/KBY5YagdMff/ES05p1DPNe6PqFAVxeXOb7xVhPpqDao1uG00 3fMc7xmVoY1W/CmtSy2ch8TtnUugvjlfpFXLk77GNiJbyfla1+FTm7A/n DZboe8njupLW6YOdWVMpb3Q5FuJalnEzDItT+BVx+4rXSv2NGUpUn96wp GoHtE6N6fDeN1Cmw0CgcUv7L3QimSu8DWl7y3HLVfxS+GHSpJphQiBtzE FBkIUHSIZiYOMXGjB89x2EZctkwdFAzluDKBZEq3liB6wMU+3MV9krB/q w==; X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="376958369" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="376958369" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 03:15:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="886466175" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="886466175" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 03:14:48 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qfdwk-008Hv0-0D; Mon, 11 Sep 2023 13:15:10 +0300 Date: Mon, 11 Sep 2023 13:15:09 +0300 From: Andy Shevchenko To: Biju Das Cc: Sebastian Reichel , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Biju Das Subject: Re: [PATCH 1/2] power: supply: bq24257_charger: Make chip type and name in sync Message-ID: References: <20230902193331.83672-1-biju.das.jz@bp.renesas.com> <20230902193331.83672-2-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sun, Sep 10, 2023 at 07:10:06AM +0000, Biju Das wrote: > Hi Andy Shevchenko, > > On Sat, Sep 02, 2023 at 08:33:30PM +0100, Biju Das wrote: ... > > > - if (ACPI_HANDLE(dev)) { > > > - acpi_id = acpi_match_device(dev->driver->acpi_match_table, > > > - &client->dev); > > > - if (!acpi_id) { > > > - dev_err(dev, "Failed to match ACPI device\n"); > > > - return -ENODEV; > > > - } > > > - bq->chip = (enum bq2425x_chip)acpi_id->driver_data; > > > - } else { > > > - bq->chip = (enum bq2425x_chip)id->driver_data; > > > - } > > > > Do we still need acpi.h after this change? > > Yes, it is still needed as it is using > ACPI_PTR. Can we, please, drop ACPI_PTR() as it's more harmful than useful (same way as you dropped the ifdeffery for OF cases in other patches)? -- With Best Regards, Andy Shevchenko