From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Biju Das <biju.das.au@gmail.com>
Subject: Re: [PATCH 2/2] power: supply: bq2515x: Some cleanups
Date: Mon, 4 Sep 2023 13:11:12 +0300 [thread overview]
Message-ID: <ZPWtQDL5f0sgRJTM@smile.fi.intel.com> (raw)
In-Reply-To: <ZPWs+xtfQUlGOaVe@smile.fi.intel.com>
On Mon, Sep 04, 2023 at 01:10:04PM +0300, Andy Shevchenko wrote:
> On Sat, Sep 02, 2023 at 09:05:18PM +0100, Biju Das wrote:
> > Some cleanups:
> > * Remove trailing comma in the terminator entry for OF/ID table.
> > * Drop a space from terminator entry for OF table.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Btw, in all similar patches you may add the reason(s) why you are doing that:
>
> 1/ unification;
> 2/ making code robust against (theoretical) misrebases or other similar things
> where the new entry goes _after_ the termination without compiler noticing.
I.o.w. "terminator" has to "terminate" at run-time _and_ at compile-time.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-04 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 20:05 [PATCH 0/2] Match data improvements for bq2515x driver Biju Das
2023-09-02 20:05 ` [PATCH 1/2] power: supply: bq2515x: Simpilfy bq2515x_read_properties() and probe() Biju Das
2023-09-04 10:12 ` Andy Shevchenko
2023-09-10 7:03 ` Biju Das
2023-09-02 20:05 ` [PATCH 2/2] power: supply: bq2515x: Some cleanups Biju Das
2023-09-04 10:10 ` Andy Shevchenko
2023-09-04 10:11 ` Andy Shevchenko [this message]
2023-09-12 21:45 ` [PATCH 0/2] Match data improvements for bq2515x driver Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPWtQDL5f0sgRJTM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).