From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CFFBCD54AB for ; Tue, 19 Sep 2023 09:56:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231779AbjISJ5B (ORCPT ); Tue, 19 Sep 2023 05:57:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231895AbjISJ4t (ORCPT ); Tue, 19 Sep 2023 05:56:49 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A42D19B7; Tue, 19 Sep 2023 02:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BHDU/uL8LxSg62Q/u4osBO6lMbutGaWzvUBNKWgWQLM=; b=pLvrwD4msGWTwxI8101DXka/78 DZEMxr08Dp8UAFTjZbVfC9lF+XzkCI4X73WOV7xA6bvQQrmxHHgrwHTsGvzqcv7QjmXFtuvJZPXrr e80aORF125Xth3z/Nr4XDOaFG+q7HzMK8hA9mFOhJ2ewEwudulmxbBQgiyQ9tA2CARLvEr8slMmQT YUuQGIbaP48KiRH0+Utzxhqxt65swdcVCy5eD+L+bwYLGmobeQZGiGQv/jhOEh64rD4JlvW02y4ae sOrAwSmaJ5sap4IFpnXyYAFAFVYzvkv73YnhzlE77IZrS/t1HHduvLPnImGQPMFj0YPU5O4QmE7ha 489v0a7A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33864) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qiXS4-0001em-11; Tue, 19 Sep 2023 10:55:28 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qiXS3-0001P0-3I; Tue, 19 Sep 2023 10:55:27 +0100 Date: Tue, 19 Sep 2023 10:55:27 +0100 From: "Russell King (Oracle)" To: Gavin Shan Cc: James Morse , linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com Subject: Re: [RFC PATCH v2 32/35] ACPI: add support to register CPUs based on the _STA enabled bit Message-ID: References: <20230913163823.7880-1-james.morse@arm.com> <20230913163823.7880-33-james.morse@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Sep 19, 2023 at 02:46:22PM +1000, Gavin Shan wrote: > The message needs to be split up into multiple lines to make ./scripts/checkpatch.pl > happy: > > pr_err_once(FW_BUG "CPU %u is online, but described " > "as not present or disabled!\n", pr->id); No. checkpatch is wrong on this point. Splitting the message like this hurts debuggability, because the message can no longer be grepped for. What James has done is perfectly fine. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!