From: Wolfram Sang <wsa@kernel.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Len Brown <lenb@kernel.org>,
Todd E Brandt <todd.e.brandt@linux.intel.com>,
Xueqin Luo <luoxueqin@kylinos.cn>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm <linux-pm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PM: tools: Fix sleepgraph syntax error
Date: Wed, 15 Nov 2023 12:21:26 -0500 [thread overview]
Message-ID: <ZVT+Fq1yVZ9G8pqx@shikoro> (raw)
In-Reply-To: <a5f86bcf03b2ed809245d57f5971ae42a8b85128.camel@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Wed, Nov 15, 2023 at 11:47:51AM -0500, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> The sleepgraph tool currently fails:
>
> File "/usr/bin/sleepgraph", line 4155
> or re.match('psci: CPU(?P<cpu>[0-9]*) killed.*', msg)):
> ^
> SyntaxError: unmatched ')'
>
> Fixes: 34ea427e01ea ("PM: tools: sleepgraph: Recognize "CPU killed" messages")
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Had the same issue:
Reviewed-by: Wolfram Sang <wsa@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-11-15 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 16:47 [PATCH] PM: tools: Fix sleepgraph syntax error David Woodhouse
2023-11-15 17:21 ` Wolfram Sang [this message]
2023-11-20 17:01 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVT+Fq1yVZ9G8pqx@shikoro \
--to=wsa@kernel.org \
--cc=dwmw2@infradead.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luoxueqin@kylinos.cn \
--cc=rafael.j.wysocki@intel.com \
--cc=todd.e.brandt@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox