From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "David E. Box" <david.e.box@linux.intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Kenneth R. Crudup" <kenny@panix.com>,
vidyas@nvidia.com, bhelgaas@google.com,
kai.heng.feng@canonical.com, andrea.righi@canonical.com,
vicamo.yang@canonical.com,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Ricky WU" <ricky_wu@realtek.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
linux-pm@vger.kernel.org, linux-pci@vger.kernel.org,
"Thomas Witt" <kernel@witt.link>
Subject: Re: My AlderLake Dell (XPS-9320) needs these patches to get full standby/low-power modes
Date: Thu, 16 Nov 2023 23:27:48 +0000 [thread overview]
Message-ID: <ZValdAmd027avr20@srcf.ucam.org> (raw)
In-Reply-To: <20231116231812.GA57394@bhelgaas>
On Thu, Nov 16, 2023 at 05:18:12PM -0600, Bjorn Helgaas wrote:
> I think this would be better as a quirk instead of a driver probe
> method because I don't think ASPM really has anything to do with the
> driver probe. We do most ASPM configuration at enumeration (before
> driver probe), so now we have this exception that we delay it until
> probe time if the policy is POLICY_POWERSAVE or
> POLICY_POWER_SUPERSAVE.
I think doing this as a quirk would probably work fine, but from an
aesthetic point of view it feels awkward - this is knowledge that the
drivers have, and so fundamentally placing that knowledge in the core
PCI code feels like the wrong place to put it.
next prev parent reply other threads:[~2023-11-16 23:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 17:13 My AlderLake Dell (XPS-9320) needs these patches to get full standby/low-power modes Kenneth R. Crudup
2023-11-06 18:11 ` Bjorn Helgaas
2023-11-07 11:15 ` Mika Westerberg
2023-11-16 20:10 ` David E. Box
2023-11-16 23:18 ` Bjorn Helgaas
2023-11-16 23:27 ` Matthew Garrett [this message]
2023-11-18 0:21 ` David E. Box
2023-12-21 1:19 ` David E. Box
2023-12-27 0:03 ` Bjorn Helgaas
2024-05-13 5:23 ` Kenneth R. Crudup
2023-11-08 15:44 ` Kenneth R. Crudup
2023-11-08 11:45 ` Kai-Heng Feng
2023-11-08 15:46 ` Kenneth R. Crudup
2024-03-12 2:37 ` Kenneth R. Crudup
2024-03-21 10:12 ` Kai-Heng Feng
2024-07-15 18:27 ` Kenneth Crudup
2024-07-17 1:59 ` Kai-Heng Feng
2024-07-17 3:39 ` Kenneth Crudup
2024-07-17 4:40 ` Kenneth Crudup
2024-07-17 23:46 ` Kenneth Crudup
2024-12-11 23:26 ` Kenneth Crudup
2024-12-12 20:56 ` Bjorn Helgaas
2024-12-12 23:04 ` Kenneth Crudup
2024-12-12 23:13 ` Kenneth Crudup
2024-12-13 16:43 ` Bjorn Helgaas
2024-12-13 19:48 ` Kenneth Crudup
2024-12-13 20:27 ` Kenneth Crudup
2024-12-13 22:26 ` Kenneth Crudup
2024-12-13 22:33 ` Kenneth Crudup
2024-12-13 23:02 ` Bjorn Helgaas
2024-12-19 16:25 ` David E. Box
2024-12-19 18:17 ` Kenneth Crudup
2024-12-19 19:52 ` David E. Box
2024-12-19 20:37 ` Kenneth Crudup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZValdAmd027avr20@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=andrea.righi@canonical.com \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kenny@panix.com \
--cc=kernel@witt.link \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ricky_wu@realtek.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=vicamo.yang@canonical.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).