From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D1B93D566 for ; Tue, 23 Jan 2024 01:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705973273; cv=none; b=hsH7MsnPxVHrhmHpSLaN5PdtNuze1PR3I+b2GCgVoLs/tgH1/RTzSlKkdCAS/glHwvWZESAGTU1CgRBkaq/2nFoQv6pVEyBBc2YwESmWhswWkM9GtpjdkDA1gfVHMcHG0x7r/OVFG8qV+puD02D+duHJ2uyLdSUfl9+VWPRY9ws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705973273; c=relaxed/simple; bh=xd8+ffjWqKHB0l8qHLvIP4GiBxkGfh3x3os0vr4pLPg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KOp++sa6IDXWfg86N1jCkYl5cAuVri1L5cvNSX/y6j7dLvGMEXHPiHmQl96BgscZzRDyr7M5Zxs0KGCqasMx6N1PjckTr28cBMcnktk6gSru2x7boDDViaqUZr83Mf/ecMryj300Kmu154SHKtAFBZVHQE2q6fhAQY1Vepj5CFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BhNEWLHh; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BhNEWLHh" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-29023dec816so3246677a91.2 for ; Mon, 22 Jan 2024 17:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705973271; x=1706578071; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E3bREx2VvtAxUcOb45LlRTMNit+G8LlhZSP4QTXnOMQ=; b=BhNEWLHhVBvzlrOgpYJ7ALI0+g4QzCf9o9ITTpunQjpZ2gRNtVpvLvT6FLi0szcVCy 88huTKHeBweW6nPGEORd77E1zNVpZ4evMuu7F4nqksAFM0ipVBbetkcm6mqOtN5yltSm l8Gr5maBycjo/txcet5rRz1xKDTt8LUYDXc01Imj8DaK5XrWg+qWIipji9uQmGOLanWD FeSe+Ogk2K9NMKIzGomjYdDaOB+2p2AP3VrHmdaA4RmRXaXOdex6nxZB3facrem3+TAk FGT0VfjzTxHq5+H76HmrmBqvoX66xKH4Jpwti+Vyu86oDI2ETCpaQbE+hsU4Se1v7P04 FYpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705973271; x=1706578071; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E3bREx2VvtAxUcOb45LlRTMNit+G8LlhZSP4QTXnOMQ=; b=ef70EbXAI6ivVuUdg0jOQc5wLJXdoPNmJY1uLNWtPVAi0HMo6owoaxfFmOeUCA+EPc nYEyVnHqRX6ap/0PJEohiGNj7HNrsu/ucw8Yzg+13odhHqON5psFiI2hsi8O9J+vEFH0 X28U82M6c3mfYMTQ4VmUX5pozZ5uFcVwoVi5bmUUk7ZaGI9kHtkHgFrDX/qQAERCzmwy XYU4mYQtPfHdxFrBJTvgXmV10rMznyjK5s76fzW7AR3yfXvmOu7wLpgkid5l/zZm6mOW aMmxYZMxxc3IiXCQmaRArnKhgJQ3nwZQ1f/bKDl72wYyX8teUqlV2k1rpo4FDSeOvHj6 EG1A== X-Gm-Message-State: AOJu0YyPdvBLPjmAee4DMp/dcL/xu4Dk5xiUNpwt1bFUgjqPHdt1ZLoD x8aoG4dEwY/GxIZn4QO25g2svv4rSvKNH2/PWwXJD+M3BwElyFuGzkPpmsH9LMU= X-Google-Smtp-Source: AGHT+IG6pm9bj22UhiTj6Cxqz71zjTlKKL+I94bUy1n5HHp1Y86JfAGyKqD0drTMp6xAzHjCdvhxGA== X-Received: by 2002:a17:90b:606:b0:28e:2784:9827 with SMTP id gb6-20020a17090b060600b0028e27849827mr2581418pjb.17.1705973271519; Mon, 22 Jan 2024 17:27:51 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:b26d:65ee:f38a:4547]) by smtp.gmail.com with ESMTPSA id rr12-20020a17090b2b4c00b0028d9b5d41edsm10283532pjb.38.2024.01.22.17.27.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 17:27:51 -0800 (PST) Date: Mon, 22 Jan 2024 18:27:48 -0700 From: Mathieu Poirier To: Iuliana Prodan Cc: Ulf Hansson , "Rafael J . Wysocki" , Greg Kroah-Hartman , Viresh Kumar , linux-pm@vger.kernel.org, Sudeep Holla , Kevin Hilman , Konrad Dybcio , Bjorn Andersson , Nikunj Kela , Prasad Sodagudi , Stephan Gerhold , Ben Horgan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, linux-media@vger.kernel.org, Shawn Guo , Sascha Hauer , Daniel Baluta Subject: Re: [PATCH v2 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list() Message-ID: References: <20240105160103.183092-1-ulf.hansson@linaro.org> <20240105160103.183092-4-ulf.hansson@linaro.org> <87801f3e-b7ce-46ba-9856-1321635a11b5@nxp.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 22, 2024 at 01:02:08PM -0700, Mathieu Poirier wrote: > On Mon, 22 Jan 2024 at 10:51, Iuliana Prodan wrote: > > > > On 1/5/2024 6:01 PM, Ulf Hansson wrote: > > > Let's avoid the boilerplate code to manage the multiple PM domain case, by > > > converting into using dev_pm_domain_attach|detach_list(). > > > > > > Cc: Mathieu Poirier > > > Cc: Bjorn Andersson > > > Cc: Shawn Guo > > > Cc: Sascha Hauer > > > Cc: Iuliana Prodan > > > Cc: Daniel Baluta > > > Cc: > > > Signed-off-by: Ulf Hansson > > > --- > > > > > > Changes in v2: > > > - None. > > > > > > Iuliana/Daniel I am ccing you to request help with test/review of this change. > > > Note that, you will need patch 1/5 in the series too, to be able to test this. > > > > > > Kind regards > > > Ulf Hansson > > > > Tested-by: Iuliana Prodan > > Reviewed-by: Iuliana Prodan > > > > Thanks for the leg-work on this. I'll pick this up in rc1 later this week. Looking at the other files in this set, Ulf of perhaps Bjorn should take this set. for: drivers/remoteproc/imx_rproc.c drivers/remoteproc/imx_dsp_rproc.c Reviewed-by: Mathieu Poirier > > > Iulia > > > > > --- > > > drivers/remoteproc/imx_rproc.c | 73 +++++----------------------------- > > > 1 file changed, 9 insertions(+), 64 deletions(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > > > index 8bb293b9f327..3161f14442bc 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -92,7 +92,6 @@ struct imx_rproc_mem { > > > > > > static int imx_rproc_xtr_mbox_init(struct rproc *rproc); > > > static void imx_rproc_free_mbox(struct rproc *rproc); > > > -static int imx_rproc_detach_pd(struct rproc *rproc); > > > > > > struct imx_rproc { > > > struct device *dev; > > > @@ -113,10 +112,8 @@ struct imx_rproc { > > > u32 rproc_pt; /* partition id */ > > > u32 rsrc_id; /* resource id */ > > > u32 entry; /* cpu start address */ > > > - int num_pd; > > > u32 core_index; > > > - struct device **pd_dev; > > > - struct device_link **pd_dev_link; > > > + struct dev_pm_domain_list *pd_list; > > > }; > > > > > > static const struct imx_rproc_att imx_rproc_att_imx93[] = { > > > @@ -853,7 +850,7 @@ static void imx_rproc_put_scu(struct rproc *rproc) > > > return; > > > > > > if (imx_sc_rm_is_resource_owned(priv->ipc_handle, priv->rsrc_id)) { > > > - imx_rproc_detach_pd(rproc); > > > + dev_pm_domain_detach_list(priv->pd_list); > > > return; > > > } > > > > > > @@ -880,72 +877,20 @@ static int imx_rproc_partition_notify(struct notifier_block *nb, > > > static int imx_rproc_attach_pd(struct imx_rproc *priv) > > > { > > > struct device *dev = priv->dev; > > > - int ret, i; > > > - > > > - /* > > > - * If there is only one power-domain entry, the platform driver framework > > > - * will handle it, no need handle it in this driver. > > > - */ > > > - priv->num_pd = of_count_phandle_with_args(dev->of_node, "power-domains", > > > - "#power-domain-cells"); > > > - if (priv->num_pd <= 1) > > > - return 0; > > > - > > > - priv->pd_dev = devm_kmalloc_array(dev, priv->num_pd, sizeof(*priv->pd_dev), GFP_KERNEL); > > > - if (!priv->pd_dev) > > > - return -ENOMEM; > > > - > > > - priv->pd_dev_link = devm_kmalloc_array(dev, priv->num_pd, sizeof(*priv->pd_dev_link), > > > - GFP_KERNEL); > > > - > > > - if (!priv->pd_dev_link) > > > - return -ENOMEM; > > > - > > > - for (i = 0; i < priv->num_pd; i++) { > > > - priv->pd_dev[i] = dev_pm_domain_attach_by_id(dev, i); > > > - if (IS_ERR(priv->pd_dev[i])) { > > > - ret = PTR_ERR(priv->pd_dev[i]); > > > - goto detach_pd; > > > - } > > > - > > > - priv->pd_dev_link[i] = device_link_add(dev, priv->pd_dev[i], DL_FLAG_STATELESS | > > > - DL_FLAG_PM_RUNTIME | DL_FLAG_RPM_ACTIVE); > > > - if (!priv->pd_dev_link[i]) { > > > - dev_pm_domain_detach(priv->pd_dev[i], false); > > > - ret = -EINVAL; > > > - goto detach_pd; > > > - } > > > - } > > > - > > > - return 0; > > > - > > > -detach_pd: > > > - while (--i >= 0) { > > > - device_link_del(priv->pd_dev_link[i]); > > > - dev_pm_domain_detach(priv->pd_dev[i], false); > > > - } > > > - > > > - return ret; > > > -} > > > - > > > -static int imx_rproc_detach_pd(struct rproc *rproc) > > > -{ > > > - struct imx_rproc *priv = rproc->priv; > > > - int i; > > > + int ret; > > > + struct dev_pm_domain_attach_data pd_data = { > > > + .pd_flags = PD_FLAG_DEV_LINK_ON, > > > + }; > > > > > > /* > > > * If there is only one power-domain entry, the platform driver framework > > > * will handle it, no need handle it in this driver. > > > */ > > > - if (priv->num_pd <= 1) > > > + if (dev->pm_domain) > > > return 0; > > > > > > - for (i = 0; i < priv->num_pd; i++) { > > > - device_link_del(priv->pd_dev_link[i]); > > > - dev_pm_domain_detach(priv->pd_dev[i], false); > > > - } > > > - > > > - return 0; > > > + ret = dev_pm_domain_attach_list(dev, &pd_data, &priv->pd_list); > > > + return ret < 0 ? ret : 0; > > > } > > > > > > static int imx_rproc_detect_mode(struct imx_rproc *priv)