* [PATCH 0/2] interconnect: qcom: ACV enable_mask fixes
@ 2024-02-02 1:48 Mike Tipton
2024-02-02 1:48 ` [PATCH 1/2] interconnect: qcom: sm8650: Use correct ACV enable_mask Mike Tipton
2024-02-02 1:48 ` [PATCH 2/2] interconnect: qcom: x1e80100: Add missing " Mike Tipton
0 siblings, 2 replies; 7+ messages in thread
From: Mike Tipton @ 2024-02-02 1:48 UTC (permalink / raw)
To: andersson, konrad.dybcio, djakov
Cc: neil.armstrong, quic_rjendra, quic_sibis, abel.vesa,
linux-arm-msm, linux-pm, linux-kernel, Mike Tipton
A couple small fixes for targets using incorrect ACV enable_masks.
Mike Tipton (2):
interconnect: qcom: sm8650: Use correct ACV enable_mask
interconnect: qcom: x1e80100: Add missing ACV enable_mask
drivers/interconnect/qcom/sm8650.c | 2 +-
drivers/interconnect/qcom/x1e80100.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] interconnect: qcom: sm8650: Use correct ACV enable_mask
2024-02-02 1:48 [PATCH 0/2] interconnect: qcom: ACV enable_mask fixes Mike Tipton
@ 2024-02-02 1:48 ` Mike Tipton
2024-02-02 11:29 ` Konrad Dybcio
2024-02-03 14:49 ` neil.armstrong
2024-02-02 1:48 ` [PATCH 2/2] interconnect: qcom: x1e80100: Add missing " Mike Tipton
1 sibling, 2 replies; 7+ messages in thread
From: Mike Tipton @ 2024-02-02 1:48 UTC (permalink / raw)
To: andersson, konrad.dybcio, djakov
Cc: neil.armstrong, quic_rjendra, quic_sibis, abel.vesa,
linux-arm-msm, linux-pm, linux-kernel, Mike Tipton
The ACV enable_mask is historically BIT(3), but it's BIT(0) on this
target. Fix it.
Fixes: c062bcab5924 ("interconnect: qcom: introduce RPMh Network-On-Chip Interconnect on SM8650 SoC")
Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com>
---
drivers/interconnect/qcom/sm8650.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/interconnect/qcom/sm8650.c b/drivers/interconnect/qcom/sm8650.c
index b83de54577b6..b962e6c233ef 100644
--- a/drivers/interconnect/qcom/sm8650.c
+++ b/drivers/interconnect/qcom/sm8650.c
@@ -1160,7 +1160,7 @@ static struct qcom_icc_node qns_gemnoc_sf = {
static struct qcom_icc_bcm bcm_acv = {
.name = "ACV",
- .enable_mask = BIT(3),
+ .enable_mask = BIT(0),
.num_nodes = 1,
.nodes = { &ebi },
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] interconnect: qcom: sm8650: Use correct ACV enable_mask
2024-02-02 1:48 ` [PATCH 1/2] interconnect: qcom: sm8650: Use correct ACV enable_mask Mike Tipton
@ 2024-02-02 11:29 ` Konrad Dybcio
2024-02-03 14:49 ` neil.armstrong
1 sibling, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2024-02-02 11:29 UTC (permalink / raw)
To: Mike Tipton, andersson, djakov
Cc: neil.armstrong, quic_rjendra, quic_sibis, abel.vesa,
linux-arm-msm, linux-pm, linux-kernel
On 2.02.2024 02:48, Mike Tipton wrote:
> The ACV enable_mask is historically BIT(3), but it's BIT(0) on this
> target. Fix it.
>
> Fixes: c062bcab5924 ("interconnect: qcom: introduce RPMh Network-On-Chip Interconnect on SM8650 SoC")
> Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com>
> ---
Downstream agrees
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] interconnect: qcom: sm8650: Use correct ACV enable_mask
2024-02-02 1:48 ` [PATCH 1/2] interconnect: qcom: sm8650: Use correct ACV enable_mask Mike Tipton
2024-02-02 11:29 ` Konrad Dybcio
@ 2024-02-03 14:49 ` neil.armstrong
1 sibling, 0 replies; 7+ messages in thread
From: neil.armstrong @ 2024-02-03 14:49 UTC (permalink / raw)
To: Mike Tipton, andersson, konrad.dybcio, djakov
Cc: quic_rjendra, quic_sibis, abel.vesa, linux-arm-msm, linux-pm,
linux-kernel
On 02/02/2024 02:48, Mike Tipton wrote:
> The ACV enable_mask is historically BIT(3), but it's BIT(0) on this
> target. Fix it.
>
> Fixes: c062bcab5924 ("interconnect: qcom: introduce RPMh Network-On-Chip Interconnect on SM8650 SoC")
> Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com>
> ---
> drivers/interconnect/qcom/sm8650.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/interconnect/qcom/sm8650.c b/drivers/interconnect/qcom/sm8650.c
> index b83de54577b6..b962e6c233ef 100644
> --- a/drivers/interconnect/qcom/sm8650.c
> +++ b/drivers/interconnect/qcom/sm8650.c
> @@ -1160,7 +1160,7 @@ static struct qcom_icc_node qns_gemnoc_sf = {
>
> static struct qcom_icc_bcm bcm_acv = {
> .name = "ACV",
> - .enable_mask = BIT(3),
> + .enable_mask = BIT(0),
> .num_nodes = 1,
> .nodes = { &ebi },
> };
Indeed it changed in the meantime
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] interconnect: qcom: x1e80100: Add missing ACV enable_mask
2024-02-02 1:48 [PATCH 0/2] interconnect: qcom: ACV enable_mask fixes Mike Tipton
2024-02-02 1:48 ` [PATCH 1/2] interconnect: qcom: sm8650: Use correct ACV enable_mask Mike Tipton
@ 2024-02-02 1:48 ` Mike Tipton
2024-02-02 11:30 ` Konrad Dybcio
2024-02-02 16:57 ` Abel Vesa
1 sibling, 2 replies; 7+ messages in thread
From: Mike Tipton @ 2024-02-02 1:48 UTC (permalink / raw)
To: andersson, konrad.dybcio, djakov
Cc: neil.armstrong, quic_rjendra, quic_sibis, abel.vesa,
linux-arm-msm, linux-pm, linux-kernel, Mike Tipton
The ACV BCM is voted using bitmasks. Add the proper mask for this
target.
Fixes: 9f196772841e ("interconnect: qcom: Add X1E80100 interconnect provider driver")
Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com>
---
drivers/interconnect/qcom/x1e80100.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/interconnect/qcom/x1e80100.c b/drivers/interconnect/qcom/x1e80100.c
index 5b2de9c3a1d6..281295a9a077 100644
--- a/drivers/interconnect/qcom/x1e80100.c
+++ b/drivers/interconnect/qcom/x1e80100.c
@@ -1372,6 +1372,7 @@ static struct qcom_icc_node qns_aggre_usb_south_snoc = {
static struct qcom_icc_bcm bcm_acv = {
.name = "ACV",
+ .enable_mask = BIT(3),
.num_nodes = 1,
.nodes = { &ebi },
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] interconnect: qcom: x1e80100: Add missing ACV enable_mask
2024-02-02 1:48 ` [PATCH 2/2] interconnect: qcom: x1e80100: Add missing " Mike Tipton
@ 2024-02-02 11:30 ` Konrad Dybcio
2024-02-02 16:57 ` Abel Vesa
1 sibling, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2024-02-02 11:30 UTC (permalink / raw)
To: Mike Tipton, andersson, djakov
Cc: neil.armstrong, quic_rjendra, quic_sibis, abel.vesa,
linux-arm-msm, linux-pm, linux-kernel
On 2.02.2024 02:48, Mike Tipton wrote:
> The ACV BCM is voted using bitmasks. Add the proper mask for this
> target.
>
> Fixes: 9f196772841e ("interconnect: qcom: Add X1E80100 interconnect provider driver")
> Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] interconnect: qcom: x1e80100: Add missing ACV enable_mask
2024-02-02 1:48 ` [PATCH 2/2] interconnect: qcom: x1e80100: Add missing " Mike Tipton
2024-02-02 11:30 ` Konrad Dybcio
@ 2024-02-02 16:57 ` Abel Vesa
1 sibling, 0 replies; 7+ messages in thread
From: Abel Vesa @ 2024-02-02 16:57 UTC (permalink / raw)
To: Mike Tipton
Cc: andersson, konrad.dybcio, djakov, neil.armstrong, quic_rjendra,
quic_sibis, linux-arm-msm, linux-pm, linux-kernel
On 24-02-01 17:48:06, Mike Tipton wrote:
> The ACV BCM is voted using bitmasks. Add the proper mask for this
> target.
>
> Fixes: 9f196772841e ("interconnect: qcom: Add X1E80100 interconnect provider driver")
> Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com>
Tested-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/interconnect/qcom/x1e80100.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/interconnect/qcom/x1e80100.c b/drivers/interconnect/qcom/x1e80100.c
> index 5b2de9c3a1d6..281295a9a077 100644
> --- a/drivers/interconnect/qcom/x1e80100.c
> +++ b/drivers/interconnect/qcom/x1e80100.c
> @@ -1372,6 +1372,7 @@ static struct qcom_icc_node qns_aggre_usb_south_snoc = {
>
> static struct qcom_icc_bcm bcm_acv = {
> .name = "ACV",
> + .enable_mask = BIT(3),
> .num_nodes = 1,
> .nodes = { &ebi },
> };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-02-03 14:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-02 1:48 [PATCH 0/2] interconnect: qcom: ACV enable_mask fixes Mike Tipton
2024-02-02 1:48 ` [PATCH 1/2] interconnect: qcom: sm8650: Use correct ACV enable_mask Mike Tipton
2024-02-02 11:29 ` Konrad Dybcio
2024-02-03 14:49 ` neil.armstrong
2024-02-02 1:48 ` [PATCH 2/2] interconnect: qcom: x1e80100: Add missing " Mike Tipton
2024-02-02 11:30 ` Konrad Dybcio
2024-02-02 16:57 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).