From: Sasha Levin <sashal@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Luca Weiss <luca.weiss@fairphone.com>,
andersson@kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH AUTOSEL 6.7 15/39] power: supply: qcom_battmgr: Register the power supplies after PDR is up
Date: Tue, 30 Jan 2024 18:01:31 -0500 [thread overview]
Message-ID: <Zbl_y-KmQhCnN7Tu@sashalap> (raw)
In-Reply-To: <rtghydsz532x6atjeshexkgevqlfxmw5owjexmnczwepeefvlb@gxinnf23tzij>
On Mon, Jan 29, 2024 at 02:03:14PM +0100, Sebastian Reichel wrote:
>Hi,
>
>On Sun, Jan 28, 2024 at 11:10:35AM -0500, Sasha Levin wrote:
>> From: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>> [ Upstream commit b43f7ddc2b7a5a90447d96cb4d3c6d142dd4a810 ]
>>
>> Currently, a not-yet-entirely-initialized battmgr (e.g. with pd-mapper
>> not having yet started or ADSP not being up etc.) results in a couple of
>> zombie power supply devices hanging around.
>>
>> This is particularly noticeable when trying to suspend the device (even
>> s2idle): the PSY-internal thermal zone is inaccessible and returns
>> -ENODEV, which causes log spam.
>>
>> Register the power supplies only after we received some notification
>> indicating battmgr is ready to take off.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> Tested-by: Luca Weiss <luca.weiss@fairphone.com>
>> Link: https://lore.kernel.org/r/20231218-topic-battmgr_fixture_attempt-v1-1-6145745f34fe@linaro.org
>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>
>Please drop it, I have a patch queued reverting this patch.
Dropped, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2024-01-30 23:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240128161130.200783-1-sashal@kernel.org>
2024-01-28 16:10 ` [PATCH AUTOSEL 6.7 15/39] power: supply: qcom_battmgr: Register the power supplies after PDR is up Sasha Levin
2024-01-29 13:03 ` Sebastian Reichel
2024-01-30 23:01 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbl_y-KmQhCnN7Tu@sashalap \
--to=sashal@kernel.org \
--cc=andersson@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=sebastian.reichel@collabora.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox