From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Nicolas Pitre <npitre@baylibre.com>
Cc: Julien Panis <jpanis@baylibre.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 0/6] Mediatek thermal sensor driver support for MT8186 and MT8188
Date: Fri, 24 May 2024 18:19:50 +0100 [thread overview]
Message-ID: <ZlDMNkdE2jmFgD8B@shell.armlinux.org.uk> (raw)
In-Reply-To: <238nnn48-0o7r-22q2-2rpo-s3n7n62pn2q4@onlyvoer.pbz>
On Fri, May 24, 2024 at 01:04:38PM -0400, Nicolas Pitre wrote:
> On Fri, 24 May 2024, Julien Panis wrote:
>
> > [RFC] When PATCH 1/6 and 2/6 are squashed, checkpatch raises this WARNING:
> > "DT binding docs and includes should be a separate patch." That's why I
> > split them in this v5. The problem is that the driver can't be compiled
> > any more at PATCH 1/6. It needs PATCH 2/6 to be compiled. Should the
> > checkpatch warning be ignored here ? Should I finally squash PATCH 1/6
> > and PATCH 2/6 ?
>
> IMHO it might be preferable to preserve successful compilation across
> bisection than to appeal to checkpatch in this case.
Or, patch 1 adds the new definitions, subsequent patches convert the
users, and the last patch removes the old, now unused, definitions.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-05-24 17:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 9:04 [PATCH v5 0/6] Mediatek thermal sensor driver support for MT8186 and MT8188 Julien Panis
2024-05-24 9:04 ` [PATCH v5 1/6] dt-bindings: thermal: mediatek: Rename thermal zone definitions " Julien Panis
2024-05-24 18:24 ` Conor Dooley
2024-05-24 18:27 ` Conor Dooley
2024-05-27 15:25 ` Julien Panis
2024-05-27 17:28 ` Conor Dooley
2024-05-27 20:57 ` Nicolas Pitre
2024-05-27 21:07 ` Conor Dooley
2024-05-27 8:14 ` Julien Panis
2024-05-24 9:04 ` [PATCH v5 2/6] thermal/drivers/mediatek/lvts_thermal: Use renamed " Julien Panis
2024-05-24 9:04 ` [PATCH v5 3/6] arm64: dts: mediatek: mt8186: add lvts definitions Julien Panis
2024-05-24 9:04 ` [PATCH v5 4/6] arm64: dts: mediatek: mt8186: add default thermal zones Julien Panis
2024-05-24 9:04 ` [PATCH v5 5/6] arm64: dts: mediatek: mt8188: add lvts definitions Julien Panis
2024-05-24 9:04 ` [PATCH v5 6/6] arm64: dts: mediatek: mt8188: add default thermal zones Julien Panis
2024-05-24 17:04 ` [PATCH v5 0/6] Mediatek thermal sensor driver support for MT8186 and MT8188 Nicolas Pitre
2024-05-24 17:19 ` Russell King (Oracle) [this message]
2024-05-27 8:38 ` Julien Panis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlDMNkdE2jmFgD8B@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jpanis@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=npitre@baylibre.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox