From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEA9F1422C3; Fri, 12 Jul 2024 11:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720782448; cv=none; b=gB8qR9nh0k6vFL6aH8CdvOq2ttomJ5lvFrWM7zc9yhsq6XBeHSxJe+8FYFjkLCH4PExxirTZw95BAYYD/UO2yvowy8PM5oQ/5hoo6i7fydmf1WNn4xFxZLOqNezRUKnuZuleuySBA2/NU/pOur+yEI5i4jSYARXidssfpTcaGig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720782448; c=relaxed/simple; bh=J5B4V+GxjTUk/uTZIdgig3t7RPhLCkFHCun4ASHiAlk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=blk+Iv6qRIhxGSELub5efZ2ynGyVJHf6+dXXVVI+7RjRb66BmOCKXx/Fn7sA0f9pJtp3eQjJG4DHrDFctjroHea+sm9LZH737GVqiFDXTXCFFZ/lM86UgjIJaTRDy6Z69k+xKmlXrLILWgTK1GhQDCZpbrEGqtE8jEFotlAHrlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tnwFS+fn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tnwFS+fn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27C2BC32782; Fri, 12 Jul 2024 11:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720782448; bh=J5B4V+GxjTUk/uTZIdgig3t7RPhLCkFHCun4ASHiAlk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tnwFS+fnNraQw6n/j+xWTvycP5JpS8ghclHM/iG/fZx4sNZ05NqQo6pFCk0t8KGjj FnEqxNlq18vGbdPl2UpxLhTU+M6Qza5B3MWMlGGM5/UNlCqIwtNj4tDSBn/XyRUzo8 XKqfboBT0h1xCkl6Z/auKnNT5pz8WEA0fu8KTwD9NijCYwcQepAb2836nPUjOi0P2i DlXGwVmSwCZuoUb0kV7IeA7IOMKUFanGXipOU/A4ElTTSfmM9RNKkMfjjV8ycwitPV wg1xtSZ4KifdFQdISyMhxdW/IPBRkIyyKtte6Q+IYjmTBH2AeLInOXUtrF5v4fuWfv fHYrM1rhgIWaA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1sSE7b-000000001aF-1Odx; Fri, 12 Jul 2024 13:07:27 +0200 Date: Fri, 12 Jul 2024 13:07:27 +0200 From: Johan Hovold To: Stephan Gerhold Cc: Sebastian Reichel , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Abel Vesa , Srinivas Kandagatla Subject: Re: [PATCH] power: supply: qcom_battmgr: Ignore extra __le32 in info payload Message-ID: References: <20240712-x1e80100-battmgr-v1-1-a253d767f493@linaro.org> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240712-x1e80100-battmgr-v1-1-a253d767f493@linaro.org> On Fri, Jul 12, 2024 at 12:00:03PM +0200, Stephan Gerhold wrote: > Some newer ADSP firmware versions on X1E80100 report an extra __le32 at the > end of the battery information request payload, causing qcom_battmgr to > fail to initialize. Adjust the check to ignore the extra field in the info > payload so we can support both old and newer firmware versions. > > Tested-by: Srinivas Kandagatla > Signed-off-by: Stephan Gerhold Can confirm that the old fw still works (didn't really look at the patch): Tested-by: Johan Hovold Johan