Re: [PATCH v3] cpupower: add checks for xgettext and msgfmt

["John B. Wyatt IV" <jwyatt@redhat.com>]

On Thu, Oct 17, 2024 at 10:04:29AM -0600, Shuah Khan wrote:
> On 10/17/24 07:32, Siddharth Menon wrote:
> > Check whether xgettext and msgfmt are available on the system before
> > attempting to  generate GNU gettext Language Translations.
> > In case of missing dependency, generate warning message directing user
> > to install the necessary package.
> > 
> > Signed-off-by: Siddharth Menon <simeddon@gmail.com>
> > ---
> >   v1->v2:
> >   - Checks for gettext tools outside the target definitions instead
> >   of inline
> >   - Replace command with which
> >   v2->v3:
> >   - Update commit message
> 
> Looks like there is more than just updating commit log
> in this version. You fixed a problem in your v2. :)
> 
> Also when someone suggests an approach and give you a
> diff, the practice is to add Suggested-by
> 
> John, Do you have time to test this? Asking since you
> tested the previous version. Just want to make sure
> this one works as well.
> 

Yes I do, all 3 messages only appear once when the gettext pkg is not
installed on a Fedora 40 server using the make command. When it is
installed none of the messages show. Works as expected.

Siddharth, assuming no other changes. :) Please include my Tested-by
tags so others know your code was tested in your V4 along with Shuah's
Suggested-by and document the clean up of V3's msgmerge.

Tested-by: John B. Wyatt IV <jwyatt@redhat.com>
Tested-by: John B. Wyatt IV <sageofredondo@gmail.com>

> thanks,
> -- Shuah
> 

-- 
Sincerely,
John Wyatt
Software Engineer, Core Kernel
Red Hat