From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D878C1FF043; Tue, 12 Nov 2024 15:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.95.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731426481; cv=none; b=Yi3Nv+IV0mfSMP4zaBBCjxlnlpflbfZw6uYLC8I907KwmmZS6WAQDmUMlezoKPoS6Wa2VhETB0M45OFgtTD8du+IyTPrHwscoOvwwvDdJTikeKm8sR4SQhhi4lgdXI+2QxEFwzARlmKANMGZi++TPleAaU5dD1lP+0Ycj/X0B9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731426481; c=relaxed/simple; bh=tNvpUgxn+I045QVoUNaZK9haXsjU9vpkV1RQTDKN+2s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KP/S6/WIFaMEXq3ue9Dglgw3k0BA+vASHGEKaXSVjfj6iFj5a7PGuVOMENLvmQzIHSG7RRMtC8c/JWU2VulnejbFTQV/MSU+foPDFziSf/pkhzalroa88Ms6GWcCTo+nSTvc+N0vGDAVMlSLftMDN+rPe644+LC5f9BiNPtyBes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=83.223.95.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id DC22F300102A6; Tue, 12 Nov 2024 16:47:48 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id ABA495F83DD; Tue, 12 Nov 2024 16:47:48 +0100 (CET) Date: Tue, 12 Nov 2024 16:47:48 +0100 From: Lukas Wunner To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof Wilczy??ski , "Maciej W . Rozycki" , Jonathan Cameron , Alexandru Gagniuc , Krishna chaitanya chundru , Srinivas Pandruvada , "Rafael J . Wysocki" , linux-pm@vger.kernel.org, Smita Koralahalli , linux-kernel@vger.kernel.org, Daniel Lezcano , Amit Kucheria , Zhang Rui , Christophe JAILLET Subject: Re: [PATCH v9 7/9] PCI/bwctrl: Add API to set PCIe Link Speed Message-ID: References: <20241018144755.7875-1-ilpo.jarvinen@linux.intel.com> <20241018144755.7875-8-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241018144755.7875-8-ilpo.jarvinen@linux.intel.com> On Fri, Oct 18, 2024 at 05:47:53PM +0300, Ilpo Järvinen wrote: > +EXPORT_SYMBOL_GPL(pcie_set_target_speed); My apologies for another belated comment on this series. This patch is now a688ab21eb72 on pci/bwctrl: I note that pcie_set_target_speed() is not called my a modular user (CONFIG_PCIE_THERMAL is bool, not tristate), so the above-quoted export isn't really necessary right now. I don't know if it was added intentionally because some modular user is expected to show up in the near future. > @@ -135,6 +296,7 @@ static int pcie_bwnotif_probe(struct pcie_device *srv) > if (!data) > return -ENOMEM; > > + devm_mutex_init(&srv->device, &data->set_speed_mutex); > ret = devm_request_threaded_irq(&srv->device, srv->irq, NULL, > pcie_bwnotif_irq_thread, > IRQF_SHARED | IRQF_ONESHOT, We generally try to avoid devm_*() functions in port service drivers because if we later on move them into the PCI core (which is the plan), we'll have to unroll them. Not the end of the world that they're used here, just not ideal. Thanks, Lukas