From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F50F283FCF for ; Mon, 4 May 2026 07:17:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777879065; cv=none; b=gLmF4JKThtpJB/UTnbtN2m4gNkcNQ7U3tSAKTVUCFvzd3O2Ji+/zBlhx+IS2eVilZVBFjBq1m/Xbj5Dz9MpbD69rpQl3bafGQcZatg3Fo0OcKEEiNfGHAto7hUvMWq/5l08+rFZqLl3cEVDuGSrIPGFVyphoJFR2ILakPfsEN3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777879065; c=relaxed/simple; bh=S2ywDK9Z/XmW1DdLWAaR4LWz/VfKoc196yZKCu9VRe8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vCv4GDsPlO1Qqa4rU/EBcT5Im6Cow20a8+nT1ogZpwLAk/rVif9nnMKAalknqXQ/zJQNxvwEFUb+1g4Pd8LN/jeB458nZcRVZ4kg/y6a5YPsv+zezqASpBeO9cEJfBll0DoA9/dEcvRddd3RkYB+C3NcY0iw+rOI9RFONCcMSD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BNqx5rRb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XzcQ02vj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BNqx5rRb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XzcQ02vj" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6446DNqE875835 for ; Mon, 4 May 2026 07:17:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BvsC7vS8QiLKFxVRhuJGpH17bq45h1P4AoYtDVy8ksQ=; b=BNqx5rRb5CIcNCsR CNREwUAaymoTDVT0u8XlDeYGV1R2XAXtW3omxdfQ4gLcHFfzCabL41ziaCJlUbwM krOuToYz4xZtgqy25I1/U6cBrBfgZ06SlImH7hldqxYvOSLgFAcC7S9GCo1xN8Kx UXZJuEPcCfwIv+4QahndXKtMD33k9GF2tsKpivl+/LFzOehQo2Feu6oHu7/VQk2Y gv8sRQ1X7CzVpIVHd7EP3Fd/gRKCgILJX8Bf0yEsa8f2DxoDzK02XKR1PjEpHnyv HQWiZ2qyx/KaPbEDLhOaymJyKA062C1BD5uEbDVojHEE1EN3pkGBBqP7DBsmd19u JDhnhA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dwa1emmpy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 04 May 2026 07:17:43 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-36521936155so1244263a91.3 for ; Mon, 04 May 2026 00:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777879063; x=1778483863; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BvsC7vS8QiLKFxVRhuJGpH17bq45h1P4AoYtDVy8ksQ=; b=XzcQ02vjl8t+OE7AZZ35GNpf9cmA8lRVD2AAUIIpK+y2DQvRH1cL2OqCFIX8GSu0l4 MFmO7eeFLdi4FBsoC9kVeiqsXZJ+kSIixTiXy1sUKFuzG86in7e0jBZif9CKdQNBKLht 3c7ZiLF3BuGPW509Mo5afcPVE+x3lzDk6zyz0cd9nWWfESdm/VghIz6E3S8dJlKm/aHn tk8ZCG7+hvankfexyPqm87UQm5TL9kO0lIQutRs9IX7ajLHNYeJw9v1eDJ351vBzcNWt /pj9YThRLtyqCxAUxIeUrestbZ/Q25coG8qMwvXeKCPpOCcMLtk+TdGMXI72MaDgruTJ MUbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777879063; x=1778483863; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BvsC7vS8QiLKFxVRhuJGpH17bq45h1P4AoYtDVy8ksQ=; b=UN8pORFOpKbIXzuidabV6Rw5EcCcj8YEPIO6+vVzgDcvkbUZfvv4Xnp8eMZ+KItrZN QKnmnx6o5APBd0/86vjdTSYKyXG7dTA7h8eV3zN42aupmqXWCZm0H1JrtbOEXL6pKA1N HvckBtMHiWLtzjebs0AYiBII9TUdQ5ixJyLERMYoKguLwEXiYdxerR68xr0P9FxCmIIO j21qgLiqd5supWuqDawk67jTyKOSiWMbNDk/mgHxEB7SnV7BQqNRe0akI1zvf0J2+PRt bTlrDkJq8B6NeZ7zpSIlQ9P55x3aHK+HrRbT23O6uL5EywfX2+buWOljGKRN6WmUGL6s h6cg== X-Forwarded-Encrypted: i=1; AFNElJ9uDm84EvP0//Iy7MCJAV5Ju0ZHaAJZJEK/jzsoH3oy2h9l6XB/Ni+Wvoh/rrGx5aYxB0n6/9xnBw==@vger.kernel.org X-Gm-Message-State: AOJu0YxPziTJFL87CFnNOJn4g0vgHr96ppEt+x+XJLpvl/60prXna4W/ J08QuD81tqvkMqB/4LPocxmmpx4Ejggpw1IdM3luk4ZlSLaJivYOrCMyAx+wWOcVD5z0Wn+qI/O llEsG848BPDSeh+sBka1bl9olde4NWRY5Il88hxPFj6Slc6uJJdWwYruoDE2N+Q== X-Gm-Gg: AeBDievvvMx/6kzBlrs8uawg+VqXFppbaHU2Ca1ibYWAmPIx62FoOjrA9EHicd2H1NP 4DZOy2i6GIw+LIC3S8ghC1nZ9cfYtMyGF3dC1UvPLefViCSROhyq3YtppiCusifEKnMg3N9jlhW bNxhc0gDNf/NovXUJyZKeEQjOn1+kzi//dwEwMEyItVeoo6J9FVslqZ7fT1QL2FsyB7H6awi1OC aIds/IlsMN1ZMhhI+gnLIEghnrup4riOVtnkIl5kaIOlq4OUrDOLdhQypikUXWT/LXFnFL+YGTg EGB6q7PF3Ts2btD+2xB2jrLEr+WQeaRb0JrB7JkythNunEbKPaYXxU1arpgum3eGwCiamCm/Rg7 W28BmmenscyJDBiOoPhW05I+ogFyp3fLo9v0cmKvWBlSC53eQa5JMdyXKmp0JQlPzHviNBFeC X-Received: by 2002:a17:90b:33ca:b0:35f:b1f3:ac12 with SMTP id 98e67ed59e1d1-3650cd08154mr8172120a91.4.1777879062778; Mon, 04 May 2026 00:17:42 -0700 (PDT) X-Received: by 2002:a17:90b:33ca:b0:35f:b1f3:ac12 with SMTP id 98e67ed59e1d1-3650cd08154mr8172109a91.4.1777879062217; Mon, 04 May 2026 00:17:42 -0700 (PDT) Received: from [10.218.15.248] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364bdf2a71bsm13571815a91.1.2026.05.04.00.17.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 00:17:41 -0700 (PDT) Message-ID: Date: Mon, 4 May 2026 12:47:37 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: interconnect: document the RPM Network-On-Chip interconnect in Shikra SoC To: Krzysztof Kozlowski Cc: Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Odelu Kukatla References: <20260429-shikra_icc-v1-0-e3439903edf1@oss.qualcomm.com> <20260429-shikra_icc-v1-1-e3439903edf1@oss.qualcomm.com> <20260503-enormous-benign-salamander-8d074c@quoll> Content-Language: en-US From: Raviteja Laggyshetty In-Reply-To: <20260503-enormous-benign-salamander-8d074c@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: mQagfOuu--P4FM-5EoODWWrAp0XPSnLN X-Proofpoint-GUID: mQagfOuu--P4FM-5EoODWWrAp0XPSnLN X-Authority-Analysis: v=2.4 cv=e7U2j6p/ c=1 sm=1 tr=0 ts=69f84817 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=yHlWrU9OV0gRyedkY6sA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA0MDA3NSBTYWx0ZWRfX5+evImElfw2I 5FMe6b3FA2emMHEdzIfsNTNf3kQ1wh9SYgwQ6AQXSlX9+yebaCWfr/f7ZJHy3C/iRXVzeeiagSp Qmm4VZHzctEgx8EaAWgTdrgafjJhZ4vBtNqpGyFfpOB2BAkp2wr1/1O03EyQ1CAKoSlBJEBXZ3J KKcQuY5cAg77s99KtMJI2Bo9aFu4rUemJT7AWlrwkZYT/+tb4suDtkV1LCyK4Is7LLjIzFn/ZNE TnIbBgJspOGTjltgtXEj+SGmzTIG44TAgxLAPVuSde1AWs4LvhZIcXE+ZyM5A7yvieH3tFRlxxZ CDvHlB1TzsSpTfOAR4UHR38U7szF0b856GajPjKpbQR88724k/PVQGfPc+eAvMMaSn3+f6m1Je9 8bBUaBTWW+m5kXjMVPX6gvcS3qX0sAMehbWK+LEdUsh0Sni5jtyZjhzfVDu6VxkVl+bVmhd66Us wYl1z7LIWITtzOds45g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_02,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605040075 On 5/3/2026 9:47 PM, Krzysztof Kozlowski wrote: > On Wed, Apr 29, 2026 at 02:03:48PM +0000, Raviteja Laggyshetty wrote: >> +++ b/Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml >> @@ -0,0 +1,135 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/interconnect/qcom,shikra.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Shikra Network-On-Chip interconnect >> + >> +maintainers: >> + - Raviteja Laggyshetty >> + >> +description: | > > Do not need '|' unless you need to preserve formatting. I will fix it next revision. > >> + The Qualcomm Shikra interconnect providers support adjusting the >> + bandwidth requirements between the various NoC fabrics. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,shikra-config-noc >> + - qcom,shikra-mem-noc-core >> + - qcom,shikra-sys-noc >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + minItems: 1 >> + maxItems: 4 >> + >> + clock-names: >> + minItems: 1 >> + maxItems: 4 >> + >> +# Child node's properties >> +patternProperties: >> + '^interconnect-[a-z0-9]+$': >> + type: object >> + description: >> + The interconnect providers do not have a separate QoS register space, >> + but share parent's space. >> + >> + $ref: qcom,rpm-common.yaml# >> + >> + properties: >> + compatible: >> + enum: >> + - qcom,shikra-clk-virt >> + - qcom,shikra-mc-virt >> + - qcom,shikra-mmrt-virt >> + - qcom,shikra-mmnrt-virt >> + >> + required: >> + - compatible >> + >> + unevaluatedProperties: false >> + >> +required: >> + - compatible >> + - reg >> + >> +allOf: >> + - $ref: qcom,rpm-common.yaml# >> + - if: >> + properties: >> + compatible: >> + const: qcom,shikra-mem-noc-core >> + >> + then: >> + properties: >> + clocks: >> + items: >> + - description: GPU-NoC AXI clock >> + >> + clock-names: >> + items: >> + - const: gpu_axi >> + >> + - if: >> + properties: >> + compatible: >> + const: qcom,shikra-sys-noc >> + >> + then: >> + properties: >> + clocks: >> + items: >> + - description: EMAC0-NoC AXI clock. >> + - description: EMAC1-NoC AXI clock. >> + - description: USB2-NoC AXI clock. >> + - description: USB3-NoC AXI clock. >> + >> + clock-names: >> + items: >> + - const: emac0_axi >> + - const: emac1_axi >> + - const: usb2_axi >> + - const: usb3_axi >> + >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,shikra-clk-virt >> + - qcom,shikra-config-noc >> + - qcom,shikra-mc-virt >> + - qcom,shikra-mmrt-virt >> + - qcom,shikra-mmnrt-virt > > This if is pointless here, changes nothing and not really correct. Drop > it, I will fix existing bindings. > > OTOH, do all NoCs have children? If not, the patternProperties should be > disallowed for such cases. Also clocks should be restricted, see my > patch: > 20260503161653.60785-4-krzysztof.kozlowski@oss.qualcomm.com > Only system_noc has children, rest of the NoCs don't. I will update the bindings to 1. disallow the patternProperties for the NoCs which don't have children. 2. drop the redundant clock property check for child NoCs at top-level allOf:if:then:properties:. Thanks, Raviteja > Best regards, > Krzysztof >