Trip points crossed not detected when no cooling device bound

Daniel Lezcano
2024-06-26T06:50:49Z

Hi,

after experimenting different setup I noticed there is no longer trip
crossed notifications sent to the userspace when there is no cooling
device bound to a thermal zone.

git bisecting leads me to this commit:

202aa0d4bb532338cd27bcc64c60abc2987a2be7 is the first bad commit
commit 202aa0d4bb532338cd27bcc64c60abc2987a2be7
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date: Tue Apr 30 17:45:55 2024 +0200

thermal: core: Do not call handle_thermal_trip() if zone
temperature is invalid

Make __thermal_zone_device_update() bail out if update_temperature()
fails to update the zone temperature because __thermal_zone_get_temp()
has returned an error and the current zone temperature is
THERMAL_TEMP_INVALID (user space receiving netlink thermal messages,
thermal debug code and thermal governors may get confused otherwise).

Fixes: 9ad18043fb35 ("thermal: core: Send trip crossing
notifications at init time if needed")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Tested-by: Lukasz Luba <lukasz.luba@arm.com>

drivers/thermal/thermal_core.c | 3 +++
1 file changed, 3 insertions(+)