Re: Trip points crossed not detected when no cooling device bound

Daniel Lezcano
2024-06-26T21:21:54Z

On 26/06/2024 12:38, Rafael J. Wysocki wrote:
> Hi,
>
> On Wed, Jun 26, 2024 at 8:50 AM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>>
>> Hi,
>>
>> after experimenting different setup I noticed there is no longer trip
>> crossed notifications sent to the userspace when there is no cooling
>> device bound to a thermal zone.
>
> I think I've seen those coming for zones without any cooling devices,
> so it seems related to the setup.
>
>> git bisecting leads me to this commit:
>>
>>
>> 202aa0d4bb532338cd27bcc64c60abc2987a2be7 is the first bad commit
>> commit 202aa0d4bb532338cd27bcc64c60abc2987a2be7
>> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Date: Tue Apr 30 17:45:55 2024 +0200
>>
>> thermal: core: Do not call handle_thermal_trip() if zone
>> temperature is invalid
>>
>> Make __thermal_zone_device_update() bail out if update_temperature()
>> fails to update the zone temperature because __thermal_zone_get_temp()
>> has returned an error and the current zone temperature is
>> THERMAL_TEMP_INVALID (user space receiving netlink thermal messages,
>> thermal debug code and thermal governors may get confused otherwise).
>>
>> Fixes: 9ad18043fb35 ("thermal: core: Send trip crossing
>> notifications at init time if needed")
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
>> Tested-by: Lukasz Luba <lukasz.luba@arm.com>
>>
>> drivers/thermal/thermal_core.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> -
>
> Oh, I see where the problem can be. If the zone is polling only, it
> will not rearm the timer when the current zone temperature is invalid
> after the above commit, so does the attached patch help?

At this point, I went far when bisecting another problem and I ended up
screwing my config file. So I had to generate a new one from the default
config. Since then the issue is no longer happening which sounds very
strange to me.

I'm still investigating but if you have a suggestion coming in mind, it
would be welcome because I'm failing to find out what is going on ... :/