* [PATCH v2] cpupower: Fix no-rounding MHz frequency output @ 2017-10-25 13:51 Prarit Bhargava 2017-10-25 22:01 ` Stafford Horne 2017-11-01 21:00 ` Shuah Khan 0 siblings, 2 replies; 17+ messages in thread From: Prarit Bhargava @ 2017-10-25 13:51 UTC (permalink / raw) To: linux-pm; +Cc: Prarit Bhargava, Thomas Renninger, Stafford Horne, Shuah Khan 'cpupower frequency-info -ln' returns kHz values on systems with MHz range minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system the command returns hardware limits: 800000 MHz - 4.200000 GHz The code that causes this error can be removed. The next else if clause will handle the output correctly such that hardware limits: 800.000 MHz - 4.200000 GHz is displayed correctly. [v2]: Remove two lines instead of fixing broken code. Signed-off-by: Prarit Bhargava <prarit@redhat.com> Cc: Thomas Renninger <trenn@suse.com> Cc: Stafford Horne <shorne@gmail.com> Cc: Shuah Khan <shuah@kernel.org> --- tools/power/cpupower/utils/cpufreq-info.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c index 3e701f0e9c14..df43cd45d810 100644 --- a/tools/power/cpupower/utils/cpufreq-info.c +++ b/tools/power/cpupower/utils/cpufreq-info.c @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) if (speed > 1000000) printf("%u.%06u GHz", ((unsigned int) speed/1000000), ((unsigned int) speed%1000000)); - else if (speed > 100000) - printf("%u MHz", (unsigned int) speed); else if (speed > 1000) printf("%u.%03u MHz", ((unsigned int) speed/1000), (unsigned int) (speed%1000)); -- 2.15.0.rc0.39.g2f0e14e64 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-10-25 13:51 [PATCH v2] cpupower: Fix no-rounding MHz frequency output Prarit Bhargava @ 2017-10-25 22:01 ` Stafford Horne 2017-11-01 21:01 ` Shuah Khan 2017-11-01 21:00 ` Shuah Khan 1 sibling, 1 reply; 17+ messages in thread From: Stafford Horne @ 2017-10-25 22:01 UTC (permalink / raw) To: Prarit Bhargava; +Cc: linux-pm, Thomas Renninger, Shuah Khan On Wed, Oct 25, 2017 at 09:51:32AM -0400, Prarit Bhargava wrote: > 'cpupower frequency-info -ln' returns kHz values on systems with MHz range > minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system > the command returns > > hardware limits: 800000 MHz - 4.200000 GHz > > The code that causes this error can be removed. The next else if clause > will handle the output correctly such that > > hardware limits: 800.000 MHz - 4.200000 GHz > > is displayed correctly. > > [v2]: Remove two lines instead of fixing broken code. > > Signed-off-by: Prarit Bhargava <prarit@redhat.com> > Cc: Thomas Renninger <trenn@suse.com> > Cc: Stafford Horne <shorne@gmail.com> > Cc: Shuah Khan <shuah@kernel.org> Reviewed-by: Stafford Horne <shorne@gmail.com> > --- > tools/power/cpupower/utils/cpufreq-info.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c > index 3e701f0e9c14..df43cd45d810 100644 > --- a/tools/power/cpupower/utils/cpufreq-info.c > +++ b/tools/power/cpupower/utils/cpufreq-info.c > @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) > if (speed > 1000000) > printf("%u.%06u GHz", ((unsigned int) speed/1000000), > ((unsigned int) speed%1000000)); > - else if (speed > 100000) > - printf("%u MHz", (unsigned int) speed); > else if (speed > 1000) > printf("%u.%03u MHz", ((unsigned int) speed/1000), > (unsigned int) (speed%1000)); > -- > 2.15.0.rc0.39.g2f0e14e64 > ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-10-25 22:01 ` Stafford Horne @ 2017-11-01 21:01 ` Shuah Khan 0 siblings, 0 replies; 17+ messages in thread From: Shuah Khan @ 2017-11-01 21:01 UTC (permalink / raw) To: Stafford Horne, Prarit Bhargava Cc: linux-pm, Thomas Renninger, Shuah Khan, Shuah Khan On 10/25/2017 04:01 PM, Stafford Horne wrote: > On Wed, Oct 25, 2017 at 09:51:32AM -0400, Prarit Bhargava wrote: >> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >> the command returns >> >> hardware limits: 800000 MHz - 4.200000 GHz >> >> The code that causes this error can be removed. The next else if clause >> will handle the output correctly such that >> >> hardware limits: 800.000 MHz - 4.200000 GHz >> >> is displayed correctly. >> >> [v2]: Remove two lines instead of fixing broken code. >> >> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >> Cc: Thomas Renninger <trenn@suse.com> >> Cc: Stafford Horne <shorne@gmail.com> >> Cc: Shuah Khan <shuah@kernel.org> > > Reviewed-by: Stafford Horne <shorne@gmail.com> Thanks for the review. -- Shuah > >> --- >> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >> index 3e701f0e9c14..df43cd45d810 100644 >> --- a/tools/power/cpupower/utils/cpufreq-info.c >> +++ b/tools/power/cpupower/utils/cpufreq-info.c >> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >> if (speed > 1000000) >> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >> ((unsigned int) speed%1000000)); >> - else if (speed > 100000) >> - printf("%u MHz", (unsigned int) speed); >> else if (speed > 1000) >> printf("%u.%03u MHz", ((unsigned int) speed/1000), >> (unsigned int) (speed%1000)); >> -- >> 2.15.0.rc0.39.g2f0e14e64 >> > > ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-10-25 13:51 [PATCH v2] cpupower: Fix no-rounding MHz frequency output Prarit Bhargava 2017-10-25 22:01 ` Stafford Horne @ 2017-11-01 21:00 ` Shuah Khan 2017-11-01 21:33 ` Rafael J. Wysocki 1 sibling, 1 reply; 17+ messages in thread From: Shuah Khan @ 2017-11-01 21:00 UTC (permalink / raw) To: Prarit Bhargava, linux-pm Cc: Thomas Renninger, Stafford Horne, Shuah Khan, Shuah Khan On 10/25/2017 07:51 AM, Prarit Bhargava wrote: > 'cpupower frequency-info -ln' returns kHz values on systems with MHz range > minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system > the command returns > > hardware limits: 800000 MHz - 4.200000 GHz > > The code that causes this error can be removed. The next else if clause > will handle the output correctly such that > > hardware limits: 800.000 MHz - 4.200000 GHz > > is displayed correctly. > > [v2]: Remove two lines instead of fixing broken code. > > Signed-off-by: Prarit Bhargava <prarit@redhat.com> > Cc: Thomas Renninger <trenn@suse.com> > Cc: Stafford Horne <shorne@gmail.com> > Cc: Shuah Khan <shuah@kernel.org> > --- > tools/power/cpupower/utils/cpufreq-info.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c > index 3e701f0e9c14..df43cd45d810 100644 > --- a/tools/power/cpupower/utils/cpufreq-info.c > +++ b/tools/power/cpupower/utils/cpufreq-info.c > @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) > if (speed > 1000000) > printf("%u.%06u GHz", ((unsigned int) speed/1000000), > ((unsigned int) speed%1000000)); > - else if (speed > 100000) > - printf("%u MHz", (unsigned int) speed); > else if (speed > 1000) > printf("%u.%03u MHz", ((unsigned int) speed/1000), > (unsigned int) (speed%1000)); > Thanks. I will queue this up for 4.15-rc1. -- Shuah ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-01 21:00 ` Shuah Khan @ 2017-11-01 21:33 ` Rafael J. Wysocki 2017-11-01 21:38 ` Shuah Khan 0 siblings, 1 reply; 17+ messages in thread From: Rafael J. Wysocki @ 2017-11-01 21:33 UTC (permalink / raw) To: Shuah Khan Cc: Prarit Bhargava, Linux PM, Thomas Renninger, Stafford Horne, Shuah Khan On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote: > On 10/25/2017 07:51 AM, Prarit Bhargava wrote: >> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >> the command returns >> >> hardware limits: 800000 MHz - 4.200000 GHz >> >> The code that causes this error can be removed. The next else if clause >> will handle the output correctly such that >> >> hardware limits: 800.000 MHz - 4.200000 GHz >> >> is displayed correctly. >> >> [v2]: Remove two lines instead of fixing broken code. >> >> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >> Cc: Thomas Renninger <trenn@suse.com> >> Cc: Stafford Horne <shorne@gmail.com> >> Cc: Shuah Khan <shuah@kernel.org> >> --- >> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >> index 3e701f0e9c14..df43cd45d810 100644 >> --- a/tools/power/cpupower/utils/cpufreq-info.c >> +++ b/tools/power/cpupower/utils/cpufreq-info.c >> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >> if (speed > 1000000) >> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >> ((unsigned int) speed%1000000)); >> - else if (speed > 100000) >> - printf("%u MHz", (unsigned int) speed); >> else if (speed > 1000) >> printf("%u.%03u MHz", ((unsigned int) speed/1000), >> (unsigned int) (speed%1000)); >> > > Thanks. I will queue this up for 4.15-rc1. OK So are you going to maintain this utility going forward? Thanks, Rafael ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-01 21:33 ` Rafael J. Wysocki @ 2017-11-01 21:38 ` Shuah Khan 2017-11-01 21:46 ` Rafael J. Wysocki 0 siblings, 1 reply; 17+ messages in thread From: Shuah Khan @ 2017-11-01 21:38 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Prarit Bhargava, Linux PM, Thomas Renninger, Stafford Horne, Shuah Khan, Shuah Khan On 11/01/2017 03:33 PM, Rafael J. Wysocki wrote: > On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote: >> On 10/25/2017 07:51 AM, Prarit Bhargava wrote: >>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >>> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >>> the command returns >>> >>> hardware limits: 800000 MHz - 4.200000 GHz >>> >>> The code that causes this error can be removed. The next else if clause >>> will handle the output correctly such that >>> >>> hardware limits: 800.000 MHz - 4.200000 GHz >>> >>> is displayed correctly. >>> >>> [v2]: Remove two lines instead of fixing broken code. >>> >>> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >>> Cc: Thomas Renninger <trenn@suse.com> >>> Cc: Stafford Horne <shorne@gmail.com> >>> Cc: Shuah Khan <shuah@kernel.org> >>> --- >>> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >>> index 3e701f0e9c14..df43cd45d810 100644 >>> --- a/tools/power/cpupower/utils/cpufreq-info.c >>> +++ b/tools/power/cpupower/utils/cpufreq-info.c >>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >>> if (speed > 1000000) >>> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >>> ((unsigned int) speed%1000000)); >>> - else if (speed > 100000) >>> - printf("%u MHz", (unsigned int) speed); >>> else if (speed > 1000) >>> printf("%u.%03u MHz", ((unsigned int) speed/1000), >>> (unsigned int) (speed%1000)); >>> >> >> Thanks. I will queue this up for 4.15-rc1. > > OK > > So are you going to maintain this utility going forward? > oops. I was on auto-pilot responding to patches sitting in my Inbox. Wrong email response. Sorry about that. Please ignore. Mu bad. thanks, -- Shuah ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-01 21:38 ` Shuah Khan @ 2017-11-01 21:46 ` Rafael J. Wysocki 2017-11-01 21:49 ` Shuah Khan 0 siblings, 1 reply; 17+ messages in thread From: Rafael J. Wysocki @ 2017-11-01 21:46 UTC (permalink / raw) To: Shuah Khan, Prarit Bhargava, Stafford Horne Cc: Rafael J. Wysocki, Shuah Khan, Linux PM, Thomas Renninger On Wed, Nov 1, 2017 at 10:38 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: > On 11/01/2017 03:33 PM, Rafael J. Wysocki wrote: >> On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote: >>> On 10/25/2017 07:51 AM, Prarit Bhargava wrote: >>>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >>>> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >>>> the command returns >>>> >>>> hardware limits: 800000 MHz - 4.200000 GHz >>>> >>>> The code that causes this error can be removed. The next else if clause >>>> will handle the output correctly such that >>>> >>>> hardware limits: 800.000 MHz - 4.200000 GHz >>>> >>>> is displayed correctly. >>>> >>>> [v2]: Remove two lines instead of fixing broken code. >>>> >>>> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >>>> Cc: Thomas Renninger <trenn@suse.com> >>>> Cc: Stafford Horne <shorne@gmail.com> >>>> Cc: Shuah Khan <shuah@kernel.org> >>>> --- >>>> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >>>> 1 file changed, 2 deletions(-) >>>> >>>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >>>> index 3e701f0e9c14..df43cd45d810 100644 >>>> --- a/tools/power/cpupower/utils/cpufreq-info.c >>>> +++ b/tools/power/cpupower/utils/cpufreq-info.c >>>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >>>> if (speed > 1000000) >>>> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >>>> ((unsigned int) speed%1000000)); >>>> - else if (speed > 100000) >>>> - printf("%u MHz", (unsigned int) speed); >>>> else if (speed > 1000) >>>> printf("%u.%03u MHz", ((unsigned int) speed/1000), >>>> (unsigned int) (speed%1000)); >>>> >>> >>> Thanks. I will queue this up for 4.15-rc1. >> >> OK >> >> So are you going to maintain this utility going forward? >> > > oops. I was on auto-pilot responding to patches sitting in my Inbox. > Wrong email response. Sorry about that. > > Please ignore. Mu bad. OK :-) But that said, from my perspective, cpupower is basically not maintained. Thomas, who sort of maintained it, but then basically became a patch reviewer for it, does not respond to patches any more and I am not sufficiently familiar with the code to be able to effectively review the patches myself, nor I have the time to get more familiar with it. For this reason, I'm inclined to drop this code from the kernel source tree unless somebody steps in to fill the gap. Thanks, Rafael ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-01 21:46 ` Rafael J. Wysocki @ 2017-11-01 21:49 ` Shuah Khan 2017-11-01 22:07 ` Rafael J. Wysocki 0 siblings, 1 reply; 17+ messages in thread From: Shuah Khan @ 2017-11-01 21:49 UTC (permalink / raw) To: Rafael J. Wysocki, Prarit Bhargava, Stafford Horne Cc: Shuah Khan, Linux PM, Thomas Renninger, Shuah Khan On 11/01/2017 03:46 PM, Rafael J. Wysocki wrote: > On Wed, Nov 1, 2017 at 10:38 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >> On 11/01/2017 03:33 PM, Rafael J. Wysocki wrote: >>> On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote: >>>> On 10/25/2017 07:51 AM, Prarit Bhargava wrote: >>>>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >>>>> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >>>>> the command returns >>>>> >>>>> hardware limits: 800000 MHz - 4.200000 GHz >>>>> >>>>> The code that causes this error can be removed. The next else if clause >>>>> will handle the output correctly such that >>>>> >>>>> hardware limits: 800.000 MHz - 4.200000 GHz >>>>> >>>>> is displayed correctly. >>>>> >>>>> [v2]: Remove two lines instead of fixing broken code. >>>>> >>>>> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >>>>> Cc: Thomas Renninger <trenn@suse.com> >>>>> Cc: Stafford Horne <shorne@gmail.com> >>>>> Cc: Shuah Khan <shuah@kernel.org> >>>>> --- >>>>> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >>>>> 1 file changed, 2 deletions(-) >>>>> >>>>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >>>>> index 3e701f0e9c14..df43cd45d810 100644 >>>>> --- a/tools/power/cpupower/utils/cpufreq-info.c >>>>> +++ b/tools/power/cpupower/utils/cpufreq-info.c >>>>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >>>>> if (speed > 1000000) >>>>> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >>>>> ((unsigned int) speed%1000000)); >>>>> - else if (speed > 100000) >>>>> - printf("%u MHz", (unsigned int) speed); >>>>> else if (speed > 1000) >>>>> printf("%u.%03u MHz", ((unsigned int) speed/1000), >>>>> (unsigned int) (speed%1000)); >>>>> >>>> >>>> Thanks. I will queue this up for 4.15-rc1. >>> >>> OK >>> >>> So are you going to maintain this utility going forward? >>> >> >> oops. I was on auto-pilot responding to patches sitting in my Inbox. >> Wrong email response. Sorry about that. >> >> Please ignore. Mu bad. > > OK :-) > > But that said, from my perspective, cpupower is basically not maintained. > > Thomas, who sort of maintained it, but then basically became a patch > reviewer for it, does not respond to patches any more and I am not > sufficiently familiar with the code to be able to effectively review > the patches myself, nor I have the time to get more familiar with it. > > For this reason, I'm inclined to drop this code from the kernel source > tree unless somebody steps in to fill the gap. > Please don't drop this from kernel sources.. I think this is useful. If you are looking for a maintainer, I will be happy to step up to maintain it. thanks, -- Shuah ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-01 21:49 ` Shuah Khan @ 2017-11-01 22:07 ` Rafael J. Wysocki 2017-11-01 22:30 ` Shuah Khan 0 siblings, 1 reply; 17+ messages in thread From: Rafael J. Wysocki @ 2017-11-01 22:07 UTC (permalink / raw) To: Shuah Khan Cc: Rafael J. Wysocki, Prarit Bhargava, Stafford Horne, Shuah Khan, Linux PM, Thomas Renninger On Wed, Nov 1, 2017 at 10:49 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: > On 11/01/2017 03:46 PM, Rafael J. Wysocki wrote: >> On Wed, Nov 1, 2017 at 10:38 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>> On 11/01/2017 03:33 PM, Rafael J. Wysocki wrote: >>>> On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote: >>>>> On 10/25/2017 07:51 AM, Prarit Bhargava wrote: >>>>>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >>>>>> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >>>>>> the command returns >>>>>> >>>>>> hardware limits: 800000 MHz - 4.200000 GHz >>>>>> >>>>>> The code that causes this error can be removed. The next else if clause >>>>>> will handle the output correctly such that >>>>>> >>>>>> hardware limits: 800.000 MHz - 4.200000 GHz >>>>>> >>>>>> is displayed correctly. >>>>>> >>>>>> [v2]: Remove two lines instead of fixing broken code. >>>>>> >>>>>> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >>>>>> Cc: Thomas Renninger <trenn@suse.com> >>>>>> Cc: Stafford Horne <shorne@gmail.com> >>>>>> Cc: Shuah Khan <shuah@kernel.org> >>>>>> --- >>>>>> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >>>>>> 1 file changed, 2 deletions(-) >>>>>> >>>>>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >>>>>> index 3e701f0e9c14..df43cd45d810 100644 >>>>>> --- a/tools/power/cpupower/utils/cpufreq-info.c >>>>>> +++ b/tools/power/cpupower/utils/cpufreq-info.c >>>>>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >>>>>> if (speed > 1000000) >>>>>> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >>>>>> ((unsigned int) speed%1000000)); >>>>>> - else if (speed > 100000) >>>>>> - printf("%u MHz", (unsigned int) speed); >>>>>> else if (speed > 1000) >>>>>> printf("%u.%03u MHz", ((unsigned int) speed/1000), >>>>>> (unsigned int) (speed%1000)); >>>>>> >>>>> >>>>> Thanks. I will queue this up for 4.15-rc1. >>>> >>>> OK >>>> >>>> So are you going to maintain this utility going forward? >>>> >>> >>> oops. I was on auto-pilot responding to patches sitting in my Inbox. >>> Wrong email response. Sorry about that. >>> >>> Please ignore. Mu bad. >> >> OK :-) >> >> But that said, from my perspective, cpupower is basically not maintained. >> >> Thomas, who sort of maintained it, but then basically became a patch >> reviewer for it, does not respond to patches any more and I am not >> sufficiently familiar with the code to be able to effectively review >> the patches myself, nor I have the time to get more familiar with it. >> >> For this reason, I'm inclined to drop this code from the kernel source >> tree unless somebody steps in to fill the gap. >> > > Please don't drop this from kernel sources.. I think this is useful. If you > are looking for a maintainer, I will be happy to step up to maintain it. Cool, please do that then. :-) I will be happy to take pull requests with cpupower changes so that they go in along with the other PM material. Thanks, Rafael ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-01 22:07 ` Rafael J. Wysocki @ 2017-11-01 22:30 ` Shuah Khan 2017-11-01 22:34 ` Rafael J. Wysocki 2017-11-02 0:42 ` Prarit Bhargava 0 siblings, 2 replies; 17+ messages in thread From: Shuah Khan @ 2017-11-01 22:30 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Prarit Bhargava, Stafford Horne, Shuah Khan, Linux PM, Thomas Renninger On 11/01/2017 04:07 PM, Rafael J. Wysocki wrote: > On Wed, Nov 1, 2017 at 10:49 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >> On 11/01/2017 03:46 PM, Rafael J. Wysocki wrote: >>> On Wed, Nov 1, 2017 at 10:38 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>>> On 11/01/2017 03:33 PM, Rafael J. Wysocki wrote: >>>>> On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote: >>>>>> On 10/25/2017 07:51 AM, Prarit Bhargava wrote: >>>>>>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >>>>>>> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >>>>>>> the command returns >>>>>>> >>>>>>> hardware limits: 800000 MHz - 4.200000 GHz >>>>>>> >>>>>>> The code that causes this error can be removed. The next else if clause >>>>>>> will handle the output correctly such that >>>>>>> >>>>>>> hardware limits: 800.000 MHz - 4.200000 GHz >>>>>>> >>>>>>> is displayed correctly. >>>>>>> >>>>>>> [v2]: Remove two lines instead of fixing broken code. >>>>>>> >>>>>>> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >>>>>>> Cc: Thomas Renninger <trenn@suse.com> >>>>>>> Cc: Stafford Horne <shorne@gmail.com> >>>>>>> Cc: Shuah Khan <shuah@kernel.org> >>>>>>> --- >>>>>>> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >>>>>>> 1 file changed, 2 deletions(-) >>>>>>> >>>>>>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>> index 3e701f0e9c14..df43cd45d810 100644 >>>>>>> --- a/tools/power/cpupower/utils/cpufreq-info.c >>>>>>> +++ b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >>>>>>> if (speed > 1000000) >>>>>>> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >>>>>>> ((unsigned int) speed%1000000)); >>>>>>> - else if (speed > 100000) >>>>>>> - printf("%u MHz", (unsigned int) speed); >>>>>>> else if (speed > 1000) >>>>>>> printf("%u.%03u MHz", ((unsigned int) speed/1000), >>>>>>> (unsigned int) (speed%1000)); >>>>>>> >>>>>> >>>>>> Thanks. I will queue this up for 4.15-rc1. >>>>> >>>>> OK >>>>> >>>>> So are you going to maintain this utility going forward? >>>>> >>>> >>>> oops. I was on auto-pilot responding to patches sitting in my Inbox. >>>> Wrong email response. Sorry about that. >>>> >>>> Please ignore. Mu bad. >>> >>> OK :-) >>> >>> But that said, from my perspective, cpupower is basically not maintained. >>> >>> Thomas, who sort of maintained it, but then basically became a patch >>> reviewer for it, does not respond to patches any more and I am not >>> sufficiently familiar with the code to be able to effectively review >>> the patches myself, nor I have the time to get more familiar with it. >>> >>> For this reason, I'm inclined to drop this code from the kernel source >>> tree unless somebody steps in to fill the gap. >>> >> >> Please don't drop this from kernel sources.. I think this is useful. If you >> are looking for a maintainer, I will be happy to step up to maintain it. > > Cool, please do that then. :-) > > I will be happy to take pull requests with cpupower changes so that > they go in along with the other PM material. > Sounds like a plan. I can do that. I will work on getting git setup and send pull requests. We can get that going for 4.15 unless you think it is late for you to get pull requests. thanks, -- Shuah ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-01 22:30 ` Shuah Khan @ 2017-11-01 22:34 ` Rafael J. Wysocki 2017-11-02 0:42 ` Prarit Bhargava 1 sibling, 0 replies; 17+ messages in thread From: Rafael J. Wysocki @ 2017-11-01 22:34 UTC (permalink / raw) To: Shuah Khan Cc: Rafael J. Wysocki, Prarit Bhargava, Stafford Horne, Shuah Khan, Linux PM, Thomas Renninger On Wed, Nov 1, 2017 at 11:30 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: > On 11/01/2017 04:07 PM, Rafael J. Wysocki wrote: >> On Wed, Nov 1, 2017 at 10:49 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>> On 11/01/2017 03:46 PM, Rafael J. Wysocki wrote: >>>> On Wed, Nov 1, 2017 at 10:38 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>>>> On 11/01/2017 03:33 PM, Rafael J. Wysocki wrote: >>>>>> On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote: >>>>>>> On 10/25/2017 07:51 AM, Prarit Bhargava wrote: >>>>>>>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >>>>>>>> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >>>>>>>> the command returns >>>>>>>> >>>>>>>> hardware limits: 800000 MHz - 4.200000 GHz >>>>>>>> >>>>>>>> The code that causes this error can be removed. The next else if clause >>>>>>>> will handle the output correctly such that >>>>>>>> >>>>>>>> hardware limits: 800.000 MHz - 4.200000 GHz >>>>>>>> >>>>>>>> is displayed correctly. >>>>>>>> >>>>>>>> [v2]: Remove two lines instead of fixing broken code. >>>>>>>> >>>>>>>> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >>>>>>>> Cc: Thomas Renninger <trenn@suse.com> >>>>>>>> Cc: Stafford Horne <shorne@gmail.com> >>>>>>>> Cc: Shuah Khan <shuah@kernel.org> >>>>>>>> --- >>>>>>>> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >>>>>>>> 1 file changed, 2 deletions(-) >>>>>>>> >>>>>>>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>> index 3e701f0e9c14..df43cd45d810 100644 >>>>>>>> --- a/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>> +++ b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >>>>>>>> if (speed > 1000000) >>>>>>>> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >>>>>>>> ((unsigned int) speed%1000000)); >>>>>>>> - else if (speed > 100000) >>>>>>>> - printf("%u MHz", (unsigned int) speed); >>>>>>>> else if (speed > 1000) >>>>>>>> printf("%u.%03u MHz", ((unsigned int) speed/1000), >>>>>>>> (unsigned int) (speed%1000)); >>>>>>>> >>>>>>> >>>>>>> Thanks. I will queue this up for 4.15-rc1. >>>>>> >>>>>> OK >>>>>> >>>>>> So are you going to maintain this utility going forward? >>>>>> >>>>> >>>>> oops. I was on auto-pilot responding to patches sitting in my Inbox. >>>>> Wrong email response. Sorry about that. >>>>> >>>>> Please ignore. Mu bad. >>>> >>>> OK :-) >>>> >>>> But that said, from my perspective, cpupower is basically not maintained. >>>> >>>> Thomas, who sort of maintained it, but then basically became a patch >>>> reviewer for it, does not respond to patches any more and I am not >>>> sufficiently familiar with the code to be able to effectively review >>>> the patches myself, nor I have the time to get more familiar with it. >>>> >>>> For this reason, I'm inclined to drop this code from the kernel source >>>> tree unless somebody steps in to fill the gap. >>>> >>> >>> Please don't drop this from kernel sources.. I think this is useful. If you >>> are looking for a maintainer, I will be happy to step up to maintain it. >> >> Cool, please do that then. :-) >> >> I will be happy to take pull requests with cpupower changes so that >> they go in along with the other PM material. >> > > Sounds like a plan. I can do that. I will work on getting git setup and > send pull requests. We can get that going for 4.15 unless you think it is > late for you to get pull requests. That should be fine. There still is a couple of days at least before the merge window. :-) ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-01 22:30 ` Shuah Khan 2017-11-01 22:34 ` Rafael J. Wysocki @ 2017-11-02 0:42 ` Prarit Bhargava 2017-11-02 18:59 ` Shuah Khan 1 sibling, 1 reply; 17+ messages in thread From: Prarit Bhargava @ 2017-11-02 0:42 UTC (permalink / raw) To: Shuah Khan, Rafael J. Wysocki Cc: Stafford Horne, Shuah Khan, Linux PM, Thomas Renninger On 11/01/2017 06:30 PM, Shuah Khan wrote: > On 11/01/2017 04:07 PM, Rafael J. Wysocki wrote: >> On Wed, Nov 1, 2017 at 10:49 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>> On 11/01/2017 03:46 PM, Rafael J. Wysocki wrote: >>>> On Wed, Nov 1, 2017 at 10:38 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>>>> On 11/01/2017 03:33 PM, Rafael J. Wysocki wrote: >>>>>> On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote: >>>>>>> On 10/25/2017 07:51 AM, Prarit Bhargava wrote: >>>>>>>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >>>>>>>> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >>>>>>>> the command returns >>>>>>>> >>>>>>>> hardware limits: 800000 MHz - 4.200000 GHz >>>>>>>> >>>>>>>> The code that causes this error can be removed. The next else if clause >>>>>>>> will handle the output correctly such that >>>>>>>> >>>>>>>> hardware limits: 800.000 MHz - 4.200000 GHz >>>>>>>> >>>>>>>> is displayed correctly. >>>>>>>> >>>>>>>> [v2]: Remove two lines instead of fixing broken code. >>>>>>>> >>>>>>>> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >>>>>>>> Cc: Thomas Renninger <trenn@suse.com> >>>>>>>> Cc: Stafford Horne <shorne@gmail.com> >>>>>>>> Cc: Shuah Khan <shuah@kernel.org> >>>>>>>> --- >>>>>>>> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >>>>>>>> 1 file changed, 2 deletions(-) >>>>>>>> >>>>>>>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>> index 3e701f0e9c14..df43cd45d810 100644 >>>>>>>> --- a/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>> +++ b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >>>>>>>> if (speed > 1000000) >>>>>>>> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >>>>>>>> ((unsigned int) speed%1000000)); >>>>>>>> - else if (speed > 100000) >>>>>>>> - printf("%u MHz", (unsigned int) speed); >>>>>>>> else if (speed > 1000) >>>>>>>> printf("%u.%03u MHz", ((unsigned int) speed/1000), >>>>>>>> (unsigned int) (speed%1000)); >>>>>>>> >>>>>>> >>>>>>> Thanks. I will queue this up for 4.15-rc1. >>>>>> >>>>>> OK >>>>>> >>>>>> So are you going to maintain this utility going forward? >>>>>> >>>>> >>>>> oops. I was on auto-pilot responding to patches sitting in my Inbox. >>>>> Wrong email response. Sorry about that. >>>>> >>>>> Please ignore. Mu bad. >>>> >>>> OK :-) >>>> >>>> But that said, from my perspective, cpupower is basically not maintained. >>>> >>>> Thomas, who sort of maintained it, but then basically became a patch >>>> reviewer for it, does not respond to patches any more and I am not >>>> sufficiently familiar with the code to be able to effectively review >>>> the patches myself, nor I have the time to get more familiar with it. >>>> >>>> For this reason, I'm inclined to drop this code from the kernel source >>>> tree unless somebody steps in to fill the gap. >>>> >>> >>> Please don't drop this from kernel sources.. I think this is useful. If you >>> are looking for a maintainer, I will be happy to step up to maintain it. >> >> Cool, please do that then. :-) >> >> I will be happy to take pull requests with cpupower changes so that >> they go in along with the other PM material. >> > > Sounds like a plan. I can do that. I will work on getting git setup and > send pull requests. We can get that going for 4.15 unless you think it is > late for you to get pull requests. Shuah, I have two other cleanup patches that should be applied to cpupower. I will post them shortly. P. > > thanks, > -- Shuah > ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-02 0:42 ` Prarit Bhargava @ 2017-11-02 18:59 ` Shuah Khan 2017-11-02 19:43 ` Prarit Bhargava ` (2 more replies) 0 siblings, 3 replies; 17+ messages in thread From: Shuah Khan @ 2017-11-02 18:59 UTC (permalink / raw) To: Prarit Bhargava, Rafael J. Wysocki Cc: Stafford Horne, Shuah Khan, Linux PM, Thomas Renninger, Shuah Khan On 11/01/2017 06:42 PM, Prarit Bhargava wrote: > > > On 11/01/2017 06:30 PM, Shuah Khan wrote: >> On 11/01/2017 04:07 PM, Rafael J. Wysocki wrote: >>> On Wed, Nov 1, 2017 at 10:49 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>>> On 11/01/2017 03:46 PM, Rafael J. Wysocki wrote: >>>>> On Wed, Nov 1, 2017 at 10:38 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>>>>> On 11/01/2017 03:33 PM, Rafael J. Wysocki wrote: >>>>>>> On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote: >>>>>>>> On 10/25/2017 07:51 AM, Prarit Bhargava wrote: >>>>>>>>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >>>>>>>>> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >>>>>>>>> the command returns >>>>>>>>> >>>>>>>>> hardware limits: 800000 MHz - 4.200000 GHz >>>>>>>>> >>>>>>>>> The code that causes this error can be removed. The next else if clause >>>>>>>>> will handle the output correctly such that >>>>>>>>> >>>>>>>>> hardware limits: 800.000 MHz - 4.200000 GHz >>>>>>>>> >>>>>>>>> is displayed correctly. >>>>>>>>> >>>>>>>>> [v2]: Remove two lines instead of fixing broken code. >>>>>>>>> >>>>>>>>> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >>>>>>>>> Cc: Thomas Renninger <trenn@suse.com> >>>>>>>>> Cc: Stafford Horne <shorne@gmail.com> >>>>>>>>> Cc: Shuah Khan <shuah@kernel.org> >>>>>>>>> --- >>>>>>>>> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >>>>>>>>> 1 file changed, 2 deletions(-) >>>>>>>>> >>>>>>>>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>>> index 3e701f0e9c14..df43cd45d810 100644 >>>>>>>>> --- a/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>>> +++ b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >>>>>>>>> if (speed > 1000000) >>>>>>>>> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >>>>>>>>> ((unsigned int) speed%1000000)); >>>>>>>>> - else if (speed > 100000) >>>>>>>>> - printf("%u MHz", (unsigned int) speed); >>>>>>>>> else if (speed > 1000) >>>>>>>>> printf("%u.%03u MHz", ((unsigned int) speed/1000), >>>>>>>>> (unsigned int) (speed%1000)); >>>>>>>>> >>>>>>>> >>>>>>>> Thanks. I will queue this up for 4.15-rc1. >>>>>>> >>>>>>> OK >>>>>>> >>>>>>> So are you going to maintain this utility going forward? >>>>>>> >>>>>> >>>>>> oops. I was on auto-pilot responding to patches sitting in my Inbox. >>>>>> Wrong email response. Sorry about that. >>>>>> >>>>>> Please ignore. Mu bad. >>>>> >>>>> OK :-) >>>>> >>>>> But that said, from my perspective, cpupower is basically not maintained. >>>>> >>>>> Thomas, who sort of maintained it, but then basically became a patch >>>>> reviewer for it, does not respond to patches any more and I am not >>>>> sufficiently familiar with the code to be able to effectively review >>>>> the patches myself, nor I have the time to get more familiar with it. >>>>> >>>>> For this reason, I'm inclined to drop this code from the kernel source >>>>> tree unless somebody steps in to fill the gap. >>>>> >>>> >>>> Please don't drop this from kernel sources.. I think this is useful. If you >>>> are looking for a maintainer, I will be happy to step up to maintain it. >>> >>> Cool, please do that then. :-) >>> >>> I will be happy to take pull requests with cpupower changes so that >>> they go in along with the other PM material. >>> >> >> Sounds like a plan. I can do that. I will work on getting git setup and >> send pull requests. We can get that going for 4.15 unless you think it is >> late for you to get pull requests. > > Shuah, I have two other cleanup patches that should be applied to cpupower. I > will post them shortly. > Hi Prarit, Does this tool build for you? I am seeing: utils/helpers/amd.c:7:21: fatal error: pci/pci.h: No such file or directory #include <pci/pci.h> ^ compilation terminated. Makefile:221: recipe for target 'utils/helpers/amd.o' failed make: *** [utils/helpers/amd.o] Error 1 thanks, -- Shuah ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-02 18:59 ` Shuah Khan @ 2017-11-02 19:43 ` Prarit Bhargava 2017-11-02 20:05 ` Prarit Bhargava 2017-11-02 20:18 ` Prarit Bhargava 2 siblings, 0 replies; 17+ messages in thread From: Prarit Bhargava @ 2017-11-02 19:43 UTC (permalink / raw) To: Shuah Khan, Rafael J. Wysocki Cc: Stafford Horne, Shuah Khan, Linux PM, Thomas Renninger On 11/02/2017 02:59 PM, Shuah Khan wrote: > On 11/01/2017 06:42 PM, Prarit Bhargava wrote: >> >> >> On 11/01/2017 06:30 PM, Shuah Khan wrote: >>> On 11/01/2017 04:07 PM, Rafael J. Wysocki wrote: >>>> On Wed, Nov 1, 2017 at 10:49 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>>>> On 11/01/2017 03:46 PM, Rafael J. Wysocki wrote: >>>>>> On Wed, Nov 1, 2017 at 10:38 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>>>>>> On 11/01/2017 03:33 PM, Rafael J. Wysocki wrote: >>>>>>>> On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote: >>>>>>>>> On 10/25/2017 07:51 AM, Prarit Bhargava wrote: >>>>>>>>>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >>>>>>>>>> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >>>>>>>>>> the command returns >>>>>>>>>> >>>>>>>>>> hardware limits: 800000 MHz - 4.200000 GHz >>>>>>>>>> >>>>>>>>>> The code that causes this error can be removed. The next else if clause >>>>>>>>>> will handle the output correctly such that >>>>>>>>>> >>>>>>>>>> hardware limits: 800.000 MHz - 4.200000 GHz >>>>>>>>>> >>>>>>>>>> is displayed correctly. >>>>>>>>>> >>>>>>>>>> [v2]: Remove two lines instead of fixing broken code. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >>>>>>>>>> Cc: Thomas Renninger <trenn@suse.com> >>>>>>>>>> Cc: Stafford Horne <shorne@gmail.com> >>>>>>>>>> Cc: Shuah Khan <shuah@kernel.org> >>>>>>>>>> --- >>>>>>>>>> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >>>>>>>>>> 1 file changed, 2 deletions(-) >>>>>>>>>> >>>>>>>>>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>>>> index 3e701f0e9c14..df43cd45d810 100644 >>>>>>>>>> --- a/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>>>> +++ b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>>>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >>>>>>>>>> if (speed > 1000000) >>>>>>>>>> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >>>>>>>>>> ((unsigned int) speed%1000000)); >>>>>>>>>> - else if (speed > 100000) >>>>>>>>>> - printf("%u MHz", (unsigned int) speed); >>>>>>>>>> else if (speed > 1000) >>>>>>>>>> printf("%u.%03u MHz", ((unsigned int) speed/1000), >>>>>>>>>> (unsigned int) (speed%1000)); >>>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks. I will queue this up for 4.15-rc1. >>>>>>>> >>>>>>>> OK >>>>>>>> >>>>>>>> So are you going to maintain this utility going forward? >>>>>>>> >>>>>>> >>>>>>> oops. I was on auto-pilot responding to patches sitting in my Inbox. >>>>>>> Wrong email response. Sorry about that. >>>>>>> >>>>>>> Please ignore. Mu bad. >>>>>> >>>>>> OK :-) >>>>>> >>>>>> But that said, from my perspective, cpupower is basically not maintained. >>>>>> >>>>>> Thomas, who sort of maintained it, but then basically became a patch >>>>>> reviewer for it, does not respond to patches any more and I am not >>>>>> sufficiently familiar with the code to be able to effectively review >>>>>> the patches myself, nor I have the time to get more familiar with it. >>>>>> >>>>>> For this reason, I'm inclined to drop this code from the kernel source >>>>>> tree unless somebody steps in to fill the gap. >>>>>> >>>>> >>>>> Please don't drop this from kernel sources.. I think this is useful. If you >>>>> are looking for a maintainer, I will be happy to step up to maintain it. >>>> >>>> Cool, please do that then. :-) >>>> >>>> I will be happy to take pull requests with cpupower changes so that >>>> they go in along with the other PM material. >>>> >>> >>> Sounds like a plan. I can do that. I will work on getting git setup and >>> send pull requests. We can get that going for 4.15 unless you think it is >>> late for you to get pull requests. >> >> Shuah, I have two other cleanup patches that should be applied to cpupower. I >> will post them shortly. >> > > Hi Prarit, > > Does this tool build for you? I am seeing: > > utils/helpers/amd.c:7:21: fatal error: pci/pci.h: No such file or directory > #include <pci/pci.h> > ^ > compilation terminated. > Makefile:221: recipe for target 'utils/helpers/amd.o' failed > make: *** [utils/helpers/amd.o] Error 1 > It does not build on latest due to some other unrelated change. I'm looking at it now. P. > thanks, > -- Shuah > ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-02 18:59 ` Shuah Khan 2017-11-02 19:43 ` Prarit Bhargava @ 2017-11-02 20:05 ` Prarit Bhargava 2017-11-02 20:18 ` Prarit Bhargava 2 siblings, 0 replies; 17+ messages in thread From: Prarit Bhargava @ 2017-11-02 20:05 UTC (permalink / raw) To: Shuah Khan, Rafael J. Wysocki Cc: Stafford Horne, Shuah Khan, Linux PM, Thomas Renninger On 11/02/2017 02:59 PM, Shuah Khan wrote: > On 11/01/2017 06:42 PM, Prarit Bhargava wrote: >> >> >> On 11/01/2017 06:30 PM, Shuah Khan wrote: >>> On 11/01/2017 04:07 PM, Rafael J. Wysocki wrote: >>>> On Wed, Nov 1, 2017 at 10:49 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>>>> On 11/01/2017 03:46 PM, Rafael J. Wysocki wrote: >>>>>> On Wed, Nov 1, 2017 at 10:38 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: >>>>>>> On 11/01/2017 03:33 PM, Rafael J. Wysocki wrote: >>>>>>>> On Wed, Nov 1, 2017 at 10:00 PM, Shuah Khan <shuah@kernel.org> wrote: >>>>>>>>> On 10/25/2017 07:51 AM, Prarit Bhargava wrote: >>>>>>>>>> 'cpupower frequency-info -ln' returns kHz values on systems with MHz range >>>>>>>>>> minimum CPU frequency range. For example, on a 800MHz to 4.20GHz system >>>>>>>>>> the command returns >>>>>>>>>> >>>>>>>>>> hardware limits: 800000 MHz - 4.200000 GHz >>>>>>>>>> >>>>>>>>>> The code that causes this error can be removed. The next else if clause >>>>>>>>>> will handle the output correctly such that >>>>>>>>>> >>>>>>>>>> hardware limits: 800.000 MHz - 4.200000 GHz >>>>>>>>>> >>>>>>>>>> is displayed correctly. >>>>>>>>>> >>>>>>>>>> [v2]: Remove two lines instead of fixing broken code. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Prarit Bhargava <prarit@redhat.com> >>>>>>>>>> Cc: Thomas Renninger <trenn@suse.com> >>>>>>>>>> Cc: Stafford Horne <shorne@gmail.com> >>>>>>>>>> Cc: Shuah Khan <shuah@kernel.org> >>>>>>>>>> --- >>>>>>>>>> tools/power/cpupower/utils/cpufreq-info.c | 2 -- >>>>>>>>>> 1 file changed, 2 deletions(-) >>>>>>>>>> >>>>>>>>>> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>>>> index 3e701f0e9c14..df43cd45d810 100644 >>>>>>>>>> --- a/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>>>> +++ b/tools/power/cpupower/utils/cpufreq-info.c >>>>>>>>>> @@ -93,8 +93,6 @@ static void print_speed(unsigned long speed) >>>>>>>>>> if (speed > 1000000) >>>>>>>>>> printf("%u.%06u GHz", ((unsigned int) speed/1000000), >>>>>>>>>> ((unsigned int) speed%1000000)); >>>>>>>>>> - else if (speed > 100000) >>>>>>>>>> - printf("%u MHz", (unsigned int) speed); >>>>>>>>>> else if (speed > 1000) >>>>>>>>>> printf("%u.%03u MHz", ((unsigned int) speed/1000), >>>>>>>>>> (unsigned int) (speed%1000)); >>>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks. I will queue this up for 4.15-rc1. >>>>>>>> >>>>>>>> OK >>>>>>>> >>>>>>>> So are you going to maintain this utility going forward? >>>>>>>> >>>>>>> >>>>>>> oops. I was on auto-pilot responding to patches sitting in my Inbox. >>>>>>> Wrong email response. Sorry about that. >>>>>>> >>>>>>> Please ignore. Mu bad. >>>>>> >>>>>> OK :-) >>>>>> >>>>>> But that said, from my perspective, cpupower is basically not maintained. >>>>>> >>>>>> Thomas, who sort of maintained it, but then basically became a patch >>>>>> reviewer for it, does not respond to patches any more and I am not >>>>>> sufficiently familiar with the code to be able to effectively review >>>>>> the patches myself, nor I have the time to get more familiar with it. >>>>>> >>>>>> For this reason, I'm inclined to drop this code from the kernel source >>>>>> tree unless somebody steps in to fill the gap. >>>>>> >>>>> >>>>> Please don't drop this from kernel sources.. I think this is useful. If you >>>>> are looking for a maintainer, I will be happy to step up to maintain it. >>>> >>>> Cool, please do that then. :-) >>>> >>>> I will be happy to take pull requests with cpupower changes so that >>>> they go in along with the other PM material. >>>> >>> >>> Sounds like a plan. I can do that. I will work on getting git setup and >>> send pull requests. We can get that going for 4.15 unless you think it is >>> late for you to get pull requests. >> >> Shuah, I have two other cleanup patches that should be applied to cpupower. I >> will post them shortly. >> > > Hi Prarit, > > Does this tool build for you? I am seeing: > > utils/helpers/amd.c:7:21: fatal error: pci/pci.h: No such file or directory > #include <pci/pci.h> > ^ > compilation terminated. > Makefile:221: recipe for target 'utils/helpers/amd.o' failed > make: *** [utils/helpers/amd.o] Error 1 This is strange. I saw it, tried a git-bisect and now I can't reproduce it. I'll check out a new tree and see if I can make this reproduce. P. > > thanks, > -- Shuah > ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-02 18:59 ` Shuah Khan 2017-11-02 19:43 ` Prarit Bhargava 2017-11-02 20:05 ` Prarit Bhargava @ 2017-11-02 20:18 ` Prarit Bhargava 2017-11-02 20:20 ` Shuah Khan 2 siblings, 1 reply; 17+ messages in thread From: Prarit Bhargava @ 2017-11-02 20:18 UTC (permalink / raw) To: Shuah Khan, Rafael J. Wysocki Cc: Stafford Horne, Shuah Khan, Linux PM, Thomas Renninger On 11/02/2017 02:59 PM, Shuah Khan wrote: > On 11/01/2017 06:42 PM, Prarit Bhargava wrote: > > Hi Prarit, > > Does this tool build for you? I am seeing: > > utils/helpers/amd.c:7:21: fatal error: pci/pci.h: No such file or directory > #include <pci/pci.h> > ^ > compilation terminated. > Makefile:221: recipe for target 'utils/helpers/amd.o' failed > make: *** [utils/helpers/amd.o] Error 1 > Got it ... you have to have the pciutils-devel package installed which installs /usr/include/pci/pci.h. That file contains: struct pci_access { /* Options you can change: */ unsigned int method; /* Access method */ int writeable; /* Open in read/write mode */ int buscentric; /* Bus-centric view of the world */ <snip> P. > thanks, > -- Shuah > ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] cpupower: Fix no-rounding MHz frequency output 2017-11-02 20:18 ` Prarit Bhargava @ 2017-11-02 20:20 ` Shuah Khan 0 siblings, 0 replies; 17+ messages in thread From: Shuah Khan @ 2017-11-02 20:20 UTC (permalink / raw) To: Prarit Bhargava, Rafael J. Wysocki Cc: Stafford Horne, Shuah Khan, Linux PM, Thomas Renninger, Shuah Khan On 11/02/2017 02:18 PM, Prarit Bhargava wrote: > > > On 11/02/2017 02:59 PM, Shuah Khan wrote: >> On 11/01/2017 06:42 PM, Prarit Bhargava wrote: >> >> Hi Prarit, >> >> Does this tool build for you? I am seeing: >> >> utils/helpers/amd.c:7:21: fatal error: pci/pci.h: No such file or directory >> #include <pci/pci.h> >> ^ >> compilation terminated. >> Makefile:221: recipe for target 'utils/helpers/amd.o' failed >> make: *** [utils/helpers/amd.o] Error 1 >> > > Got it ... you have to have the pciutils-devel package installed which > installs /usr/include/pci/pci.h. > > That file contains: > > struct pci_access { > /* Options you can change: */ > unsigned int method; /* Access method */ > int writeable; /* Open in read/write mode */ > int buscentric; /* Bus-centric view of the world */ > <snip> > Thanks for looking into this. -- Shuah ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2017-11-02 20:20 UTC | newest] Thread overview: 17+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-10-25 13:51 [PATCH v2] cpupower: Fix no-rounding MHz frequency output Prarit Bhargava 2017-10-25 22:01 ` Stafford Horne 2017-11-01 21:01 ` Shuah Khan 2017-11-01 21:00 ` Shuah Khan 2017-11-01 21:33 ` Rafael J. Wysocki 2017-11-01 21:38 ` Shuah Khan 2017-11-01 21:46 ` Rafael J. Wysocki 2017-11-01 21:49 ` Shuah Khan 2017-11-01 22:07 ` Rafael J. Wysocki 2017-11-01 22:30 ` Shuah Khan 2017-11-01 22:34 ` Rafael J. Wysocki 2017-11-02 0:42 ` Prarit Bhargava 2017-11-02 18:59 ` Shuah Khan 2017-11-02 19:43 ` Prarit Bhargava 2017-11-02 20:05 ` Prarit Bhargava 2017-11-02 20:18 ` Prarit Bhargava 2017-11-02 20:20 ` Shuah Khan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).