From: Chen Yu <yu.c.chen@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Janek Kozicki <cosurgi@gmail.com>, Xunlei Pang <xpang@redhat.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH] timekeeping: Cap array access in timekeeping_debug to protect against invalid sleep times
Date: Thu, 18 Aug 2016 15:31:20 +0800 [thread overview]
Message-ID: <a34f51a8-9d40-0f9a-1e8c-f4feb2654bbe@intel.com> (raw)
In-Reply-To: <2035113.3OJj8z3OVW@vostro.rjw.lan>
On 2016年08月18日 09:09, Rafael J. Wysocki wrote:
> If pm_trace_enabled is set, we can (or maybe even should) just skip
> timekeeping_inject_sleeptime() entirely in rtc_resume() at least, because
> sleep_time is almost certainly bogus in that case, even if it doesn't
> overflow.
>
> Of course, the above is still needed then.
>
> Thanks,
> Rafael
>
OK, I'll provide another version on top of John's patch and consider the
pm_trace. thanks.
Yu
prev parent reply other threads:[~2016-08-18 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 15:27 [RFC,v3] timekeeping: Limit the sleep time to avoid overflow Chen Yu
2016-08-17 19:13 ` John Stultz
2016-08-17 19:18 ` [PATCH] timekeeping: Cap array access in timekeeping_debug to protect against invalid sleep times John Stultz
2016-08-18 1:09 ` Rafael J. Wysocki
2016-08-18 7:31 ` Chen Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a34f51a8-9d40-0f9a-1e8c-f4feb2654bbe@intel.com \
--to=yu.c.chen@intel.com \
--cc=cosurgi@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
--cc=xpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).