From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 027D6C7EE29 for ; Thu, 1 Jun 2023 10:09:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233283AbjFAKJc (ORCPT ); Thu, 1 Jun 2023 06:09:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233302AbjFAKJP (ORCPT ); Thu, 1 Jun 2023 06:09:15 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E6B3185 for ; Thu, 1 Jun 2023 03:07:19 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4f60a27c4a2so273103e87.2 for ; Thu, 01 Jun 2023 03:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685614037; x=1688206037; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DlJOSvTxFqzu1vsBnWmNhHSpMwuNc6ynDx6kXiqQq/s=; b=nbT1m2mtrTLzOU9m6eAg8yofW8n66e5RRkLFWVa0QPNp3fwVSxjFrNVQzaD0NOJ1LZ vyVuUF3mUyvKVJFVRWGCeCLhEsj9ocIHGD1o7VXLLsU7cQPqERVbI8V/705Xuc1BETxt UNIqAWPVFcOx/EwiiGWM9bokeAcPsLKw4pBVbuzwrFJsAkRIRDYtvSIUryT2sUbb2922 VZLhshEme/tUlCyCzNELf6Pp+EupBwxGNI/T37SZX7PuRbNVj654fNE6p4Gl/L737wlP 9Fwg7wv5xqKYCu+6vkpE+TdLyPXntqFrhHs67z8I8zhGGhFEz2/EyCug7fS4IghA0AvQ Nf9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685614037; x=1688206037; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DlJOSvTxFqzu1vsBnWmNhHSpMwuNc6ynDx6kXiqQq/s=; b=E5qKZbPXGcrYtlpf58fRyyeWKH9t7rFIiyzHRxaAqNYH48BXOXrkRQfof8lV+rCRiz O77vrY/bZTGzZWKuxD0WNeIfhfri7t5qCp/zY+r4zPqzk4RVTHuYcjYKRK0/7YUI8m+O CxQJOedE0AU5bKy+ip+WgGYvNA45V/QaRxQCX0+L0kKSHtUNDwRHfAR7Zvux2Mkm6fcR JTxEdc9hzdXPB0/XBRvMxJDpB3BNTAL+yjUbqgwtNYF5vy0QCiWqU1hzjeD4UGWGAzWk +x5lHbMoh8EyFSnvK8xYHnApPsfxUXhOpJPfIvrNmFNdd5pSP3oRVU8XWG6eq7Dma07W Vvew== X-Gm-Message-State: AC+VfDwOT0KTaaxW21HAhmNLXjMWyG0vjt6O7dAf9lDeemi3JPWhzY1A HkNW342tHcAi85TYBQdojuAXMQ== X-Google-Smtp-Source: ACHHUZ6vrphQJG8VEMbFrXbIFxbypPJ2w6EZDqBQ8tTjg3Dbl3MS3eNa0c3nwi3DZ6i270/KWqfKGQ== X-Received: by 2002:ac2:548c:0:b0:4f4:ca61:82ba with SMTP id t12-20020ac2548c000000b004f4ca6182bamr914748lfk.67.1685614037444; Thu, 01 Jun 2023 03:07:17 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id t20-20020ac243b4000000b004eb0c18efc2sm1030578lfl.221.2023.06.01.03.07.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 03:07:17 -0700 (PDT) Message-ID: Date: Thu, 1 Jun 2023 12:07:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 07/20] interconnect: qcom: Fold smd-rpm.h into icc-rpm.h Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Georgi Djakov , Leo Yan , Evan Green Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org References: <20230526-topic-smd_icc-v1-0-1bf8e6663c4e@linaro.org> <20230526-topic-smd_icc-v1-7-1bf8e6663c4e@linaro.org> <4de7d05a-91da-501c-2889-4eee8e3bd34f@linaro.org> <21f6b17b-366b-1233-e8f8-c9ac8503eeab@linaro.org> From: Konrad Dybcio In-Reply-To: <21f6b17b-366b-1233-e8f8-c9ac8503eeab@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 1.06.2023 12:04, Dmitry Baryshkov wrote: > On 01/06/2023 13:00, Konrad Dybcio wrote: >> >> >> On 1.06.2023 11:57, Dmitry Baryshkov wrote: >>> On 30/05/2023 13:20, Konrad Dybcio wrote: >>>> smd-rpm.h is not very useful as-is and both files are always included >>>> anyway.. Combine them. >>> >>> If we ever add interconnect driver for non-SMD RPM platforms (like MSM8960/APQ8064), we can just ignore the smd part. >> icc-rpm sends requests via smd so that doesn't sound unifiable > > Ack. Should we rename it to icc-smd-rpm.c while doing the merge? I'd stay it's fine if it stays as-is for now, until (if) somebody tackles "old" RPM. Konrad > >> >> Konrad >>> >>>> Signed-off-by: Konrad Dybcio >>>> --- >>>>    drivers/interconnect/qcom/icc-rpm.c |  1 - >>>>    drivers/interconnect/qcom/icc-rpm.h |  5 +++++ >>>>    drivers/interconnect/qcom/msm8916.c |  1 - >>>>    drivers/interconnect/qcom/msm8939.c |  1 - >>>>    drivers/interconnect/qcom/msm8974.c |  2 +- >>>>    drivers/interconnect/qcom/msm8996.c |  1 - >>>>    drivers/interconnect/qcom/qcm2290.c |  1 - >>>>    drivers/interconnect/qcom/qcs404.c  |  1 - >>>>    drivers/interconnect/qcom/sdm660.c  |  1 - >>>>    drivers/interconnect/qcom/smd-rpm.c |  2 +- >>>>    drivers/interconnect/qcom/smd-rpm.h | 15 --------------- >>>>    11 files changed, 7 insertions(+), 24 deletions(-) >>> >>> Reviewed-by: Dmitry Baryshkov >>> >