Linux Power Management development
 help / color / mirror / Atom feed
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	 Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v2] cpuidle: Add sanity check for exit latency and target residency
Date: Sat, 08 Nov 2025 16:07:37 +0200	[thread overview]
Message-ID: <a4c894d1334e587e094b7039745c792108086199.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0i9DkZR=ZnJ-+VDm-2wk-ab2X=RM69uiSTgwuhGnf8zVg@mail.gmail.com>

On Sat, 2025-11-08 at 12:48 +0100, Rafael J. Wysocki wrote:
> > > +static int validate_state(struct cpuidle_state *s, struct cpuidle_state *prev_s)
> > > +{
> > > +       if (s->exit_latency == 0)
> > > +               return -EINVAL;
> > 
> > The change above will break the polling state AFAICS.

Thanks for feedback. Yes. I first implemented this in intel_idle.c,
where this made sense, but then moved to cpuidle.c and did not notice.

Thanks,
Artem.

  reply	other threads:[~2025-11-08 14:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 19:07 [PATCH v2] cpuidle: Add sanity check for exit latency and target residency Rafael J. Wysocki
2025-11-08  8:49 ` Artem Bityutskiy
2025-11-08 11:02   ` Rafael J. Wysocki
2025-11-08 11:48     ` Rafael J. Wysocki
2025-11-08 14:07       ` Artem Bityutskiy [this message]
2025-11-10  7:58 ` Christian Loehle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4c894d1334e587e094b7039745c792108086199.camel@linux.intel.com \
    --to=artem.bityutskiy@linux.intel.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox