From: Lukasz Luba <lukasz.luba@arm.com>
To: Osama Abdelkader <osama.abdelkader@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
rafael@kernel.org, daniel.lezcano@linaro.org,
rui.zhang@intel.com
Subject: Re: [PATCH v2] thermal: hwmon: replace deprecated strcpy() with strscpy()
Date: Thu, 4 Sep 2025 08:45:11 +0100 [thread overview]
Message-ID: <a7dfd3da-fb55-411a-8410-062931c97e3d@arm.com> (raw)
In-Reply-To: <20250903192059.11353-1-osama.abdelkader@gmail.com>
On 9/3/25 20:20, Osama Abdelkader wrote:
> strcpy() is deprecated, use strscpy() instead for consistency with thermal
> subsystem since this is the only strcpy there.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
> v2:
> Improve the commit msg: add that this is the only strcpy left in thermal subsystem
> ---
> drivers/thermal/thermal_hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
> index 0ecccd4d8556..64cc3ab949fe 100644
> --- a/drivers/thermal/thermal_hwmon.c
> +++ b/drivers/thermal/thermal_hwmon.c
> @@ -96,7 +96,7 @@ thermal_hwmon_lookup_by_type(const struct thermal_zone_device *tz)
>
> mutex_lock(&thermal_hwmon_list_lock);
> list_for_each_entry(hwmon, &thermal_hwmon_list, node) {
> - strcpy(type, tz->type);
> + strscpy(type, tz->type);
> strreplace(type, '-', '_');
> if (!strcmp(hwmon->type, type)) {
> mutex_unlock(&thermal_hwmon_list_lock);
LGTM, that was indeed the single occurrence in thermal sub-system.
Thanks!
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
next prev parent reply other threads:[~2025-09-04 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 19:20 [PATCH v2] thermal: hwmon: replace deprecated strcpy() with strscpy() Osama Abdelkader
2025-09-04 7:45 ` Lukasz Luba [this message]
2025-09-05 18:53 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7dfd3da-fb55-411a-8410-062931c97e3d@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=osama.abdelkader@gmail.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox