Re: [PATCH 13/19] dm-bufio: use bio_add_virt_nofail

Mikulas Patocka
2025-05-06T09:37:01Z

On Wed, 30 Apr 2025, Christoph Hellwig wrote:

> Convert the __bio_add_page(..., virt_to_page(), ...) pattern to the
> bio_add_virt_nofail helper implementing it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Acked-by: Mikulas Patocka <mpatocka@redhat.com>

> ---
> drivers/md/dm-bufio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c
> index 9c8ed65cd87e..e82cd5dc83ce 100644
> --- a/drivers/md/dm-bufio.c
> +++ b/drivers/md/dm-bufio.c
> @@ -1362,7 +1362,7 @@ static void use_bio(struct dm_buffer *b, enum req_op op, sector_t sector,
> ptr = (char *)b->data + offset;
> len = n_sectors << SECTOR_SHIFT;
>
> - __bio_add_page(bio, virt_to_page(ptr), len, offset_in_page(ptr));
> + bio_add_virt_nofail(bio, ptr, len);
>
> submit_bio(bio);
> }
> --
> 2.47.2
>
>