Linux Power Management development
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	vschneid@redhat.com, rafael@kernel.org, viresh.kumar@linaro.org,
	mathieu.desnoyers@efficios.com, paulmck@kernel.org,
	hannes@cmpxchg.org, surenb@google.com,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Andrea Righi <arighi@nvidia.com>
Subject: Re: [PATCH] sched: Make clangd usable
Date: Fri, 23 May 2025 08:19:18 -1000	[thread overview]
Message-ID: <aDC8JsZetV-GHhG_@slm.duckdns.org> (raw)
In-Reply-To: <aDCmyEGIpPv6ggF1@slm.duckdns.org>

On Fri, May 23, 2025 at 06:48:08AM -1000, Tejun Heo wrote:
> On Fri, May 23, 2025 at 06:43:48PM +0200, Peter Zijlstra wrote:
> > 
> > Due to the weird Makefile setup of sched the various files do not
> > compile as stand alone units. The new generation of editors are trying
> > to do just this -- mostly to offer fancy things like completions but
> > also better syntax highlighting and code navigation.
> > 
> > Specifically, I've been playing around with neovim and clangd.
> > 
> > Setting up clangd on the kernel source is a giant pain in the arse
> > (this really should be improved), but once you do manage, you run into
> > dumb stuff like the above.
> > 
> > Fix up the scheduler files to at least pretend to work.
> > 
> > (this excludes ext because those include games are worse than average)
> 
> Yeah, ext needs to move the stuff that's shared between ext.c and ext_idle.c
> into ext.h. cc: Andrea.

Thinking more about it, I wonder whether what should happen is re-splitting
the includes and all that but add the combined compilation as a
default-enabled option, so that the files can be built separately at least
when verifying the source files are in sane states. Including the same files
multiple times don't really cost anything signficant, so that still
maintains the benefits of faster build speed. The way things are set up now,
the separation across files are bound to decay over time.

Thanks.

-- 
tejun

  reply	other threads:[~2025-05-23 18:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 16:43 [PATCH] sched: Make clangd usable Peter Zijlstra
2025-05-23 16:48 ` Tejun Heo
2025-05-23 18:19   ` Tejun Heo [this message]
2025-05-23 21:02   ` Andrea Righi
2025-05-23 16:49 ` Peter Zijlstra
2025-05-23 18:09   ` Steven Rostedt
2025-05-26  7:41     ` Peter Zijlstra
2025-05-26  8:11 ` Ingo Molnar
2025-05-26  8:59 ` Peter Zijlstra
2025-05-26  9:04   ` Peter Zijlstra
2025-05-26 11:44   ` Peter Zijlstra
2025-05-26 14:49 ` Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDC8JsZetV-GHhG_@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=surenb@google.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox