Re: [PATCH 2/2] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip

From: Aurelien Jarno <aurelien@aurel32.net>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
	Sebastian Reichel <sre@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	"open list:SYSTEM RESET/SHUTDOWN DRIVERS"
	<linux-pm@vger.kernel.org>,
	"open list:RISC-V SPACEMIT SoC Support"
	<linux-riscv@lists.infradead.org>,
	"open list:RISC-V SPACEMIT SoC Support"
	<spacemit@lists.linux.dev>
Subject: Re: [PATCH 2/2] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip
Date: Sun, 28 Sep 2025 23:01:00 +0200	[thread overview]
Message-ID: <aNmiDIUzx5eUEOQT@aurel32.net> (raw)
In-Reply-To: <E15EF3B2FD46EFE7+aNiYuset7FKRo_4C@kernel.org>

On 2025-09-28 10:08, Troy Mitchell wrote:
> Hi Aurelien, Thanks for your patch!
> 
> On Sun, Sep 28, 2025 at 12:07:41AM +0200, Aurelien Jarno wrote:
> > Add a "spacemit-p1-reboot" cell for the SpacemiT P1 chip.
> > 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> >  drivers/mfd/simple-mfd-i2c.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> > index 696b602051260..2e86efb0c82b8 100644
> > --- a/drivers/mfd/simple-mfd-i2c.c
> > +++ b/drivers/mfd/simple-mfd-i2c.c
> > @@ -99,6 +99,7 @@ static const struct regmap_config spacemit_p1_regmap_config = {
> >  };
> >  
> >  static const struct mfd_cell spacemit_p1_cells[] = {
> > +	{ .name = "spacemit-p1-reboot", },
> I’m not sure if this name is the best fit here.
> Since the driver also implements reboot and power-off functionality,
> would it make more sense to call it spacemit-p1-power?
> I’ll leave it up to you.

I see your point, for this driver naming everything was among the most 
complex things. I have chosen "spacemit-p1-reboot" to be consistent with  
the naming used in the driver itself. I chose them from recently added 
drivers supporting both poweroff and reset, that seems to all use the 
term reboot.

> Otherwise, LGTM.
> 
> Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> >  	{ .name = "spacemit-p1-regulator", },
> >  	{ .name = "spacemit-p1-rtc", },
> >  };
> > -- 
> > 2.47.2
> > 
> > 
> > _______________________________________________
> > linux-riscv mailing list
> > linux-riscv@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-riscv
> 

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net