From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20CAA27280E for ; Fri, 24 Oct 2025 18:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761329314; cv=none; b=RzqqBX57qa662f59/Pc8/efuub1TmZsacr8LzNYCdM6AFQLcW47+1bffqhfuUK6ZxFhwlCvSAM7IN49SaxRxuPsd4eEYpLmAd+j4ExLvOLM8Da1KmU2qXOue7hnfjnj/738sSMcCBdxDhh9g/zxE5frX6TK0wX7KZjnI4esAuls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761329314; c=relaxed/simple; bh=fs4CyyLRT6dkUGXO5Q+u/hfzegd+QrcsOC6QOosSMeo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d5n+FmfC77ZRRU3FyfRsA21dhSJyoQw31ritBE7sBslDvOdSojarp/kvUNLBQpZzivnXMUh/L6gLGw9wK345Al0xB+CNs1Eq37ogHZbYsexaFi9kErbBgvPeM0GC9zr1ghdH18h4gJUpIXqEeCr0O22Rzm0Bmwv8JRVL/g8nR+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BrOCGwZm; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BrOCGwZm" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-426fc536b5dso1710811f8f.3 for ; Fri, 24 Oct 2025 11:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761329311; x=1761934111; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4Vk2OMU5f1IjfJGz1tZfU6V+rEtX5ueWDjCoO5ODmWg=; b=BrOCGwZmsgvu3f9zdrIVgXYDTOq+Byno1eFHrVSrrVHNRvVFsndTGeN19A7fDA7saQ wgGujljhrVX10uWXcmDCt/RkM73MpOHPmjWQNzcnx/DiN3zUaZHqK9YPyquTosMDWIFb oZ8xcf1338kr5W38SdBanK7Ar4scefIYFENlts9wKB4d51UXhB3+2b8vNTDpr370K5AH w5EQH73EDamXDlPaPv8L0u2WQ8Q+sf0Yp3r4ExIRw6sfGdzJ/LYqEqNckKxtUe25BfS/ OiwWhSpRNWaRaWhSvnyowoSXUB3YGMaFu74w2cBggmu+7O6JLrs+U7S/cAezfKfTRCbX 00Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761329311; x=1761934111; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4Vk2OMU5f1IjfJGz1tZfU6V+rEtX5ueWDjCoO5ODmWg=; b=shwhptsENvWpxj19AA6oFrhT9pn6JJaXvmYMXGgpMtrK+wMr+Ld4yjRTySTZ0aggRh kBa4kfA/7qFtST/WbAxSkuuvF7Clgps/oizCZcHajEkeW9jKM3eKp4LErGlhm1kCBvR2 YtzDbdvL0RV1CcyeRS++UjXK0caA3GnATc1y/gFkHe+uX+MIVVCNREZpbkuk4dFXmkB1 qRAzCiF2XqtMtvFSVpKbGS35rF3UcB0/GHCVRV0myDSUrX87fgdti/DMfwJ/NozGujU4 7hV10Rh+YsOOS3YyJ4fkFsz9PgqYXMVcM7RBYrID0HAOK+hvre6pLV6QO4jotI2wN1Cw DULw== X-Forwarded-Encrypted: i=1; AJvYcCVMgijG+KhIbkvi1CzD88mIH+YVG1kjDI8P3ikSlkqjrjxdd3lbRF89Vn3muhjjO68qH+ue781p8w==@vger.kernel.org X-Gm-Message-State: AOJu0Yx+NzMWUrw/ER9RFMD/g0JXLw/+W1q2aIicT+RnXxrw2La3KqVG KCYittk/+d7inFucSx0ADN1cs2PLyNTaEPcZXpm2Q6qUELPbV/DMrcTPLp8kBYAeejM= X-Gm-Gg: ASbGncv9zAYm0rraLCcJ2NCDk4s9Dc8V+50Yqbe514W+3EG+XArS+1w6VDWpDdjlUXu HQihemfISYCOeSxlnWotLXFWQ+lJdZbDYniTRha6MJ5UvUl4gKxjOmVZlLrQr4tmxXJvi/YmA6V qm4fuiUX+J3cJzVyC5JfTysqwoL1rQV+Ra0FFk859XPJVQ1j5a+lrzELZKmUitLRh9sWMzGox3L csvYJ291A+CW4P+QCPyblH+kTOAjOonm+3uGdjunKM9KN8R+feRuNpmZWvZ0JAUdfzO1j1+XfIn gfWEE7ki3VCdFg+uUb9AHDLZqTG6PHP1lYPhrhohayE3N0hQEDX8/LKFmFt0MlS7G1JCFr9r5yR CF1oKO2sV7/CAt1BWvJ5qTnRAljC/k35LnYleZkVtn8FjcaZe5U4DGBlFo95L/VBGMF4jgCwVkR wJHdn9XfVbZmDUoA49 X-Google-Smtp-Source: AGHT+IGdI0GFFF8+9xDCagwj4MCOwEUqB1N0DZpsRtvn/B4KLEI2zmpucHSiVzTvwKt2YEcIpv/8lw== X-Received: by 2002:a05:6000:2506:b0:3f9:6657:d05 with SMTP id ffacd0b85a97d-429907107dbmr2776319f8f.12.1761329311443; Fri, 24 Oct 2025 11:08:31 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-429897e763csm10450792f8f.6.2025.10.24.11.08.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Oct 2025 11:08:31 -0700 (PDT) Date: Fri, 24 Oct 2025 21:08:27 +0300 From: Dan Carpenter To: Ally Heev Cc: Dwaipayan Ray , Lukas Bulwahn , Joe Perches , Jonathan Corbet , Andy Whitcroft , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, David Hunter , Shuah Khan , Viresh Kumar , Nishanth Menon , Stephen Boyd , linux-pm , dan.j.williams@intel.com Subject: Re: [PATCH v2 2/2] add check for pointers with __free attribute initialized to NULL Message-ID: References: <20251024-aheev-checkpatch-uninitialized-free-v2-0-16c0900e8130@gmail.com> <20251024-aheev-checkpatch-uninitialized-free-v2-2-16c0900e8130@gmail.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251024-aheev-checkpatch-uninitialized-free-v2-2-16c0900e8130@gmail.com> On Fri, Oct 24, 2025 at 10:59:16PM +0530, Ally Heev wrote: > pointers with __free attribute initialized to NULL > pose potential cleanup issues [1] when a function uses > interdependent variables with cleanup attributes > > Link: https://docs.kernel.org/core-api/cleanup.html [1] > Link: https://lore.kernel.org/all/68f7b830ec21a_10e910070@dwillia2-mobl4.notmuch/ > Suggested-by: Dan Williams > Signed-off-by: Ally Heev > --- I don't think this patch is a good idea... There are two issues to consider 1) The absolute number over warnings. 500+ is too high. 2) The ratio of bugs to false positives and we don't have any data on that but I bet it's low. It needs to be at least 5%. For anything lower than that, you're better off just reviewing code at random instead of looking through warnings. regards, dan carpenter