From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org,
srini@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
sre@kernel.org, sboyd@kernel.org, krzk@kernel.org,
dmitry.baryshkov@oss.qualcomm.com, quic_wcheng@quicinc.com,
melody.olvera@oss.qualcomm.com, quic_nsekar@quicinc.com,
ivo.ivanov.ivanov1@gmail.com, abelvesa@kernel.org,
luca.weiss@fairphone.com, konrad.dybcio@oss.qualcomm.com,
mitltlatltl@gmail.com, krishna.kurapati@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-pm@vger.kernel.org, kernel@collabora.com,
Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH v7 10/10] iio: adc: qcom-spmi-iadc: Remove regmap R/W wrapper functions
Date: Wed, 14 Jan 2026 11:03:33 +0200 [thread overview]
Message-ID: <aWdb5FQpodBLZLHY@smile.fi.intel.com> (raw)
In-Reply-To: <20260114083957.9945-11-angelogioacchino.delregno@collabora.com>
On Wed, Jan 14, 2026 at 09:39:57AM +0100, AngeloGioacchino Del Regno wrote:
> This driver doesn't need to add any register base address to any
> regmap call anymore since it was migrated to register as a SPMI
> subdevice with its own regmap reg_base, which makes the regmap
> API to automatically add such base address internally.
>
> Since the iadc_{read,write,read_result}() functions now only do
> call regmap_{read,write,bulk_read}() and nothing else, simplify
> the driver by removing them and by calling regmap APIs directly.
...
> {
> unsigned int count, retry;
> int ret;
> - u8 sta1;
> + u32 sta1;
Keep it in reversed xmas tree order.
> retry = interval_us / IADC_CONV_TIME_MIN_US;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-14 9:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 8:39 [PATCH RESEND v7 00/10] SPMI: Implement sub-devices and migrate drivers AngeloGioacchino Del Regno
2026-01-14 8:39 ` [PATCH v7 01/10] spmi: Print error status with %pe format AngeloGioacchino Del Regno
2026-01-14 8:39 ` [PATCH v7 02/10] spmi: Remove redundant dev_name() print in spmi_device_add() AngeloGioacchino Del Regno
2026-01-14 8:46 ` Andy Shevchenko
2026-01-14 8:39 ` [PATCH v7 03/10] spmi: Remove unneeded goto in spmi_device_add() error path AngeloGioacchino Del Regno
2026-01-14 8:39 ` [PATCH v7 04/10] spmi: Implement spmi_subdevice_alloc_and_add() and devm variant AngeloGioacchino Del Regno
2026-01-14 8:51 ` Andy Shevchenko
2026-01-14 8:39 ` [PATCH v7 05/10] nvmem: qcom-spmi-sdam: Migrate to devm_spmi_subdevice_alloc_and_add() AngeloGioacchino Del Regno
2026-01-14 8:56 ` Andy Shevchenko
2026-01-14 8:59 ` AngeloGioacchino Del Regno
2026-01-14 9:00 ` Andy Shevchenko
2026-01-14 9:03 ` AngeloGioacchino Del Regno
2026-01-14 9:07 ` Andy Shevchenko
2026-01-14 9:09 ` AngeloGioacchino Del Regno
2026-01-14 9:42 ` Andy Shevchenko
2026-01-14 9:47 ` Konrad Dybcio
2026-01-14 9:55 ` Andy Shevchenko
2026-01-14 9:58 ` Andy Shevchenko
2026-01-14 10:04 ` Konrad Dybcio
2026-01-14 10:09 ` Andy Shevchenko
2026-01-14 8:39 ` [PATCH v7 06/10] power: reset: qcom-pon: " AngeloGioacchino Del Regno
2026-01-14 8:57 ` Andy Shevchenko
2026-01-14 8:39 ` [PATCH v7 07/10] phy: qualcomm: eusb2-repeater: " AngeloGioacchino Del Regno
2026-01-14 8:59 ` Andy Shevchenko
2026-01-14 9:26 ` AngeloGioacchino Del Regno
2026-01-14 9:40 ` Andy Shevchenko
2026-01-14 8:39 ` [PATCH v7 08/10] misc: qcom-coincell: " AngeloGioacchino Del Regno
2026-01-14 8:39 ` [PATCH v7 09/10] iio: adc: qcom-spmi-iadc: " AngeloGioacchino Del Regno
2026-01-14 9:05 ` Andy Shevchenko
2026-01-14 8:39 ` [PATCH v7 10/10] iio: adc: qcom-spmi-iadc: Remove regmap R/W wrapper functions AngeloGioacchino Del Regno
2026-01-14 9:03 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-21 8:32 [PATCH v7 00/10] SPMI: Implement sub-devices and migrate drivers AngeloGioacchino Del Regno
2025-10-21 8:32 ` [PATCH v7 10/10] iio: adc: qcom-spmi-iadc: Remove regmap R/W wrapper functions AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWdb5FQpodBLZLHY@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abelvesa@kernel.org \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=dlechner@baylibre.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kernel@collabora.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=melody.olvera@oss.qualcomm.com \
--cc=mitltlatltl@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
--cc=quic_nsekar@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
--cc=srini@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox