[PATCH] power: supply: bd71828: Use dev_err_probe()

[PATCH] power: supply: bd71828: Use dev_err_probe()

[Matti Vaittinen]

[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]

From: Matti Vaittinen <mazziesaccount@gmail.com>

The driver uses separate error printing and error returning at probe()
for locations where the error value is hard-coded and can't be
EPROBE_DEFER. This helps to omit the extra return value check which is
done in dev_err_probe().

Using the dev_err_probe() has some other benefits besides handling the
-EPROBE_DEFER though, like standardizing the print for error numbers.
Some believe thes outweigh the benefit of skipping the extra check.

Use dev_err_probe() consistently in the bd71828 power-supply probe.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
---

This patch depends on, and is done on top of, the series:
https://lore.kernel.org/all/cover.1765804226.git.mazziesaccount@gmail.com/
as discussed:
https://lore.kernel.org/all/aWbg3PTf677Jt9rG@venus/

 drivers/power/supply/bd71828-power.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/power/supply/bd71828-power.c b/drivers/power/supply/bd71828-power.c
index 438e220a9cb7..0e00acb58993 100644
--- a/drivers/power/supply/bd71828-power.c
+++ b/drivers/power/supply/bd71828-power.c
@@ -1058,10 +1058,8 @@ static int bd71828_power_probe(struct platform_device *pdev)
 		pwr->regmap = dev_get_regmap(pdev->dev.parent, NULL);
 	else
 		pwr->regmap = dev_get_regmap(pdev->dev.parent, "wrap-map");
-	if (!pwr->regmap) {
-		dev_err(&pdev->dev, "No parent regmap\n");
-		return -EINVAL;
-	}
+	if (!pwr->regmap)
+		return dev_err_probe(&pdev->dev, -EINVAL, "No parent regmap\n");
 
 	pwr->dev = &pdev->dev;
 
@@ -1083,8 +1081,7 @@ static int bd71828_power_probe(struct platform_device *pdev)
 		dev_dbg(pwr->dev, "Found ROHM BD72720\n");
 		break;
 	default:
-		dev_err(pwr->dev, "Unknown PMIC\n");
-		return -EINVAL;
+		return dev_err_probe(pwr->dev, -EINVAL, "Unknown PMIC\n");
 	}
 
 	ret = bd7182x_get_rsens(pwr);
-- 
2.52.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] power: supply: bd71828: Use dev_err_probe()

[Sebastian Reichel]

On Thu, 15 Jan 2026 12:19:04 +0200, Matti Vaittinen wrote:
> The driver uses separate error printing and error returning at probe()
> for locations where the error value is hard-coded and can't be
> EPROBE_DEFER. This helps to omit the extra return value check which is
> done in dev_err_probe().
> 
> Using the dev_err_probe() has some other benefits besides handling the
> -EPROBE_DEFER though, like standardizing the print for error numbers.
> Some believe thes outweigh the benefit of skipping the extra check.
> 
> [...]

Applied, thanks!

[1/1] power: supply: bd71828: Use dev_err_probe()
      commit: 12bdf471e374b34cb0e48b29bb9eb9127ed26fc5

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>