From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2BF03C1986; Thu, 22 Jan 2026 08:51:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769071915; cv=none; b=nvPWj3CYm0BUVih5HTpscpSJXUhngGfByctubHrVfZ8Y4AHkcbj1+sXoLCT0FKK4fy6FkC/lTcZOeyZJsZLQwL/8sLkb9GZl/QpzgiYY823vYdLHazOPKKFNPX0fFAfKCpe3Xax9o/Y947ds0Ix9p2UZBPR5eZFEpoPhCRc8Uvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769071915; c=relaxed/simple; bh=Z1BPPqPX3pPbBMPk0JKd8AgqIRbd45v5OCLMXlCvDmI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TWspjDnk60CBP5jG1y4mHpmxTECn3mpXTlBeh901k3LIJWe3fuLYdwKQQ1mB2elTKBy0ri0BHRhkt3bw/CE0bKgLnxSIavDjOPbaPSJVkY+vww/w1uOg9DqXw53t7ksBHzfRovMyDkeKy6eLlTnYLfLGSEp9hGiHFIO0RzHBRQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=E7E5MQUA; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="E7E5MQUA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769071913; x=1800607913; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Z1BPPqPX3pPbBMPk0JKd8AgqIRbd45v5OCLMXlCvDmI=; b=E7E5MQUA86S2kVqhNNBjhls97COoh4iDg41WpWIUvxZ3zlfilzZMNmtG uqPMBjiAXQqNA8ajbFVXlq1HxI6gZ3KX4BXMgX2yoiyEMV9hahOEoOvOg qB72TC0BFoshZpC+L/Y8TQyKmW+W5HQIgQAZ19HHRj0GB9DJ6KFRnft3s J6W6vL8zo2KHxA+UiZagjRF0LlFuAqpmwri5/kjBD70sI1jJ+IsXJKhR7 LYOQrbKMwoB6PUpYIJ8x+PKBKusljKxX7VbLt6tHfUU7gF1dm7VFSItP4 0A2YlzlhcpUe6Hvp2PZXLzNRfVvzpxZ+Fp0tKZ7rcJc8XozuLMEidBc4s w==; X-CSE-ConnectionGUID: Kzuh9nCeQWO3ObbJjCDniQ== X-CSE-MsgGUID: TEjq8q/JTVaSGN/gGfWPFQ== X-IronPort-AV: E=McAfee;i="6800,10657,11678"; a="87886583" X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="87886583" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2026 00:51:52 -0800 X-CSE-ConnectionGUID: Ut8v1+UKSXefrKbRvupFww== X-CSE-MsgGUID: Fmn0XlYCQ9Ow5Wf/9VG+3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="211130999" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.225]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2026 00:51:45 -0800 Date: Thu, 22 Jan 2026 10:51:43 +0200 From: Andy Shevchenko To: Sui Jingfeng Cc: manivannan.sadhasivam@oss.qualcomm.com, Rob Herring , Greg Kroah-Hartman , Jiri Slaby , Nathan Chancellor , Nicolas Schier , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Mark Pearson , "Derek J. Clark" , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley , Marcel Holtmann , Luiz Augusto von Dentz , Bartosz Golaszewski , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Bartosz Golaszewski , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-pm@vger.kernel.org, Stephan Gerhold , Dmitry Baryshkov , linux-acpi@vger.kernel.org Subject: Re: [PATCH v3 03/14] software node: Implement device_get_match_data fwnode callback Message-ID: References: <20260110-pci-m2-e-v3-0-4faee7d0d5ae@oss.qualcomm.com> <20260110-pci-m2-e-v3-3-4faee7d0d5ae@oss.qualcomm.com> <26a001c3-2140-4241-87dd-604eab3f827b@linux.dev> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26a001c3-2140-4241-87dd-604eab3f827b@linux.dev> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Jan 14, 2026 at 11:21:59AM +0800, Sui Jingfeng wrote: > On 2026/1/12 15:56, Andy Shevchenko wrote: > > On Sat, Jan 10, 2026 at 12:26:21PM +0530, Manivannan Sadhasivam via B4 Relay wrote: > > > Because the software node backend of the fwnode API framework lacks an > > > implementation for the .device_get_match_data function callback. > > Maybe this is done on purpose. > > It is a *fact* that the broken swnode lacks an implementation for the .device_get_match_data stub. No need to re-create board files when it's not needed or doesn't fit. > Otherwise, If it is really done *on purpose*, the maintainers of swnode > backend could/shall document it in the source file *explicitly*. Probably it should be spoken in a better way. > > Have you thought about this aspect? > > If you are sure, then stop telling us something start with "Maybe ..." I wasn't the author of the swnode idea I can't read their minds. Please, ask the respective people about this directly. > > > This makes it difficult to use(and/or test) a few drivers that originates > > > from DT world on the non-DT platform. > > How difficult? > > The emphasis isn't on the 'difficult', it means that not convenient > > > DSA implementation went to the way of taking DT overlay > > approach. > > Software node can do the same implementation just as what ACPI fwnode backend does. > > > Why that one can't be applied here? > > DT overlay requires the OS distribution(such as ubuntu) has theDT overlay > config option selected. this is introduce extra overhead/side effects on the > non-DT systems. If we have hotpluggable or runtime reconfigurable devices this is the expected option to support them. I don't see a problem here. > > > Implement the .device_get_match_data fwnode callback, which helps to keep > > > the three backends of the fwnode API aligned as much as possible. This is > > > also a fundamental step to make a few drivers OF-independent truely > > > possible. > > > > > > Device drivers or platform setup codes are expected to provide a software > > > node string property, named as "compatible". At this moment, the value of > > > this string property is being used to match against the compatible entries > > > in the of_device_id table. It can be extended in the future though. > > I really do not want to see this patch > > Whatever! > > Then just stop the endless, bruth-force ranting on such a straight-forward thing. > > > without very good justification > > Justifications has been provided over and over again. > > > (note, there were at least two attempts in the past > > This exactly saying that the implementation is missing. Now you count a third one for your pleasure :-) P.S. We already had this discussion in the past and this attitude won't help moving forward. -- With Best Regards, Andy Shevchenko