From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: linux-pm@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: [bug report] power: sequencing: qcom-wcn: add support for WCN39xx
Date: Fri, 6 Feb 2026 16:40:19 +0300 [thread overview]
Message-ID: <aYXvQxKqmjP_sdCd@stanley.mountain> (raw)
In-Reply-To: <caa37f28-a2e8-4e0a-a9ce-a365ce805e4b@stanley.mountain>
[ Smatch checking is paused while we raise funding. #SadFace
https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ]
Hello Dmitry Baryshkov,
Commit 0eb85f468ef5 ("power: sequencing: qcom-wcn: add support for
WCN39xx") from Jan 6, 2026 (linux-next), leads to the following
Smatch static checker warning:
drivers/power/sequencing/pwrseq-qcom-wcn.c:492 pwrseq_qcom_wcn_probe()
warn: passing zero to 'dev_err_probe'
drivers/power/sequencing/pwrseq-qcom-wcn.c
458 static int pwrseq_qcom_wcn_probe(struct platform_device *pdev)
459 {
460 struct device *dev = &pdev->dev;
461 struct pwrseq_qcom_wcn_ctx *ctx;
462 struct pwrseq_config config;
463 int i, ret;
464
465 ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
466 if (!ctx)
467 return -ENOMEM;
468
469 ctx->of_node = dev->of_node;
470
471 ctx->pdata = device_get_match_data(dev);
472 if (!ctx->pdata)
473 return dev_err_probe(dev, -ENODEV,
474 "Failed to obtain platform data\n");
475
476 ctx->regs = devm_kcalloc(dev, ctx->pdata->num_vregs,
477 sizeof(*ctx->regs), GFP_KERNEL);
478 if (!ctx->regs)
479 return -ENOMEM;
480
481 for (i = 0; i < ctx->pdata->num_vregs; i++)
482 ctx->regs[i].supply = ctx->pdata->vregs[i];
483
484 ret = devm_regulator_bulk_get(dev, ctx->pdata->num_vregs, ctx->regs);
485 if (ret < 0)
486 return dev_err_probe(dev, ret,
487 "Failed to get all regulators\n");
488
489 if (ctx->pdata->has_vddio) {
490 ctx->vddio = devm_regulator_get(dev, "vddio");
491 if (IS_ERR(ctx->vddio))
--> 492 return dev_err_probe(dev, ret, "Failed to get VDDIO\n");
s/ret/PTR_ERR(ctx->vddio)/
493 }
494
495 ctx->bt_gpio = devm_gpiod_get_optional(dev, "bt-enable", GPIOD_OUT_LOW);
496 if (IS_ERR(ctx->bt_gpio))
497 return dev_err_probe(dev, PTR_ERR(ctx->bt_gpio),
498 "Failed to get the Bluetooth enable GPIO\n");
499
500 /*
regards,
dan carpenter
parent reply other threads:[~2026-02-06 13:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <caa37f28-a2e8-4e0a-a9ce-a365ce805e4b@stanley.mountain>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYXvQxKqmjP_sdCd@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox