Re: [PATCH] powercap: intel_rapl: Add support for RAPTORLAKE_P

["Sworo, George D" <george.d.sworo@intel.com>]

On Thu, 2022-06-09 at 14:02 -0700, srinivas pandruvada wrote:
> On Thu, 2022-06-09 at 20:55 +0200, Rafael J. Wysocki wrote:
> > Rui, Srinivas, should I take this one?
> > 
> Yes.
> 
> Not sure if the RAPL-MMIO driver is loaded on this system.
> 
> George,
> 
> What is the output of
> lspci -vv -s :0:4.0
> 
> If the device id is 0xA71D, then we have this change in the
> upstream kernel. If not then we need to submit patch for that.
> 
> Thanks,
> Srinivas
> 
Thanks for the quick review.

the device id is 0xA71D is not avaible without this patch. But when
add it i can see the ID. Below are the outputs

Output from a kernel without this patch:
-------------------------------------
localhost ~ # lspci -vv -s :0:4.0
00:04.0 Signal processing controller: Intel Corporation Alder Lake
Innovation Platform Framework Processor Participant (rev 03)
	Subsystem: Intel Corporation Device 7270
	Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-

Output with this patch added:
----------------------------------------
localhost ~ # lspci -vv -s :0:4.0
00:04.0 Signal processing controller: Intel Corporation Device a71d

> > On Wed, Jun 1, 2022 at 9:22 PM <george.d.sworo@intel.com> wrote:
> > > From: George D Sworo <george.d.sworo@intel.com>
> > > 
> > > Add RAPTORLAKE_P to the list of supported processor model in the
> > > Intel
> > > 
> > > RAPL power capping driver.
> > > 
> > > Signed-off-by: George D Sworo <george.d.sworo@intel.com>
> > > ---
> > >  drivers/powercap/intel_rapl_common.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/powercap/intel_rapl_common.c
> > > b/drivers/powercap/intel_rapl_common.c
> > > index a9c99d9e8b42..21d624f9f5fb 100644
> > > --- a/drivers/powercap/intel_rapl_common.c
> > > +++ b/drivers/powercap/intel_rapl_common.c
> > > @@ -1109,6 +1109,7 @@ static const struct x86_cpu_id rapl_ids[]
> > > __initconst = {
> > >         X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L,        
> > > &rapl_defaults_core),
> > >         X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_N,        
> > > &rapl_defaults_core),
> > >         X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE,         
> > > &rapl_defaults_core),
> > > +       X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P,       
> > > &rapl_defaults_core),
> > >         X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X,   
> > > &rapl_defaults_spr_server),
> > >         X86_MATCH_INTEL_FAM6_MODEL(LAKEFIELD,          
> > > &rapl_defaults_core),
> > > 
> > > --
> > > 2.17.1
> > >