From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12FC7C63705 for ; Thu, 8 Dec 2022 09:05:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229514AbiLHJFD (ORCPT ); Thu, 8 Dec 2022 04:05:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230228AbiLHJEQ (ORCPT ); Thu, 8 Dec 2022 04:04:16 -0500 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 534796C736 for ; Thu, 8 Dec 2022 01:03:36 -0800 (PST) Received: by mail-lj1-x232.google.com with SMTP id s10so881510ljg.1 for ; Thu, 08 Dec 2022 01:03:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zEvaXwfwqSzOoHW10MEDPIfbZ9OLutRaMA8i2YGQwvI=; b=aIkzLftuSRZKtfnIFiekFOrwTJsxp/QyAB/6XfYm9E8xgXWpK5EanAZgNkhW46QHHf VVM1iI9wQ0q75uDJ+M/wrVlDiTmDzgioer1m8oPZGz9FHyBD1cvbO7sHWsvcHkLUdfdN WpOdRHA+UlcX/Xy92NaFlZhaTN/0LcNyTX4OF5gQ0ZJ+tYanQLuZG8NJWT9N+fkA8upT NFjAO5+Mi3XvZ57qdoZOQzTM5Geq4b/F3RXVV+fBoYWy5JeHfNi83fM50q7jZ67Fs+Z8 LQ0FiJHYcmB6rUYz46nUZJJPPDZ7az9LSvOEgIohRWsndh5RCrsybkYz8LaZ5pl6dc7H tUHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zEvaXwfwqSzOoHW10MEDPIfbZ9OLutRaMA8i2YGQwvI=; b=2Ove/V45/g433xBL4CUsuaKmOSA3QRhsjVeJDX1/C/xb1ROwPNoxthe7HWU/Q9k3Wl 9X8sLKygfuzaEsrcI+BIV2zoY38sExgQmN7wuWZxv0ApxV1Y/HFIh4mXE415PbIOMhbT onelquzky2BnJIr4MjthuJzmsrt5PBLSk1/gRY3p5CBt1cf6A+G3aBTJO+NJ8tlyn+y2 IUIIrUmQtS7L9vy0X3Q33mxDvixNmV7GhtoqiombUO+fk5OFdkGWXTUyx8pH5MbJjUU0 8T2iL3ADTZPV31v6/0IKWpaaNWVV9FEQ4Myvyt2PGEmTcLsR1QxcCptB02VslfExiNQb 9PnA== X-Gm-Message-State: ANoB5plYcD7P+punMI+jrx5Cklziba9MhMhV7MTLZChCh7xTPJYcYZ7Z v8rhaXxojSgrLEf63I+QAeWaEQ== X-Google-Smtp-Source: AA0mqf6O33YWpaLk6sFSSTi+41ETMZdxHV8vPSwu4LnLTcj1qhWk9Zs4fkhnpaXAEDKpj5+y+hfk4g== X-Received: by 2002:a2e:a804:0:b0:277:81ff:c2c7 with SMTP id l4-20020a2ea804000000b0027781ffc2c7mr27471475ljq.23.1670490214614; Thu, 08 Dec 2022 01:03:34 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id b26-20020a2e895a000000b00279e0b8bae7sm1689484ljk.65.2022.12.08.01.03.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 01:03:34 -0800 (PST) Message-ID: Date: Thu, 8 Dec 2022 10:03:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RESEND PATCH v2 1/3] dt-bindings: power: Add starfive,jh71xx-pmu Content-Language: en-US To: Walker Chen , linux-riscv@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org References: <20221208084523.9733-1-walker.chen@starfivetech.com> <20221208084523.9733-2-walker.chen@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20221208084523.9733-2-walker.chen@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 08/12/2022 09:45, Walker Chen wrote: > Add bindings for Power Management Unit (PMU) on the StarFive JH71XX SoC. > > Signed-off-by: Walker Chen > + }; > diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h > new file mode 100644 > index 000000000000..73c6a79a2181 > --- /dev/null > +++ b/include/dt-bindings/power/starfive,jh7110-pmu.h > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ Why different license than the bindings? MIT is pretty compatible, but if it does not matter for you, keep same licenses as bindings. > +/* > + * Copyright (C) 2022 StarFive Technology Co., Ltd. > + * Author: Walker Chen > + */ > +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ > +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ > + > +#define JH7110_PD_SYSTOP 0 > +#define JH7110_PD_CPU 1 > +#define JH7110_PD_GPUA 2 > +#define JH7110_PD_VDEC 3 > +#define JH7110_PD_VOUT 4 > +#define JH7110_PD_ISP 5 > +#define JH7110_PD_VENC 6 > + > +#endif Best regards, Krzysztof