From: "André Draszik" <andre.draszik@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Juan Yescas <jyescas@google.com>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v8 05/10] pmdomain: samsung: convert to using regmap
Date: Thu, 19 Mar 2026 11:58:45 +0000 [thread overview]
Message-ID: <ae31c62c940e99077d44e1935465dce7db0e4c06.camel@linaro.org> (raw)
In-Reply-To: <c5ba58fb-50f1-4067-a099-97169ea81f68@samsung.com>
Hi Marek,
On Thu, 2026-03-19 at 11:29 +0100, Marek Szyprowski wrote:
> On 19.03.2026 11:13, Ulf Hansson wrote:
> > As a follow-up patch on top, please consider converting the open-coded
> > polling loop above into a readx_poll_timeout_atomic().
>
> This has been tried and it doesn't work in all cases required for power
> domain driver:
>
> https://lore.kernel.org/all/5c19e4ef-c4fd-4bf5-88b3-46c86751b14e@samsung.com/
>
> Probably a comment about that could be added directly to this code to
> avoid such conversion and breakage in the future.
I am planning to revisit this in the future and am hoping that we can
figure out what goes wrong when using regmap_read_poll_timeout().
Hopefully such a comment would only be short-lived, so maybe not really
worth it? I can add it, though, if you prefer.
Cheers,
Andre'
next prev parent reply other threads:[~2026-03-19 11:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 15:27 [PATCH v8 00/10] pmdomain: samsung: add support for Google GS101 André Draszik
2026-03-18 15:27 ` [PATCH v8 01/10] dt-bindings: soc: google: add google,gs101-dtzpc André Draszik
2026-03-18 15:27 ` [PATCH v8 02/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2026-03-21 13:16 ` Krzysztof Kozlowski
2026-03-30 10:52 ` André Draszik
2026-03-30 10:55 ` Krzysztof Kozlowski
2026-03-30 10:59 ` André Draszik
2026-03-30 11:03 ` Krzysztof Kozlowski
2026-03-18 15:27 ` [PATCH v8 03/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding André Draszik
2026-03-18 15:27 ` [PATCH v8 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children André Draszik
2026-03-21 19:14 ` Krzysztof Kozlowski
2026-03-30 12:00 ` André Draszik
2026-03-30 12:10 ` Krzysztof Kozlowski
2026-03-22 23:08 ` Rob Herring (Arm)
2026-03-18 15:27 ` [PATCH v8 05/10] pmdomain: samsung: convert to using regmap André Draszik
2026-03-19 10:13 ` Ulf Hansson
2026-03-19 10:29 ` Marek Szyprowski
2026-03-19 11:58 ` André Draszik [this message]
2026-03-19 15:57 ` Marek Szyprowski
2026-03-19 16:42 ` Ulf Hansson
2026-03-21 13:16 ` Krzysztof Kozlowski
2026-03-30 10:53 ` André Draszik
2026-03-18 15:27 ` [PATCH v8 06/10] pmdomain: samsung: don't hard-code offset for registers to 0 and 4 André Draszik
2026-03-18 15:27 ` [PATCH v8 07/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2026-03-21 13:16 ` Krzysztof Kozlowski
2026-03-30 10:55 ` André Draszik
2026-03-18 15:27 ` [PATCH v8 08/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2026-03-18 15:27 ` [PATCH v8 09/10] pmdomain: samsung: implement SMC to save / restore TZ config André Draszik
2026-03-18 15:27 ` [PATCH v8 10/10] pmdomain: samsung: implement domain-supply regulator André Draszik
2026-03-21 13:17 ` (subset) [PATCH v8 00/10] pmdomain: samsung: add support for Google GS101 Krzysztof Kozlowski
2026-03-23 11:13 ` Ulf Hansson
2026-03-30 9:54 ` Krzysztof Kozlowski
2026-03-30 10:13 ` Ulf Hansson
2026-03-30 10:17 ` Krzysztof Kozlowski
2026-03-30 11:12 ` Ulf Hansson
2026-03-30 11:24 ` Krzysztof Kozlowski
2026-03-30 13:30 ` Ulf Hansson
2026-03-30 13:38 ` Krzysztof Kozlowski
2026-03-31 9:01 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae31c62c940e99077d44e1935465dce7db0e4c06.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox