From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD0C1C433FE for ; Thu, 11 Nov 2021 07:31:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B22561884 for ; Thu, 11 Nov 2021 07:31:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbhKKHeF (ORCPT ); Thu, 11 Nov 2021 02:34:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44415 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbhKKHeE (ORCPT ); Thu, 11 Nov 2021 02:34:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636615875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZYQEw5GVtmhIImAbCeB41t1wheO6mxsaCZLTEEKlNIY=; b=PM1u03IepqiSYIaUbg7hJZ9CQJJBbWvS4ihd8QgNNEJrFICkoYvnRz69d70Dk1/zSqw5z0 xW4XgMBYh7mlkNDbCqXqAgwl1tModw3tDFVrPMAmRmwGWUHXRYMpaPay9w5Y7zwfxcAVL3 DwcVbc+l0DvetzkdBUCM28Fl4TBky7I= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-TlQPyAhJPQ-pykOjP57xoQ-1; Thu, 11 Nov 2021 02:31:14 -0500 X-MC-Unique: TlQPyAhJPQ-pykOjP57xoQ-1 Received: by mail-wm1-f70.google.com with SMTP id a67-20020a1c7f46000000b00333629ed22dso783191wmd.6 for ; Wed, 10 Nov 2021 23:31:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZYQEw5GVtmhIImAbCeB41t1wheO6mxsaCZLTEEKlNIY=; b=zvG/EJRlA01bZkpSotTJ/5f4dRAq2NCHDnF8loJKsusLDXn7Llm1MfpLQVUPt40JC5 XEJFg6Pn8eFvOzqBOsVs2DEGk54h4dH0SRHORIdL1B+BWqBrDR8Y8SF6VEkASJ+eycP9 NsCTtPBuwY7t7CgW4XnVOmJfeTZgijqJuUwlVg/+jJpg+7jxIJiIzX/39Y2F7LDm8mUd sEUaoAo/GTGzwVpmfSMqvVpiLMvLzdBeeXAkAEqgAqcYMfbKlVLxztVu41M8DQv8qBqE y063j2IyijohdXA0b0kyVNxTHoECL24jEnc7TU6c9Zcp3K9FK+dyA3V0SepoE/KI5sgr a2Og== X-Gm-Message-State: AOAM530Td7hIucf+4hSg5LFWGZA6Z5bDru2uq+ZzWpLrsoAQwHsX3a0c x/uY92n/T60iQdNJ4CJrtDQcUrCAf1xHk6RlJ4blys0lHZg/UWrN/dHnRQ8jmai8BHngWtmgngt WLPq3UUB+V1gv7PjVxw4= X-Received: by 2002:adf:ee04:: with SMTP id y4mr6361291wrn.0.1636615873229; Wed, 10 Nov 2021 23:31:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1JLpDvD1ipMwjqp3XjHqiTZwSRafDcbKcys/CZyMEO92UHHU3jo67AkcjMz8ueVY4Z8KreA== X-Received: by 2002:adf:ee04:: with SMTP id y4mr6361266wrn.0.1636615873037; Wed, 10 Nov 2021 23:31:13 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id h1sm1962703wmb.7.2021.11.10.23.31.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Nov 2021 23:31:12 -0800 (PST) Message-ID: Date: Thu, 11 Nov 2021 08:31:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [REGRESSION]: drivers/firmware: move x86 Generic System Framebuffers support Content-Language: en-US To: Ilya Trukhanov Cc: stable@vger.kernel.org, regressions@lists.linux.dev, linux-efi@vger.kernel.org, linux-pm@vger.kernel.org, tzimmermann@suse.de, ardb@kernel.org, rafael@kernel.org, len.brown@intel.com, pavel@ucw.cz, dri-devel References: <20211110200253.rfudkt3edbd3nsyj@lahvuun> <627b6cd1-3446-5e55-ea38-5283a186af39@redhat.com> <20211111004539.vd7nl3duciq72hkf@lahvuun> From: Javier Martinez Canillas In-Reply-To: <20211111004539.vd7nl3duciq72hkf@lahvuun> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hello Ilya, On 11/11/21 01:45, Ilya Trukhanov wrote: [snip] >> Can you please share the kernel boot log for any of these cases too ? > Thanks a lot for the testing and providing the info! >> This is just a guess though. Would be good if you could test following cases: >> >> 1) CONFIG_FB_EFI not set > > /proc/fb: > 0 amdgpu > > dmesg: https://pastebin.com/c1BcWLEh > > Suspend-to-RAM works. > >> 2) CONFIG_FB_EFI=y and CONFIG_DRM_AMDGPU=m > > /proc/fb before `modprobe amdgpu`: > 0 EFI VGA > > after: > 0 amdgpu > > dmesg: https://pastebin.com/vSsTw2Km > > Suspend-to-RAM works. > >> 3) CONFIG_SYSFB_SIMPLEFB=y and CONFIG_FB_SIMPLE=y > > /proc/fb: > 0 amdgpu > 1 simple > > dmesg: https://pastebin.com/ZSXnpLqQ > > Suspend-to-RAM fails. > >> >> And for each check /proc/fb, the kernel boot log, and if Suspend-to-RAM works. >> >> If the explanation above is correct, then I would expect (1) and (2) to work and >> (3) to also fail. >> Your testing confirms my assumptions. I'll check how this could be solved to prevent the efifb driver to be probed if there's already a framebuffer device. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat