From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: linux-pm@vger.kernel.org, lenb@kernel.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cpufreq: intel_pstate: Fix compilation for !CONFIG_ACPI
Date: Tue, 23 Oct 2018 14:52:12 -0700 [thread overview]
Message-ID: <af0dac7535332ecedeab9f04654fbb1d5a21e1a2.camel@linux.intel.com> (raw)
In-Reply-To: <20181023195403.GA3094@light.dominikbrodowski.net>
On Tue, 2018-10-23 at 21:54 +0200, Dominik Brodowski wrote:
> While at it, add a few comments which config options #ifdef
> and #else statements refer to.
>
> Fixes: 86d333a8cc7f ("cpufreq: intel_pstate: Add base_frequency
> attribute")
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 49c0abf2d48f..9578312e43f2 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -386,16 +386,11 @@ static int intel_pstate_get_cppc_guranteed(int
> cpu)
> return cppc_perf.guaranteed_perf;
> }
>
> -#else
> +#else /* CONFIG_ACPI_CPPC_LIB */
> static void intel_pstate_set_itmt_prio(int cpu)
> {
> }
> -
> -static int intel_pstate_get_cppc_guranteed(int cpu)
> -{
> - return -ENOTSUPP;
> -}
> -#endif
> +#endif /* CONFIG_ACPI_CPPC_LIB */
>
> static void intel_pstate_init_acpi_perf_limits(struct cpufreq_policy
> *policy)
> {
> @@ -477,7 +472,7 @@ static void intel_pstate_exit_perf_limits(struct
> cpufreq_policy *policy)
>
> acpi_processor_unregister_performance(policy->cpu);
> }
> -#else
> +#else /* CONFIG_ACPI */
> static inline void intel_pstate_init_acpi_perf_limits(struct
> cpufreq_policy *policy)
> {
> }
> @@ -490,7 +485,14 @@ static inline bool
> intel_pstate_acpi_pm_profile_server(void)
> {
> return false;
> }
> -#endif
> +#endif /* CONFIG_ACPI */
> +
> +#ifndef CONFIG_ACPI_CPPC_LIB
> +static int intel_pstate_get_cppc_guranteed(int cpu)
> +{
> + return -ENOTSUPP;
> +}
> +#endif /* CONFIG_ACPI_CPPC_LIB */
>
> static inline void update_turbo_state(void)
> {
next prev parent reply other threads:[~2018-10-23 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 18:54 [PATCH] cpufreq: intel_pstate: Fix compilation for !CONFIG_ACPI Dominik Brodowski
2018-10-23 19:17 ` Srinivas Pandruvada
2018-10-23 19:34 ` Dominik Brodowski
2018-10-23 19:36 ` Srinivas Pandruvada
2018-10-23 19:54 ` [PATCH v2] " Dominik Brodowski
2018-10-23 21:52 ` Srinivas Pandruvada [this message]
2018-10-26 9:24 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af0dac7535332ecedeab9f04654fbb1d5a21e1a2.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).