* your patch "intel_idle: add core C6 optimization for SPR"
@ 2022-04-26 9:35 Jan Beulich
2022-04-26 10:22 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2022-04-26 9:35 UTC (permalink / raw)
To: Artem Bityutskiy; +Cc: linux-pm@vger.kernel.org
Artem,
somewhat similarly to the C1E patch, while porting this one to our
driver clone in Xen I've noticed that the code added here would not
be reached in case the user specified a conflicting C1E-related
command line option (which ought to be unrelated to C6 handling).
In my port of the patch I've converted to
/* Check if user prefers C1E over C1. */
if (preferred_states_mask & BIT(2, U) &&
/* Both can't be enabled, stick to the defaults. */
!(preferred_states_mask & BIT(1, U))) {
...
}
Jan
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: your patch "intel_idle: add core C6 optimization for SPR"
2022-04-26 9:35 your patch "intel_idle: add core C6 optimization for SPR" Jan Beulich
@ 2022-04-26 10:22 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2022-04-26 10:22 UTC (permalink / raw)
To: Jan Beulich; +Cc: linux-pm@vger.kernel.org
On Tue, 2022-04-26 at 11:35 +0200, Jan Beulich wrote:
> Artem,
>
> somewhat similarly to the C1E patch, while porting this one to our
> driver clone in Xen I've noticed that the code added here would not
> be reached in case the user specified a conflicting C1E-related
> command line option (which ought to be unrelated to C6 handling).
> In my port of the patch I've converted to
>
> /* Check if user prefers C1E over C1. */
> if (preferred_states_mask & BIT(2, U) &&
> /* Both can't be enabled, stick to the defaults. */
> !(preferred_states_mask & BIT(1, U))) {
> ...
> }
Hi, ack, I'll send a fix for this too.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-26 10:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-26 9:35 your patch "intel_idle: add core C6 optimization for SPR" Jan Beulich
2022-04-26 10:22 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).