Re: [PATCH v3 8/8] arm64: dts: qcom: x1e80100-crd: Add charge limit nvmem

Fenglin Wu
2025-09-05T01:04:01Z

On 9/3/2025 4:41 PM, Maud Spierings wrote:
> Hi Fenglin,
>
>> Add nvmem cells for getting charge control thresholds if they have
>> been set previously.
>>
>> Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/x1-crd.dtsi         |  2 ++
>>  arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 20 ++++++++++++++++++++
>>  2 files changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi
>> b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
>> index
>> c9f0d505267081af66b0973fe6c1e33832a2c86b..8c3d30dd936ef9b12867971f5f237dd12484072d
>> 100644
>> --- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
>> @@ -82,6 +82,8 @@ pmic-glink {
>>                      <&tlmm 123 GPIO_ACTIVE_HIGH>,
>>                      <&tlmm 125 GPIO_ACTIVE_HIGH>;
>>
>> +        nvmem-cells = <&charge_limit_en>, <&charge_limit_end>,
>> <&charge_limit_delta>;
>> +        nvmem-cell-names = "charge_limit_en", "charge_limit_end",
>> "charge_limit_delta";
>>          /* Left-side rear port */
>>          connector@0 {
>>              compatible = "usb-c-connector";
>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
>> b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
>> index
>> c02fd4d15c9649c222caaafa5ed2c777a10fb4f5..abf7afe5127d7b8b572513234e00009ce837837d
>> 100644
>> --- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
>> @@ -239,6 +239,26 @@ reboot_reason: reboot-reason@48 {
>>              };
>>          };
>>
>> +        pmk8550_sdam_15: nvram@7e00 {
>> +            compatible = "qcom,spmi-sdam";
>> +            reg = <0x7e00>;
>> +            #address-cells = <1>;
>> +            #size-cells = <1>;
>> +            ranges = <0 0x7e00 0x100>;
>> +
>> +            charge_limit_en: charge-limit-en@73 {
>> +                reg = <0x73 0x1>;
>> +            };
>> +
>> +            charge_limit_end: charge-limit-end@75 {
>> +                reg = <0x75 0x1>;
>> +            };
>> +
>> +            charge_limit_delta: charge-limit-delta@75 {
>
> I think this is supposed to be @76 given the reg property below and
> the other ones above.

Thanks for catching it. I will address it in next patch.

>
>> +                reg = <0x76 0x1>;
>> +            };
>> +        };
>> +
>>          pmk8550_gpios: gpio@8800 {
>>              compatible = "qcom,pmk8550-gpio", "qcom,spmi-gpio";
>>              reg = <0xb800>;
>>
>> --
>> 2.34.1
>
> Kind regards,
> Maud