Linux Power Management development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Jishnu Prakash" <jishnu.prakash@oss.qualcomm.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Amit Kucheria" <amitk@kernel.org>,
	"Thara Gopinath" <thara.gopinath@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@kernel.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Lukasz Luba" <lukasz.luba@arm.com>,
	linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	"Kamal Wadhwa" <kamal.wadhwa@oss.qualcomm.com>,
	"David Collins" <david.collins@oss.qualcomm.com>,
	"Anjelique Melendez" <anjelique.melendez@oss.qualcomm.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Stephan Gerhold" <stephan.gerhold@linaro.org>
Subject: Re: [PATCH v2 1/2] iio: adc: qcom-spmi-adc5-gen3: Share SDAM0 IRQ with ADC_TM auxiliary driver
Date: Thu, 4 Jun 2026 17:44:02 +0300	[thread overview]
Message-ID: <aiGPMqHcz_AkUezI@ashevche-desk.local> (raw)
In-Reply-To: <20260604114630.23ca427a@jic23-huawei>

On Thu, Jun 04, 2026 at 11:46:30AM +0100, Jonathan Cameron wrote:
> On Wed, 3 Jun 2026 02:35:20 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > On Tue, May 26, 2026 at 04:26:09PM +0530, Jishnu Prakash wrote:

...

> > > +	ret = devm_request_threaded_irq(dev, adc->dev_data.base[ADC5_GEN3_VADC_SDAM].irq,
> > > +					NULL, adc5_gen3_isr, IRQF_ONESHOT | IRQF_SHARED,
> > > +					adc->dev_data.base[ADC5_GEN3_VADC_SDAM].irq_name,
> > > +					adc);
> > >  	if (ret)
> > >  		return dev_err_probe(dev, ret,
> > >  				     "Failed to request SDAM%d irq\n",  
> > 
> > Also add a patch to drop this duplicate message.
> 
> There is another thread going on this.  It might not be duplicate
> if -EPROBE_DEFER is returned.  The message won't be printed but it
> will be logged for helping debug deferred probe reasons.

Yes, and I explained that it is duplicated as long as I understand current
code base.

> So maybe we have been a little too energetic in removing these.

Or maybe sashiko consumed a bit of LSD :-)

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-06-04 14:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 10:56 [PATCH v2 0/2] thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring Jishnu Prakash
2026-05-26 10:56 ` [PATCH v2 1/2] iio: adc: qcom-spmi-adc5-gen3: Share SDAM0 IRQ with ADC_TM auxiliary driver Jishnu Prakash
2026-05-26 13:12   ` Daniel Lezcano
2026-05-27 11:26     ` Jonathan Cameron
2026-05-27 11:29   ` Jonathan Cameron
2026-06-02 23:35   ` Andy Shevchenko
2026-06-04 10:46     ` Jonathan Cameron
2026-06-04 14:44       ` Andy Shevchenko [this message]
2026-05-26 10:56 ` [PATCH v2 2/2] thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring Jishnu Prakash
2026-05-27 11:42   ` Jonathan Cameron
2026-06-02 23:44   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiGPMqHcz_AkUezI@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=amitk@kernel.org \
    --cc=andy@kernel.org \
    --cc=anjelique.melendez@oss.qualcomm.com \
    --cc=daniel.lezcano@kernel.org \
    --cc=david.collins@oss.qualcomm.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=nuno.sa@analog.com \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=stephan.gerhold@linaro.org \
    --cc=thara.gopinath@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox