Linux Power Management development
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-hwmon@vger.kernel.org, linux-pm@vger.kernel.org,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Guenter Roeck <linux@roeck-us.net>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [PATCH 5/8] x86/msr: Switch rdmsr_safe_on_cpu() to return a 64-bit quantity
Date: Fri, 5 Jun 2026 10:51:28 +0200	[thread overview]
Message-ID: <aiKOEDblINFcKZzu@gmail.com> (raw)
In-Reply-To: <aiKMytZNGHj0epSn@gmail.com>


* Ingo Molnar <mingo@kernel.org> wrote:

> 
> * Juergen Gross <jgross@suse.com> wrote:
> 
> > In order to prepare retiring rdmsrq_safe_on_cpu() switch
> > rdmsr_safe_on_cpu() to have the same interface as rdmsrq_safe_on_cpu().
> 
> Patch #1.

Note that to do this, a new name should be introduced,
such as rdmsrq_safe_on_cpu() or so. This principle applies
to the other patches as well.

Ie. since we are changing the function signature anyway,
do not keep 32-bit API names, and introduce the new ones
cleanly in 3 patches:

  - introduce rdmsrq_safe_on_cpu()
  - change users from rdmsr_safe_on_cpu() => rdmsrq_safe_on_cpu()
  - remove obsolete rdmsr_safe_on_cpu()

This will make it easier to bisect any breakages, and will
make it easier to transition the APIs.

Thanks,

	Ingo

  reply	other threads:[~2026-06-05  8:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-05  7:08 [PATCH 0/8] x86/msr: Drop 32-bit variants of *_on_cpu() MSR functions Juergen Gross
2026-06-05  7:08 ` [PATCH 1/8] x86/msr: Switch rdmsr_on_cpu() to return a 64-bit quantity Juergen Gross
2026-06-05  7:08 ` [PATCH 2/8] x86/msr: Switch all callers of rdmsrq_on_cpu() to use rdmsr_on_cpu() Juergen Gross
2026-06-05  9:00   ` Ingo Molnar
2026-06-05  7:08 ` [PATCH 3/8] x86/msr: Switch wrmsr_on_cpu() to use a 64-bit quantity Juergen Gross
2026-06-05  7:08 ` [PATCH 4/8] x86/msr: Switch all callers of wrmsrq_on_cpu() to use wrmsr_on_cpu() Juergen Gross
2026-06-05  8:46   ` Ingo Molnar
2026-06-05  9:02     ` Ingo Molnar
2026-06-05  7:08 ` [PATCH 5/8] x86/msr: Switch rdmsr_safe_on_cpu() to return a 64-bit quantity Juergen Gross
2026-06-05  8:46   ` Ingo Molnar
2026-06-05  8:51     ` Ingo Molnar [this message]
2026-06-05  8:55       ` Ingo Molnar
2026-06-05  7:08 ` [PATCH 6/8] x86/msr: Switch all callers of rdmsrq_safe_on_cpu() to use rdmsr_safe_on_cpu() Juergen Gross
2026-06-05  8:45   ` Ingo Molnar
2026-06-05  7:08 ` [PATCH 7/8] x86/msr: Switch wrmsr_safe_on_cpu() to use a 64-bit quantity Juergen Gross
2026-06-05  8:44   ` Ingo Molnar
2026-06-05  7:08 ` [PATCH 8/8] x86/msr: Switch all callers of wrmsrq_safe_on_cpu() to use wrmsr_safe_on_cpu() Juergen Gross
2026-06-05  8:43   ` Ingo Molnar
2026-06-05  8:56     ` Ingo Molnar
2026-06-05  9:05 ` [PATCH 0/8] x86/msr: Drop 32-bit variants of *_on_cpu() MSR functions Ingo Molnar
2026-06-05  9:13   ` Jürgen Groß
2026-06-05  9:18     ` Ingo Molnar
2026-06-05  9:40       ` Jürgen Groß
2026-06-05  9:54         ` Ingo Molnar
2026-06-05  9:56           ` Ingo Molnar
2026-06-05 10:05             ` Jürgen Groß
2026-06-05 10:06             ` Jürgen Groß

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiKOEDblINFcKZzu@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=daniel.lezcano@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lukasz.luba@arm.com \
    --cc=mingo@redhat.com \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox