From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2FE2425CD8 for ; Mon, 29 Jun 2026 15:31:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782747082; cv=none; b=qbKvHYOHR6d+QFUxuu6MnBrf5vg1YjgjSBwiYNmN1RfhGs7E90Jm5l0/IPaZbNCGu4MtaAszIUaw6UAGzkDhcvwNTEB0ukWZnyhNpX7KzJSTdvqOkdqvW/DkZ4NJ8x4g6/fohft/2er58d7vYDmTfxQibkihWt8yXOdLI9K5vQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782747082; c=relaxed/simple; bh=TelLuQFVj84dg15intj6l6XA0Pbbdt2xzy2TuA9iVP0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H5vj6frT57xxSvJHhGFKnERzY0tsyzeYCw5hbPBprvtql7VdSTw1lxcu8XDjFI4BDTo4PvmA6xlLgyZJDXBeQjBV9eIouVUi8pL2aHyBPPmYaYFjKze2pXs3J3UzLsMpxXO4JLj7E5cYgs5gXs6b4VEh3oviybDKcLYs8Mrq/c8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ik0Ruwgq; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=SdenFFPp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ik0Ruwgq"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="SdenFFPp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782747080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DOCP00x0YVfBobkqwjRQEWaP9evLVGD2m07PpA2VUgw=; b=Ik0RuwgqjZYLZ/b3nsdlt8Gj4H83eWkX6udgvQO+bYEjpdDpKj0lZ8OfJ2qans8Y4l9DgZ XfiDwDMJ8Mh5NB2+S0LB3zwrjNkqGQqWWVqkn1uSxSBOKiXOeqc4O6Sm+T0PhCr6HV6aDd gh7U/Ji7sDqlcxgGBRlJwPPcTu0fJ2M= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-bd0eFv3ZP-uAcMHODmcpsQ-1; Mon, 29 Jun 2026 11:31:17 -0400 X-MC-Unique: bd0eFv3ZP-uAcMHODmcpsQ-1 X-Mimecast-MFC-AGG-ID: bd0eFv3ZP-uAcMHODmcpsQ_1782747077 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51a1460e3d3so28691751cf.0 for ; Mon, 29 Jun 2026 08:31:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782747077; x=1783351877; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DOCP00x0YVfBobkqwjRQEWaP9evLVGD2m07PpA2VUgw=; b=SdenFFPp+cQRnEp88s1emS9I3yjI6QV01f6URp6idw70huaWHF+au8ZcdU3NS6JGGa TEHqaJ7y4ry9YdRKFBixS59xX2r8EVQPsYIP6+cmxhehxlD8fa/0PjPH89BFKyO+iLNX i58taShtozF95CGTzwvMQ6JgjAwCVrKPLG0/RB51JkSFysuGvWvo6Po0hD0xJL0U6/P5 j74UA0aWu0lvfzplZjO/44kfvuW9hEHpUH6TPIAH9iFYlVvGYe2w7dX08cOfDnmzOvqN R8Jt0XmL4sFk45mW1gKHiyO5faDKc2xYecaA7ynfIQr3QoyO7mI6IFqiaZG3Pee7FzNm daqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782747077; x=1783351877; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DOCP00x0YVfBobkqwjRQEWaP9evLVGD2m07PpA2VUgw=; b=NU+O05wRa3ADoFHFKIAHs7CoWbNYNSHU2EhGBKRwRiJqEcO1yOiPIUh0+ljgFnai6K UiFhYUOwngVaicomMqQNldQNQh/DhKolUQuRedzBMuLHi0o/B+pSYWwtOld9JDTvDWAy CvQT73XUGjQ6rVTgtlxewmK2QrYMt5LxzUZDxZzocwrGLYtrEd1yGqZbGRHdBX1/Zd1c s7V+UK6LMRSAD4dvOYuo+gWVlezkvYl9hvhYw2vI+nPjXybXwk1qeOPWKmyvCX74HCIM su33zqy7Fj8ZDe7EFE8Jk0gTO+bOBZb7K3EvgkR5JoPpNOOsN/+5p5RTPTeWRJMz4n26 73nQ== X-Forwarded-Encrypted: i=1; AFNElJ+6cCCgAH8xskI8TZSrhfmeE+9cwItDOQ4x07xsydB7l10ZiSCmDcuZnFEJX737MkU80710E9KySw==@vger.kernel.org X-Gm-Message-State: AOJu0YyBQ0Jyg/D3K1b7sSsiWdK9kpzyfhukvyu8LdbyYM/iplKRAqpz AjNZaL+dZMrrg/Q8yjGtLZ82wmxZxKf98w2j6UeHZMWdYU/iMdhM4tIJwIQ8Kit2Jiwzgbru8WY l3KunildA9a8SLF2eVwm3X9gZxi1sjrUxojRms3YESORomUiA/sCVBxbRWOph X-Gm-Gg: AfdE7clV1EnE2PFHMjpyW+9J7G7zjihj2ICWEEGFhdGVqSu6CkaBi5e4Ai+JwN4nQYT 9nkZFBRGmOOu1+kHswJmx+bgGQLZRsJJUkdyrXcdb5cGJKSuBl35L1zZd9B6O3IAf/wbRpHMfY/ 2DeQ5qCxXRe8RAmenoWp+/oPktPVwOQWWmFJ6BUigp5H8+pjn3ZkiIeTPF703gCrFaVIjNI9caz 5TGlnmM0C87Wmk+wjjf63D4zig63GS6nbH544nh0SlnzsPER/oO9q2suB7Ub+0yBUrw/K8vm3Ps +Q19ylAf5G4gKeNIScaq8Y0qxXzLL4oZ4Ty8s5V8NMDf5W+Fb07y5MugTs1RbBQZiqDTL9nWbcF Ny4Td8TvK6jUGitWRWDce91WGg/ZyOAoaJzMeiqAPZsOo3g== X-Received: by 2002:a05:622a:8d05:b0:51b:f635:9aa9 with SMTP id d75a77b69052e-51bf6359ebamr61940811cf.35.1782747077202; Mon, 29 Jun 2026 08:31:17 -0700 (PDT) X-Received: by 2002:a05:622a:8d05:b0:51b:f635:9aa9 with SMTP id d75a77b69052e-51bf6359ebamr61940241cf.35.1782747076630; Mon, 29 Jun 2026 08:31:16 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51bf0697775sm45079741cf.26.2026.06.29.08.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 08:31:15 -0700 (PDT) Date: Mon, 29 Jun 2026 11:31:14 -0400 From: Brian Masney To: Konrad Dybcio Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Ulf Hansson , Bjorn Andersson , Michael Turquette , Stephen Boyd , Russell King , Neil Armstrong , Xuyang Dong , Jens Glathe , Hans de Goede , Maxime Ripard , Saravana Kannan , Abel Vesa , driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 1/4] driver: core: introduce dev_add_sync_state() Message-ID: References: <20260626-clk-sync-state-v1-0-4156d8196dc8@redhat.com> <20260626-clk-sync-state-v1-1-4156d8196dc8@redhat.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.3.2 (2026-04-26) On Mon, Jun 29, 2026 at 12:11:18PM +0200, Konrad Dybcio wrote: > On 6/26/26 6:32 PM, Brian Masney wrote: > > We have cases where a device node represents a provider for multiple > > types of resources, like clocks, power-domains, resets, etc. We > > currently have dev_set_drv_sync_state() where a framework or driver > > can set the sync_state callback for a device node, however it currently > > only supports a single sync_state callback. > > > > The pmdomain subsystem currently sets up a sync_state callback in the > > core framework, and the clk subsystem will setup it's own separate > > sync_state callback in the core framework. These can collide with each > > other on some types of devices that have multiple types of resources. > > Additionally, some clk drivers already have their own separate > > sync_state callback already defined. > > > > Let's introduce support for allowing drivers and frameworks to add their > > own sync_state callback via a new function dev_add_sync_state() so that > > multiple sync_state callbacks can coexist. > > > > Link: https://lore.kernel.org/linux-clk/CAPx+jO9JiV16ePLk59hTQzEMnA96Va6Ns4jqJbwyZ6oTT0AjXA@mail.gmail.com/ > > Signed-off-by: Brian Masney > > Assisted-by: Claude:claude-opus-4-6 > > --- > > [...] > > > +int dev_add_sync_state(struct device *dev, > > + void (*fn)(struct device *dev)) > > +{ > > + struct sync_state_entry *entry; > > + > > + if (!dev || !dev->driver) > > + return 0; > > + > > + list_for_each_entry(entry, &dev->sync_state_list, node) > > + if (entry->fn == fn) > > + return 0; > > Do we expect this to be a valid call, i.e. should we WARN_ON here? That's a good point about adding a WARN_ON() here. I kept this logic from when I converted from dev_set_drv_sync_state(). Brian