Linux Power Management development
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>,
	Deepak Sikri <deepak.sikri@st.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] cpufreq: Fix an IS_ERR() vs NULL bug in spear1340_set_cpu_rate()
Date: Mon, 13 Jul 2026 10:56:32 +0300	[thread overview]
Message-ID: <alSaMG3ZNOFJz08F@stanley.mountain> (raw)
In-Reply-To: <sejbfcic3gey5p4uxgituyizdttimxhlrl4kwer27b4g7j5i6o@yvjnioeplypl>

On Mon, Jul 13, 2026 at 09:31:12AM +0530, Viresh Kumar wrote:
> On 12-07-26, 21:30, Zhongqiu Han wrote:
> > On 7/11/2026 3:34 AM, Dan Carpenter wrote:
> > > The clk_get_parent() function doesn't return error pointers, it returns
> > > NULL on error.  Update the error checking to match.
> 
> origin/master:include/linux/clk.h
> 
> /**
>  * clk_get_parent - get the parent clock source for this clock
>  * @clk: clock source
>  *
>  * Returns struct clk corresponding to parent clock source, or
>  * valid IS_ERR() condition containing errno.
>  */
> struct clk *clk_get_parent(struct clk *clk);
> 
> I think this is the source of the confusion.
> 

I'll send a separate patch to update that documentation.

regards,
dan carpenter


  reply	other threads:[~2026-07-13  7:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 19:34 [PATCH] cpufreq: Fix an IS_ERR() vs NULL bug in spear1340_set_cpu_rate() Dan Carpenter
2026-07-12 13:30 ` Zhongqiu Han
2026-07-13  4:01   ` Viresh Kumar
2026-07-13  7:56     ` Dan Carpenter [this message]
2026-07-13  7:45   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alSaMG3ZNOFJz08F@stanley.mountain \
    --to=error27@gmail.com \
    --cc=deepak.sikri@st.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=zhongqiu.han@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox