From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Danilo Krummrich <dakr@kernel.org>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Pavel Machek <pavel@kernel.org>, Len Brown <lenb@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, driver-core@lists.linux.dev,
tfiga@chromium.org, senozhatsky@chromium.org,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v6 0/2] PM: dpm_watchdog: Improve DPM watchdog configurability
Date: Wed, 15 Jul 2026 03:38:17 +0000 [thread overview]
Message-ID: <alcAqfM9mgAVXVWD@google.com> (raw)
In-Reply-To: <20260708043317.2980098-1-tzungbi@kernel.org>
On Wed, Jul 08, 2026 at 04:33:15AM +0000, Tzung-Bi Shih wrote:
> This series improves the configurability of the DPM watchdog.
>
> Currently, the DPM watchdog is always enabled if compiled in. Also, the
> module parameters defined in drivers/base/power/main.c use the generic
> and non-descriptive "main" prefix.
>
> This series addresses these limitations.
>
> Patch 1 renames the module parameter prefix for
> drivers/base/power/main.c from "main" to "pm".
>
> Patch 2 introduces the "dpm_watchdog_enabled" module parameter to allow
> enabling/disabling the watchdog at boot time and runtime. It also adds
> CONFIG_DPM_WATCHDOG_ENABLED to set the default value of the module
> parameter at compile time.
>
> The primary motivation for this configurability revolves around Android
> GKI (Generic Kernel Image). We want to enable CONFIG_DPM_WATCHDOG in
> the GKI so the feature is available. However, because the GKI is shared
> across many different devices, we don't want to inadvertently affect
> devices that are unaware of this feature. This provides a way to
> compile it in, but keep it disabled by default for those devices via the
> kernel command line or module parameters.
>
> To maintain backward compatibility, CONFIG_DPM_WATCHDOG_ENABLED relies
> on `default y`. Previously, the DPM watchdog was always active if
> CONFIG_DPM_WATCHDOG was set. Defaulting this new option to 'y' ensures
> that the behavior remains unchanged for existing users and defconfigs
> when they upgrade.
> ---
> v6:
> - Change the prefix "pm_sleep" -> "pm".
>
> v5: https://lore.kernel.org/all/20260701045640.3130090-1-tzungbi@kernel.org
> - Rebase to v7.2-rc1.
> - Fix Signed-off-by lines.
Since there was no further feedback on v5, I'm sending out v6. Any feedback
would be appreciated.
prev parent reply other threads:[~2026-07-15 3:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 4:33 [PATCH v6 0/2] PM: dpm_watchdog: Improve DPM watchdog configurability Tzung-Bi Shih
2026-07-08 4:33 ` [PATCH v6 1/2] PM: sleep: Rename module parameters prefix to "pm" Tzung-Bi Shih
2026-07-08 4:33 ` [PATCH v6 2/2] PM: dpm_watchdog: Allow disabling DPM watchdog by default Tzung-Bi Shih
2026-07-15 3:38 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alcAqfM9mgAVXVWD@google.com \
--to=tzungbi@kernel.org \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=senozhatsky@chromium.org \
--cc=skhan@linuxfoundation.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox