From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5948429006; Wed, 15 Jul 2026 09:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784107755; cv=none; b=YMYDFrLc1P6X21Hjw6nbZFqKhvdNOu36IxlEAvSSVEj2HQtec1GOA8jIrLUXcUcmXdwaBk9OxFz4ZULTD7MZwzE+cEiJwohMwrlZ7eo96hXQLpiKZk+a9vH/owjjquh8002hty1y8lWo/MVbBlztbMUASD2U/oL1MXLG9wR68AI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784107755; c=relaxed/simple; bh=/5aaAsVdQN0eiTG/66eGgXteBugptKLohzhJXhN02NU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DpjGgpLsInM/7zmRvvQQjpV/zGU4oqLZ8F/NJZKDP4sExz/zmATB6n4xJRKaIjhBTKNbUrK/7B9+QOPsNFy9DRfI68po+wndnFMVvcNbzi+qQYIV7tY99FA2PSnWF+OwNnSr0v743OY+O9XhCIk6XTvacxlj97cz8aBjPnMAq88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lr3UcYcz; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lr3UcYcz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784107752; x=1815643752; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/5aaAsVdQN0eiTG/66eGgXteBugptKLohzhJXhN02NU=; b=lr3UcYcz4piKTkgWcfRSw+N505oDKBfRlpuzCVH9m7xgiEamJUN3LgOu l/OZNxsF83iOYk9IbalKowM42IaWtKoukijhkOjA4+C1ZOmhzVRMXUdP8 Q0UktH8jpcTDLeGNVMpIsoeJhuEhZ92D9sSDbdohjnJWnJPZXT/1n1jlV pbViCuKrslDF87Bxq8EGa9W97Jt0F4113o9rwEaa695x2S4TXmrBjNwgd Qqy6cwBNdtDwzvAO+untd9kXF7ChitATDLA8yLx4re2/wyvwKsz+X7qSL H9AhGY3NBwv126m++zVdv4BtNuKeexevKl7dMFZDpYLDlbYNx6Cijnmi1 g==; X-CSE-ConnectionGUID: nLJ98HiFSg6CU1WTQ/7Zbg== X-CSE-MsgGUID: FuFLhJdoS9GIgqRj1o4ieA== X-IronPort-AV: E=McAfee;i="6800,10657,11847"; a="84830136" X-IronPort-AV: E=Sophos;i="6.25,165,1779174000"; d="scan'208";a="84830136" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2026 02:29:10 -0700 X-CSE-ConnectionGUID: t3nl7JS5TxCiXiLKm/nhqQ== X-CSE-MsgGUID: BfWSW46GSw+l5U7M4cVNLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,165,1779174000"; d="scan'208";a="286203001" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.129]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2026 02:29:05 -0700 Date: Wed, 15 Jul 2026 12:29:02 +0300 From: Andy Shevchenko To: Chen-Yu Tsai Cc: Bartosz Golaszewski , Greg Kroah-Hartman , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wei Deng , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: Re: [PATCH v5 03/16] power: sequencing: Add pwrseq_power_is_on() Message-ID: References: <20260715085348.3457359-1-wenst@chromium.org> <20260715085348.3457359-4-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260715085348.3457359-4-wenst@chromium.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Jul 15, 2026 at 04:53:33PM +0800, Chen-Yu Tsai wrote: > The power sequencing consumer API already does power on state tracking > internally. Expose the state to consumers through pwrseq_power_is_on() > so that they don't have to reimplement it locally. Reviewed-by: Andy Shevchenko ... > +/** > + * pwrseq_power_is_on() - Queries the last requested state of the power sequencer. > + * @desc: Descriptor referencing the power sequencer. > + * > + * This returns the last requested state of the power sequencer. > + * > + * Returns: > + * On success, 1 for on or desc is NULL (optional) and 0 for off; > + * negative error number on failure. I would rephrase it a bit. * On success, 1 for on and 0 for off; negative error number on failure. * If desc is NULL (means optional) return 1. And this rises a question: why 1? Shouldn't it be some "unknown" state? (But since Bart Acked this, this doesn't prevent the patch to go, you got my tag above.) > + */ -- With Best Regards, Andy Shevchenko