From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: [PATCH] PM / OPP: fix odd_ptr_err.cocci warnings Date: Fri, 2 Dec 2016 16:13:33 +0100 (CET) Message-ID: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:58917 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753350AbcLBPTA (ORCPT ); Fri, 2 Dec 2016 10:19:00 -0500 Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: philip.li@intel.com, Viresh Kumar Cc: linux-pm@vger.kernel.org, kbuild-all@01.org PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- I haven't checked the context, but the code looks suspicious. This is derived from the following tree: tree: https://git.linaro.org/people/vireshk/linux opp/redesign head: fbf8f0c337a7cfcd4cb67865b5ea710e69c21f1f commit: 5fe43a6b46470d22938bc443cf0ea20ed01a93b6 [32/33] PM / OPP: Take kref from _find_opp_table() :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -644,7 +644,7 @@ int dev_pm_opp_set_rate(struct device *d if (IS_ERR(clk)) { dev_err(dev, "%s: No clock available for the device\n", __func__); - ret = PTR_ERR(opp_table); + ret = PTR_ERR(clk); goto put_opp_table; }