Linux Power Management development
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Alexandra Yates <alexandra.yates@linux.intel.com>,
	kristen.c.accardi@intel.com, linux-pm@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] Report interrupt(s) that caused system wakeup
Date: Tue, 18 Aug 2015 14:56:57 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1508181454230.3873@nanos> (raw)
In-Reply-To: <2470788.QaFQb9rj3y@vostro.rjw.lan>

On Tue, 18 Aug 2015, Rafael J. Wysocki wrote:
> The original point was that if two wakeup interrupts happened at the same time,
> it would be kind of moot which one was the "real" wakeup, but now that I think
> about it, reporting the first one should be enough to catch suprious wakeups
> anyway.

So we can simply do the following:

diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index d22786a6dbde..46068a1e0e07 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -21,7 +21,7 @@ bool irq_pm_check_wakeup(struct irq_desc *desc)
 		desc->istate |= IRQS_SUSPENDED | IRQS_PENDING;
 		desc->depth++;
 		irq_disable(desc);
-		pm_system_wakeup();
+		pm_system_irq_wakeup(irq_desc_get_irq(desc));
 		return true;
 	}
 	return false;

and manage the storage in the PM code.

Thanks,

	tglx

  reply	other threads:[~2015-08-18 12:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[PATCH V5] Report interrupt(s) that caused a system wakeup>
2015-08-07  3:47 ` [PATCH v5] Report interrupt(s) that caused system wakeup* Alexandra Yates
2015-08-07  3:47   ` [PATCH v5] Report interrupt(s) that caused system wakeup Alexandra Yates
2015-08-07 22:37     ` Rafael J. Wysocki
2015-08-17 20:59       ` Thomas Gleixner
2015-08-17 23:17         ` Rafael J. Wysocki
2015-08-18 12:56           ` Thomas Gleixner [this message]
2015-08-18 15:53             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1508181454230.3873@nanos \
    --to=tglx@linutronix.de \
    --cc=alexandra.yates@linux.intel.com \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox