From: Thomas Gleixner <tglx@linutronix.de>
To: Lianwei Wang <lianwei.wang@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
oleg@redhat.com, Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpu/hotplug: handle unbalanced hotplug enable/disable
Date: Mon, 25 Apr 2016 10:22:59 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1604251018090.3941@nanos> (raw)
In-Reply-To: <CAJFUiJg61i16JdC4LiQOXmD9Rrg8VDf7BEWs124dFTkbd4Rg-g@mail.gmail.com>
On Fri, 22 Apr 2016, Lianwei Wang wrote:
> Any way is Ok for debugging purpose. But think the kernel run on a
> customer machine, such as PC, Mobile phone or other devices. How we
> let the customer debug it but not recover it smartly?
There is nothing smart here. Restoring the count is a bandaid and has nothing
to do with recovery. If that WARN_ON triggers then other stuff is going to be
more fundamentally wrong so restoring the count is the least of our worries.
> Anyway, from a product perspective way, if we don't want to restore
> the unbalanced counter to 0, then maybe a BUG_ON is more reasonable
> than WARN_ON.
Not at all. BUG_ON is the last resort if we have no other way to handle an
issue.
Thanks,
tglx
next prev parent reply other threads:[~2016-04-25 8:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 4:56 [PATCH] cpu/hotplug: handle unbalanced hotplug enable/disable Lianwei Wang
2016-04-21 10:50 ` Peter Zijlstra
2016-04-22 16:32 ` Lianwei Wang
2016-04-22 16:37 ` Thomas Gleixner
2016-04-22 21:58 ` Lianwei Wang
2016-04-25 8:22 ` Thomas Gleixner [this message]
2016-04-26 6:58 ` Lianwei Wang
2016-04-27 10:17 ` Thomas Gleixner
2016-04-28 6:10 ` Lianwei Wang
2016-04-28 6:15 ` Thomas Gleixner
2016-04-28 17:25 ` Lianwei Wang
2016-04-29 0:44 ` Thomas Gleixner
2016-04-29 21:47 ` Lianwei Wang
2016-05-02 8:11 ` Thomas Gleixner
2016-05-04 7:23 ` Lianwei Wang
2016-05-05 12:13 ` Thomas Gleixner
2016-05-06 7:06 ` Lianwei Wang
2016-05-06 7:18 ` Thomas Gleixner
2016-05-12 8:06 ` Lianwei Wang
2016-06-07 5:38 ` Lianwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1604251018090.3941@nanos \
--to=tglx@linutronix.de \
--cc=lianwei.wang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox