From: Thomas Gleixner <tglx@linutronix.de>
To: Piotr Luc <piotr.luc@intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Doug Thompson <dougthompson@xmission.com>,
Borislav Petkov <bp@alien8.de>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
Len Brown <lenb@kernel.org>,
linux-pm@vger.kernel.org,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros
Date: Fri, 14 Oct 2016 13:56:36 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610141354090.11707@nanos> (raw)
In-Reply-To: <20161013153105.2517-3-piotr.luc@intel.com>
On Thu, 13 Oct 2016, Piotr Luc wrote:
> + case INTEL_FAM6_NEHALEM_EP: /* Core i7, Xeon 5500 series - Bloomfield, Gainstown NHM-EP */
What's the point of keeping all those comments around?
> + case INTEL_FAM6_SANDYBRIDGE: /* SNB */
Especialy those, which are completely useless?
The defines are there to be self explaining and the extra verbose
information should be in the header file defining the macros and not in the
source code.
Thanks,
tglx
next prev parent reply other threads:[~2016-10-14 11:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 15:30 [RESEND PATCH 00/11] Add Knights Mill CPU ID Piotr Luc
2016-10-13 15:30 ` [RESEND PATCH 01/11] EDAC, sb_edac: Use Intel family processor macros Piotr Luc
2016-10-13 22:01 ` Borislav Petkov
2016-10-13 15:30 ` [PATCH v2 02/11] tools/power turbostat: " Piotr Luc
2016-10-14 11:56 ` Thomas Gleixner [this message]
2016-10-24 13:15 ` Luc, Piotr
2016-10-13 15:30 ` [RESEND PATCH 03/11] x86/cpu/intel: Add Knights Mill to Intel family Piotr Luc
2016-10-13 15:30 ` [RESEND PATCH 04/11] x86/intel_idle: Add Knights Mill CPUID Piotr Luc
2016-10-25 10:36 ` [RESEND,04/11] " Luc, Piotr
2016-12-01 5:29 ` [RESEND PATCH 04/11] " Len Brown
2016-12-01 8:45 ` Luc, Piotr
2016-10-13 15:30 ` [RESEND PATCH 05/11] EDAC, sb_edac: " Piotr Luc
2016-10-13 22:04 ` Borislav Petkov
2016-10-19 10:38 ` Borislav Petkov
2016-10-13 15:31 ` [RESEND PATCH 06/11] cpufreq: intel_pstate: " Piotr Luc
2016-10-13 17:51 ` Srinivas Pandruvada
2016-10-25 10:48 ` Luc, Piotr
2016-10-25 11:16 ` Rafael J. Wysocki
2016-10-25 11:44 ` Luc, Piotr
2016-11-30 16:19 ` Luc, Piotr
2016-11-30 22:01 ` Rafael J. Wysocki
2016-11-30 22:16 ` Luc, Piotr
2016-10-13 15:31 ` [RESEND PATCH 07/11] perf/x86/intel: " Piotr Luc
2016-10-13 15:31 ` [RESEND PATCH 08/11] perf/x86/intel/rapl: " Piotr Luc
2016-10-13 15:31 ` [RESEND PATCH 09/11] perf/x86/intel/uncore: " Piotr Luc
2016-10-13 15:31 ` [RESEND PATCH 10/11] powercap / RAPL: " Piotr Luc
2016-10-25 10:41 ` [RESEND,10/11] " Luc, Piotr
2016-11-30 22:33 ` Luc, Piotr
2016-11-30 22:42 ` Rafael J. Wysocki
2016-10-13 15:31 ` [RESEND PATCH 11/11] tools/power turbostat: enable turbostat to support Knights Mill (KNM) Piotr Luc
2016-12-01 6:47 ` Len Brown
2016-12-01 11:17 ` Luc, Piotr
2016-10-13 21:56 ` [RESEND PATCH 00/11] Add Knights Mill CPU ID Rafael J. Wysocki
2016-10-24 16:13 ` Luc, Piotr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610141354090.11707@nanos \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=piotr.luc@intel.com \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox