From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
Eric Dumazet <edumazet@google.com>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org, Arjan van de Ven <arjan@infradead.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Rik van Riel <riel@redhat.com>,
Richard Cochran <rcochran@linutronix.de>
Subject: Re: [patch V2 05/10] timer: Retrieve next expiry of pinned/non-pinned timers seperately
Date: Wed, 19 Apr 2017 11:56:19 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1704191154200.1829@nanos> (raw)
In-Reply-To: <20170419070558.eq3rdqyesvstuq4r@hirez.programming.kicks-ass.net>
On Wed, 19 Apr 2017, Peter Zijlstra wrote:
> On Tue, Apr 18, 2017 at 01:11:07PM +0200, Thomas Gleixner wrote:
> > +
> > + /*
> > + * If the local queue expires first, there is no requirement for
> > + * queuing the CPU in the global expiry mechanism.
>
> The comment doesn't make sense... (maybe at this stage)
Yeah, it's only useful once the real magic is in place.
> > + */
> > + if (!local_first && !global_empty)
> > + *global_evt = basem + (nextevt_global - basej) * TICK_NSEC;
>
> I was initially thinking !local_first would have to imply !global_empty,
> but after going back and reading the previous patches again, I found
> this was not so. Still slightly surprising.
Indeed, that's confusing.
Thanks,
tglx
next prev parent reply other threads:[~2017-04-19 9:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 11:11 [patch V2 00/10] timer: Move from a push remote at enqueue to a pull at expiry model Thomas Gleixner
2017-04-18 11:11 ` [patch V2 01/10] timer: Invoke timer_start_debug() where it makes sense Thomas Gleixner
2017-04-18 11:11 ` [patch V2 02/10] timerqueue: Document return values of timerqueue_add/del() Thomas Gleixner
2017-04-18 11:11 ` [patch V2 03/10] timers: Rework idle logic Thomas Gleixner
2017-04-19 6:50 ` Peter Zijlstra
2017-04-21 14:43 ` Frederic Weisbecker
2017-04-18 11:11 ` [patch V2 04/10] timer: Keep the pinned timers separate from the others Thomas Gleixner
2017-04-18 11:11 ` [patch V2 05/10] timer: Retrieve next expiry of pinned/non-pinned timers seperately Thomas Gleixner
2017-04-19 7:05 ` Peter Zijlstra
2017-04-19 9:56 ` Thomas Gleixner [this message]
2017-04-18 11:11 ` [patch V2 06/10] timer: Restructure internal locking Thomas Gleixner
2017-04-19 7:07 ` Peter Zijlstra
2017-04-18 11:11 ` [patch V2 07/10] tick/sched: Split out jiffies update helper function Thomas Gleixner
2017-04-18 11:11 ` [patch V2 08/10] timer: Implement the hierarchical pull model Thomas Gleixner
2017-04-19 7:20 ` Peter Zijlstra
2017-04-19 7:24 ` Peter Zijlstra
2017-04-19 7:34 ` Peter Zijlstra
2017-04-19 7:38 ` Peter Zijlstra
2017-04-19 8:11 ` Peter Zijlstra
2017-04-19 8:31 ` Thomas Gleixner
2017-04-19 8:36 ` Peter Zijlstra
2017-04-19 9:03 ` Thomas Gleixner
2017-04-19 8:52 ` Peter Zijlstra
2017-04-19 9:09 ` Peter Zijlstra
2017-04-19 9:43 ` Thomas Gleixner
2017-04-19 9:52 ` Peter Zijlstra
2017-04-19 9:44 ` Peter Zijlstra
2017-04-19 9:53 ` Peter Zijlstra
2017-04-19 9:20 ` Peter Zijlstra
2017-04-19 10:22 ` Peter Zijlstra
2017-04-18 11:11 ` [patch V2 09/10] timer_migration: Add tracepoints Thomas Gleixner
2017-04-18 11:11 ` [patch V2 10/10] timer: Always queue timers on the local CPU Thomas Gleixner
2017-04-21 19:28 ` [patch V2 00/10] timer: Move from a push remote at enqueue to a pull at expiry model Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1704191154200.1829@nanos \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=arjan@infradead.org \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rcochran@linutronix.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox