From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: PM / wakeirq: Convert to SRCU Date: Sat, 24 Jun 2017 14:13:35 +0200 (CEST) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: "Paul E. McKenney" , Brian Norris , Heiko Stuebner , Linus Walleij , linux-rockchip@lists.infradead.org, Julia Cartwright , LKML , linux-gpio@vger.kernel.org, John Keeping , Linux PM , Doug Anderson , Peter Zijlstra , Tony Lindgren , "Rafael J. Wysocki" List-Id: linux-pm@vger.kernel.org On Sat, 24 Jun 2017, Rafael J. Wysocki wrote: > On Sat, Jun 24, 2017 at 11:56 AM, Thomas Gleixner wrote: > > The wakeirq infrastructure uses RCU to protect the list of wakeirqs. That > > breaks the irq bus locking infrastructure, which allows sleeping functions > > to be called so interrupt controllers behind slow busses, e.g. i2c, can be > > handled. > > > > The wakeirq functions hold rcu_read_lock and call into irq functions, which > > in case of interrupts using the irq bus locking will trigger a > > might_sleep() splat. > > > > Convert the wakeirq infrastructure to Sleepable RCU and unbreak it. > > > > Fixes: 4990d4fe327b ("PM / Wakeirq: Add automated device wake IRQ handling") > > Reported-by: Brian Norris > > Suggested-by: Paul E. McKenney > > Signed-off-by: Thomas Gleixner > > Cc: stable@vger.kernel.org > > OK > > I guess it would be good to get this into 4.12? I think so, but it probably wants some testing and breeding in next. Thanks, tglx