Linux Power Management development
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Mark Salyzyn <salyzyn@android.com>
Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net,
	len.brown@intel.com, pavel@ucw.cz, linux-pm@vger.kernel.org,
	a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
	linux-rtc@vger.kernel.org, Mark Salyzyn <salyzyn@google.com>,
	Thierry Strudel <tstrudel@google.com>
Subject: Re: [PATCH v2 2/4] time: Print wall time at die and reboot
Date: Wed, 19 Jul 2017 00:06:39 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1707190002300.2425@nanos> (raw)
In-Reply-To: <20170718212117.123296-1-salyzyn@android.com>

On Tue, 18 Jul 2017, Mark Salyzyn wrote:

> Permits power state and battery life diagnosis.

This changelog is useless as long as you do not explain in which whay that
permits power state and battery life diagnosis.

I really have a hard time to figure out why you need to print RTC time on
oops or any of the other actions. That whole thing looks pretty
overengineered for a dubious value.

What kind of information is the current stuff missing and how are you using
this new information for better diagnosis?

Thanks,

	tglx

  reply	other threads:[~2017-07-18 22:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 21:21 [PATCH v2 2/4] time: Print wall time at die and reboot Mark Salyzyn
2017-07-18 22:06 ` Thomas Gleixner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-07-19 19:45 Mark Salyzyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1707190002300.2425@nanos \
    --to=tglx@linutronix.de \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=salyzyn@android.com \
    --cc=salyzyn@google.com \
    --cc=tstrudel@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox