From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [PATCH] coccinelle: api: detect duplicate chip data arrays Date: Thu, 5 Oct 2017 21:19:16 +0200 (CEST) Message-ID: References: <1506861768-5734-1-git-send-email-Julia.Lawall@lip6.fr> <1507230959.4434.39.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1507230959.4434.39.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr To: Joe Perches Cc: Linux PM mailing list , Nicolas Palix , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List , Masahiro Yamada , Liam Breck , Michal Marek , =?ISO-8859-15?Q?Pali_Roh=E1r?= , Sebastian Reichel , kbuild test robot , cocci@systeme.lip6.fr List-Id: linux-pm@vger.kernel.org On Thu, 5 Oct 2017, Joe Perches wrote: > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > > > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: > > > > > 2017-10-01 21:42 GMT+09:00 Julia Lawall : > > > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > > > > within a single structure. It is currently specific to the file > > > > drivers/power/supply/bq27xxx_battery.c. > > > > > > > > Signed-off-by: Julia Lawall > > > > > > > > --- > > > > > > Applied to linux-kbuild/misc. > > > > Thanks for picking it up. > > If it is specific to one file, why not just run it > and post the resultant patch? Why have it in tree? I guess that they anticipate that the data may change in the future? If id-utils is used, Coccinelle will completely ignore files that don't contain BQ27XXX_DATA, so the rule will have essentially no performance impact. If there is no indexing, it will only "grep" for BQ27XXX_DATA, not actually parse the files that don't contain it. So there is not much performance impact even in that case. julia