From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [PATCH] coccinelle: api: detect duplicate chip data arrays Date: Thu, 5 Oct 2017 21:28:00 +0200 (CEST) Message-ID: References: <1506861768-5734-1-git-send-email-Julia.Lawall@lip6.fr> <1507230959.4434.39.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Liam Breck Cc: Joe Perches , Masahiro Yamada , Sebastian Reichel , =?ISO-8859-15?Q?Pali_Roh=E1r?= , Linux PM mailing list , kernel-janitors@vger.kernel.org, Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, Linux Kernel Mailing List , kbuild test robot List-Id: linux-pm@vger.kernel.org On Thu, 5 Oct 2017, Liam Breck wrote: > Hi Joe, > > On Thu, Oct 5, 2017 at 12:15 PM, Joe Perches wrote: > > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > >> > >> On Fri, 6 Oct 2017, Masahiro Yamada wrote: > >> > >> > 2017-10-01 21:42 GMT+09:00 Julia Lawall : > >> > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > >> > > within a single structure. It is currently specific to the file > >> > > drivers/power/supply/bq27xxx_battery.c. > >> > > > >> > > Signed-off-by: Julia Lawall > >> > > > >> > > --- > >> > > >> > Applied to linux-kbuild/misc. > >> > >> Thanks for picking it up. > > > > If it is specific to one file, why not just run it > > and post the resultant patch? Why have it in tree? > > The driver which this script analyzes supports more than a dozen > different chips, which require different parameters. This script > checks for duplicate parameter arrays. I think the question is more how will the code change over time. julia